Re: Review Request: allows kopete to set the mood in skype

> On Jan. 21, 2010, 3:06 p.m., Pali Rohár wrote: > > Can you backport it to 4.4? > > Alin M Elena wrote: > The patch should work without problems. I do not know who can commit it > to the branch... Probably would be faster to speak with the distribution > people... I really do not know wha

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-21 15:06:56, Pali Rohár wrote: > > Can you backport it to 4.4? > > Alin M Elena wrote: > The patch should work without problems. I do not know who can commit it > to the branch... Probably would be faster to speak with the distribution > people... I really do not know what to

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-21 15:06:56, Pali Rohár wrote: > > Can you backport it to 4.4? The patch should work without problems. I do not know who can commit it to the branch... Probably would be faster to speak with the distribution people... I really do not know what to do... Roman do you have any though

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-18 22:08:12, Roman Jarosz wrote: > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp, > > line 228 > > > > > > Fix the indentation Hi Roman I have seen you commit

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-18 22:08:12, Roman Jarosz wrote: > > Fix the one broken indentation an you can commit it. Hi Roman, I do not have an svn account. Can you do the commit please? Alin - Alin M --- This is an automatically generated e-mail.

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/ --- (Updated 2010-01-18 22:29:21.374981) Review request for Kopete. Changes --

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3772 --- Can you backport it to 4.4? - Pali On 2010-01-18 22:29:21, Alin M E

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3744 --- Ship it! Fix the one broken indentation an you can commit it. svn:/

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/ --- (Updated 2010-01-10 11:57:49.877887) Review request for Kopete. Changes --

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/ --- (Updated 2010-01-10 13:02:16.484270) Review request for Kopete. Changes --

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-10 10:48:48, Pali Rohár wrote: > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp, > > line 215 > > > > > > Skype support setting status message when you go offli

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-10 10:48:48, Pali Rohár wrote: > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp, > > line 215 > > > > > > Skype support setting status message when you go offli

Re: Review Request: allows kopete to set the mood in skype

> On 2010-01-10 09:52:39, Roman Jarosz wrote: > > From technical point of view it's ok, but you need to fix the whitespaces. > > The original code most likely uses tabs and you use spaces, so please use > > also tabs so your new code is aligned to the old one, and also see the > > comments in

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/ --- (Updated 2010-01-09 12:39:59.690484) Review request for Kopete. Changes --

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3630 --- The whitespaces still are not ok :) ... Use kwrite/kate and you will s

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3631 --- The whitespaces still are not ok :) ... Use kwrite/kate and you will s

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3626 --- svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/

Re: Review Request: allows kopete to set the mood in skype

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3625 --- >From technical point of view it's ok, but you need to fix the whitesp