> On 2010-01-10 09:52:39, Roman Jarosz wrote: > > From technical point of view it's ok, but you need to fix the whitespaces. > > The original code most likely uses tabs and you use spaces, so please use > > also tabs so your new code is aligned to the old one, and also see the > > comments in the code. Thanks
thanks, I will try to solve all your comments and post the new version tonight > On 2010-01-10 09:52:39, Roman Jarosz wrote: > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp, > > line 155 > > <http://reviewboard.kde.org/r/2534/diff/2/?file=16745#file16745line155> > > > > Method/function should start with lowercase letter so something like > > setUserProfileRichMoodText of course. Probably I was drank when I wrote it. thanks > On 2010-01-10 09:52:39, Roman Jarosz wrote: > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp, > > line 241 > > <http://reviewboard.kde.org/r/2534/diff/2/?file=16746#file16746line241> > > > > It's better to have this at the beginning of function thought the same but did not want to touch the original code more than necessary. - Alin M ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2534/#review3625 ----------------------------------------------------------- On 2010-01-09 12:39:59, Alin M Elena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2534/ > ----------------------------------------------------------- > > (Updated 2010-01-09 12:39:59) > > > Review request for Kopete. > > > Summary > ------- > > enhances skype wrapper and permits kopete to set the profile mood (status > message) for skype > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=221535. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=221535 > > > Diffs > ----- > > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.h > 1070407 > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp > 1070407 > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp > 1070407 > > Diff: http://reviewboard.kde.org/r/2534/diff > > > Testing > ------- > > I have tested on linux, opensuse 11.2 with kde 4.3.87 > tested different manually set profiles Online, Away, Busy... > and the now listen plugin too. > All seem to work... > > > Thanks, > > Alin M > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
