[Koha-devel] Software error: substr outside of string

2008-11-05 Thread harry wykman
In performing a z39.50 search in my new koha installation, I get the following error: Software error: substr outside of string at /usr/share/koha/lib/C4/Charset.pm line 241. CGI::Carp Any ideas? Thanks, Harry ___ Koha-devel mailing list [EMAI

Re: [Koha-devel] GetMember() cardnumber vs. firstname search

2008-11-05 Thread Joe Atzberger
On Wed, Nov 5, 2008 at 10:29 AM, Galen Charlton <[EMAIL PROTECTED]>wrote: > Hi, > > On Wed, Nov 5, 2008 at 5:48 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > > Why do you find that not beautiful ? > > From a perf pov, it's efficient : do an exact search, and if you don't > > find anything, open t

Re: [Koha-devel] [PATCH] C4::Table - A simple OO database abstraction layer.

2008-11-05 Thread Joe Atzberger
On Wed, Nov 5, 2008 at 5:42 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Joe Atzberger a écrit : > > Paul -- > > > > I think you mean all the SQL should be in C4, and yes I agree with > > that. C4::Table does not receive any SQL as arguments to select, insert > > or delete. I.E., it preserves t

Re: [Koha-devel] [Koha] error in Amazon.pm script?

2008-11-05 Thread Nicolas Morin
On Wed, Nov 5, 2008 at 8:29 PM, Joshua Ferraro <[EMAIL PROTECTED]> wrote: > On Wed, Nov 5, 2008 at 11:51 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: >> Emrys Minnig wrote: >> >>> Something that might be of interest to the development team... >>> I think there's a small oversight in C4/Amazon.pm.

Re: [Koha-devel] [Koha] error in Amazon.pm script?

2008-11-05 Thread Joshua Ferraro
On Wed, Nov 5, 2008 at 11:51 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: > Emrys Minnig wrote: > >> Something that might be of interest to the development team... >> I think there's a small oversight in C4/Amazon.pm. On line 101 it reads: >> >> my $uri = >> "http://www.amazon.com/gp/reader/$isb

[Koha-devel] Whitespace fixes

2008-11-05 Thread Galen Charlton
Hi, As was pointed out in connection with a recent patch, it can be difficult to evaluate patches that combine both functional and whitespace fixes, particularly if a significant amount of the patch simply changes indentation. If you find it necessary to reformat a large chunk of code, please con

Re: [Koha-devel] [Koha] error in Amazon.pm script?

2008-11-05 Thread Rick Welykochy
Emrys Minnig wrote: > Something that might be of interest to the development team... > I think there's a small oversight in C4/Amazon.pm. On line 101 it reads: > > my $uri = > "http://www.amazon.com/gp/reader/$isbn/ref=sib_dp_pt/002-7879865-0184864#reader-link";; > > This line ignores the loca

Re: [Koha-devel] GetMember() cardnumber vs. firstname search

2008-11-05 Thread Galen Charlton
Hi, On Wed, Nov 5, 2008 at 5:48 AM, Paul POULAIN <[EMAIL PROTECTED]> wrote: > Why do you find that not beautiful ? > From a perf pov, it's efficient : do an exact search, and if you don't > find anything, open the search. It is one thing for a patron search user interface to use a broad set of s

[Koha-devel] problem with CGI::Session (Auth ERROR : cannot get_session() )

2008-11-05 Thread Paul POULAIN
Hello, The maintainers of the CGI::Session package have splitted the package in smaller pieces. If you install or upgrade CGI::Session to 4.38, you won't have CGI::Session::serialize::yaml, and Koha won't work anymore at all (impossible to get a session, so, you'll get a nasty "Auth ERROR: Cann

Re: [Koha-devel] GetMember() cardnumber vs. firstname search

2008-11-05 Thread Paul POULAIN
Galen Charlton a écrit : > Hi, Hi, > C4::Members::GetMember(), when used to look up a patron by cardnumber, > retries the search on borrowers.firstname if there are no rows that > have the barcode in borrowers.cardnumber. > > This is not exactly beautiful, and I assi,e it was inspired by some > l

Re: [Koha-devel] [PATCH] C4::Table - A simple OO database abstraction layer.

2008-11-05 Thread Paul POULAIN
Joe Atzberger a écrit : > Paul -- > > I think you mean all the SQL should be in C4, and yes I agree with > that. C4::Table does not receive any SQL as arguments to select, insert > or delete. I.E., it preserves the encapsulation of SQL inside C4/*. > > This would speed up development of featu

Re: [Koha-devel] Trouble with Business::ISBN for Lenny

2008-11-05 Thread Vincent Danjean
> On Thu, Oct 30, 2008 at 11:18 PM, harry wykman <[EMAIL PROTECTED]> wrote: > >> Hello, >> >> I am trying to install koha3 on Debian 'lenny' using the instructions >> for 'sarge'. Joe Atzberger wrote: > So you should do: > sudo cpan LWP::Simple No, on lenny, all module should be packaged (to be e