On Wed, Nov 5, 2008 at 8:29 PM, Joshua Ferraro <[EMAIL PROTECTED]> wrote: > On Wed, Nov 5, 2008 at 11:51 AM, Rick Welykochy <[EMAIL PROTECTED]> wrote: >> Emrys Minnig wrote: >> >>> Something that might be of interest to the development team... >>> I think there's a small oversight in C4/Amazon.pm. On line 101 it reads: >>> >>> my $uri = >>> "http://www.amazon.com/gp/reader/$isbn/ref=sib_dp_pt/002-7879865-0184864#reader-link";; >>> >>> This line ignores the locale settings (in my case UK) which the majority of >>> times breaks the 'Search Inside' capability. >> >> Which raises another question: why is there a URL such as the above >> hard-coded in the software? >> >> This kind of data should be treated as data ... and stored in the >> configuration database. > I see no advantage to treating the static portions of the URL as data, > especially since no other resource implements the Amazon.com API.
Another exemple: when a patron clicks on the amazon image on opac-detail.pl?biblionumber=x, she is taken to amazon.com, regardless of the locale settings. That might sometimes lead to odd behavior. Case in point: this book: "Le Rire jaune", isbn 2916266313. It exists in amazon.fr, with a cover image, so with my locale set to amazon FR, I do get the cover on opac-detail.pl; but when I click on the image, I'm redirected to amazon.com, where the book does not exist and I end up with a message from amazon telling me that : Your search "2916266313" did not match any products. Probably not what the patron expects. Nicolas > > Josh > >> cheers >> rickw >> >> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel@lists.koha.org >> http://lists.koha.org/mailman/listinfo/koha-devel >> > > > > -- > Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE > CEO migration, training, maintenance, support > LibLime Featuring Koha Open-Source ILS > [EMAIL PROTECTED] |Full Demos at http://liblime.com/koha |1(888)KohaILS > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha.org > http://lists.koha.org/mailman/listinfo/koha-devel > > _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
