Hi all,
AFAIK in our commit messages we are using two different trailers:
- Signed-off-by tells who tested/reviewed the patch
- Sponsored-by tells who sponsored the patch
I recently stumbled upon the contribution guidelines for git [1] which
suggests to use Reported-by, Acked-by, Reviewed-by, Tes
> Should we use Reported-By ?
Could be added optionally imo. No problem. Replace By with by btw.
> Should we replace Signed-off-by by Tested-By (for testers) and Reviewed-By
> (for QA) ?
> Should we use Signed-off-by as suggested in the git-commit manpage ?
Bit late in the project to make this
Le 19/09/2018 à 16:44, Marcel de Rooy a écrit :
>> Should we replace Signed-off-by by Tested-By (for testers) and Reviewed-By
>>(for QA) ?
>> Should we use Signed-off-by as suggested in the git-commit manpage ?
> Bit late in the project to make this change imo? But yes, our
> interpretation is qui
> > Bit late in the project to make this change imo? But yes, our
> > interpretation is quite different ;)
> But it's never too late to make a positive change, right ? :)
I agree that it's not too late to make useful changes to our workflow.
There was a time when we didn't even sign off patches!
I like the idea of adding more uses. Mentored-by is interesting information
on the QA step, for example.
El mié., 19 sept. 2018 a las 12:39, Owen Leonard ()
escribió:
> > > Bit late in the project to make this change imo? But yes, our
> > > interpretation is quite different ;)
> > But it's never