Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2019-02-20 Thread Ere Maijala
I've now rewritten the holdings implementation in bug 20447 to use the Koha namespace and modern code style. Feel free to comment. :) --Ere Ere Maijala kirjoitti 9.4.2018 klo 11.41: > There's now an initial patch available, so feel free to take a look at > how much it touches areas waiting to be

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-09 Thread Ere Maijala
There's now an initial patch available, so feel free to take a look at how much it touches areas waiting to be rewritten or cleaned. I don't feel it's very high impact, but then I'm the one hoping for this to be accepted. I'm ready to clean up any of the added code as necessary. It's currently

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-09 Thread Ere Maijala
Yes, that's also a possibility, but I'm trying to keep the initial implementation as simple as possible, so it doesn't currently include any changes to holds or circulation. It's a good candidate for future development. --Ere Hugh Rundle kirjoitti 6.4.2018 klo 8.55: This sounds great. I'm as

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-09 Thread Ere Maijala
l-boun...@lists.koha-community.org] On Behalf Of Ere Maijala Sent: Thursday, 5 April 2018 5:23 PM To: Sebastian Hierl ; Nick Clemens Cc: Koha ; Koha Devel Subject: Re: [Koha-devel] [Koha] RFC for MARC holdings record support Good morning! Thanks for the feedback. I added a note to the RFC about

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-06 Thread Jonathan Druart
I am not sure I understand all the ramifications of this RFC, what it implies (and I do not have time to dedicate to this right now), but I feel like Marcel. It sounds like these changes will touch lot of areas in Koha that are waiting to be rewritten/cleaned. We already have a lot of things waitin

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-06 Thread Marcel de Rooy
If I am reading about possible impact on holds functionality, I guess that we could better prioritize finishing REST API and moving to DBIx/Koha::Object. ___ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-06 Thread David Cook
l Message- From: koha-devel-boun...@lists.koha-community.org [mailto:koha-devel-boun...@lists.koha-community.org] On Behalf Of Katrin Fischer Sent: Friday, 6 April 2018 3:27 PM To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] [Koha] RFC for MARC holdings record support Hi David

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-05 Thread Katrin Fischer
munity.org [mailto:koha-devel-boun...@lists.koha-community.org] On Behalf Of Ere Maijala Sent: Thursday, 5 April 2018 5:23 PM To: Sebastian Hierl ; Nick Clemens Cc: Koha ; Koha Devel Subject: Re: [Koha-devel] [Koha] RFC for MARC holdings record support Good morning! Thanks for the feedback. I ad

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-05 Thread David Cook
Koha Devel Subject: Re: [Koha-devel] [Koha] RFC for MARC holdings record support Good morning! Thanks for the feedback. I added a note to the RFC about embedded holdings in bibliographic records. They cover a lot of needs and we have considered embedding the holdings, but there are issues if there ar

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-05 Thread Ere Maijala
Good morning! Thanks for the feedback. I added a note to the RFC about embedded holdings in bibliographic records. They cover a lot of needs and we have considered embedding the holdings, but there are issues if there are multiple holdings. Regards, Ere Sebastian Hierl kirjoitti 5.4.2018 kl