On 22/04/14 18:10, Lorenzo Marcantonio wrote:
> Tell me if you want them and where to put them;
I'd very much like to see them. Most convenient for me, personally, is
some sort of git repository, at Github or elsewhere. Others may prefer
bzr for easier integration with Launchpad?
> On Tue, Apr 2
On 27/04/14 20:18, Francesco Del Degan wrote:
>
> Yes, I will try to reuse the helper classes that was committed few days ago,
> and fix some issues with it. (I just discovered that actual BGA
> footprint uses all
> 26 letters, but only ABCDEFGHJKLMNPRTUVWY should be allowed) .
My bad, thanks fo
I think it would be a good idea to allow unknown fields in the
s-expression formats so that an older KiCad doesn't choke on things it
doesn't understand, and doesn't need to.
For example, I was thinking that it might be helpful to add a field to
the footprint format: "part_reference", which would
On 06/05/14 21:47, Jean-Paul Louis wrote:
Why not collect all the field of any part being loaded, and consider
all the fields that are not known as “user defined fields”?
In future you may want you use a word for a new field, and you don't
really want to stomp on some poor sap who thought he c
On 06/05/14 23:18, Tomasz Wlostowski wrote:
How about about adding a generic attribute set for each part, stored as
a list of type-name-value entries:
(part xxx
(attribute "simulation_model" (string ".cir") )
(attribute "part_reference_farnell" (int 123456 ) )
)
Such scheme would n
On 06/05/14 21:47, Lorenzo Marcantonio wrote:
That said, I think that *if* the sexp reader can traverse automatically
a generic sexp (without having a grammar, only tokenising) we could
decide that it could 'skip' each subexpression starting with an unknown
token. Maybe with warnings:D
I would
On 08/05/14 15:53, Dick Hollenbeck wrote:
>
>> That's exactly what I mean - older versions of KiCad should be able to
>> ignore, but retain, unknown data.
>
> This sentence has two concepts in it. One is fools gold, the other is poorly
> expressed.
>
> 1) An older kicad should load a data fil
On 07/05/14 07:19, Lorenzo Marcantonio wrote:
> On Wed, May 07, 2014 at 12:48:22AM +0100, John Beard wrote:
>> I would have thought this would exactly be done at the end of tokenisation
>
> More or less, that's the idea :D
>
> There are various ways to do this but all
On 08/05/14 20:12, Lorenzo Marcantonio wrote:
> On Thu, May 08, 2014 at 07:31:47PM +0100, John Beard wrote:
>> it will show you what it can. You'd be annoyed if it didn't, it would be
>> like Flash needing the latest version to watch your video, without the
>> excuse
On 08/05/14 20:44, Dick Hollenbeck wrote:
> On 05/08/2014 02:18 PM, Dick Hollenbeck wrote:
>> On 05/08/2014 01:31 PM, John Beard wrote:
>>> On 08/05/14 15:53, Dick Hollenbeck wrote:
>> Submit a patch.
>>
>> Hope it gets accepted.
>
> Since your interes
On 09/05/14 19:49, Maciej Sumiński wrote:
It was not used for when designing the current parser, but you may find
useful include/profile.h. Have a look at common/view/view.cpp for an
example of usage (search for 'prof_counter').
Thanks, that looks useful.
I'm trying to write a separate test a
On 13/06/14 19:36, Lorenzo Marcantonio wrote:
> On Fri, Jun 13, 2014 at 06:46:37PM +0100, John Beard wrote:
>> The silk screen is put so it can be seen after soldering. The ASCII art
>> arrow is an assembly layer feature, modelled after the IPC standard.
>
> Sorry my fault.
On 13/06/14 20:44, Lorenzo Marcantonio wrote:
> On Fri, Jun 13, 2014 at 08:33:02PM +0100, John Beard wrote:
>> OK, I won't worry too much about it and get one with making more
>> footprints! Are there any more things you'd like to see changed? No
>> matter how ti
On 13/06/14 21:23, Nick Østergaard wrote:
> I like the 3D view very much, even the old simple one is great for
> verifying tracks. I often find things I want to change when looking at
> the 3D view of just the traces and silk.
I agree, I think it's having an alaternative perspective. A bit like
g
Hi,
I have made some changes to the helpers for the footprint wizards. There
is now a matrix-based transform stack that helps simplify calculations
that footprint wizards need to do. The patch attached is based on BZR
rev 4975.
There are also some tests in the pcbnew/scripting/tests directory
Hi,
I am trying to get fp_poly working in the footprint wizards. It seems
that I should be using pcbnew.DRAWSEGMENT.SetPolyPoints(), which takes a
std::vector as an argument. I tried to feed it a Python list
of wxPoints, but it couldn't handle that:
File
"/home/john/src/kicad/pcbnew/scripting
Hi,
I have a patch (fpw-overhaul.diff) for the Python footprint wizard
helpers. This adds a few more drawing functions, such as for circles,
and also uses a matrix-based transform stack with greatly simplifies
constructing footprints consisting of regularly spaced elements (e.g. in
lines, grids, c
Hi,
Here is a small patch to make the component chooser dialogue and the
library browser dialogue use the main workspace background colour (white
or black, as configured) instead of white, which otherwise looks
inconsistent when the main workspace is black.
Because DIALOG_CHOOSE_COMPONENT and LI
Hello,
Attached is a small patch that does a few things in the eeschema component
chooser:
* Shows aliases' names, rather than the root device names in the
preview window
* Doesn't paint the background if nothing is selected
* Add the component name as a heading in the descri
On 06/10/14 23:44, John Beard wrote:
> Hello,
>
> Attached is a small patch
Sorry, that's inlined. Here's the patch as an attachment if that is
preferred.
Cheers,
John
diff --git a/eeschema/dialogs/dialog_choose_component.cpp b/eeschema/dialogs/dialog_choose_componen
70ae9021113 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 11 Jan 2017 22:48:57 +0800
Subject: [PATCH] Signal handlers for Kicad and Single-Top programs
This allows Kicad programs to be terminated with Ctrl-C (or SIGINT in
general) and still execute the correct shutodwn procedure. Previously,
And here is the patch with the class name in capitals and a class
comment block. Sorry!
On Wed, Jan 11, 2017 at 11:26 PM, John Beard wrote:
> Hi,
>
> None of the KiCad programs appear to implement any signal handlers.
> This means that some of them (e.g. pcbnew) don't respond
en KiCad one day moves on to C++14, this file
can be removed entirely and forgetten!
Cheers,
John
From 5762fed4ae255612d244f5ab51c88c6b3c31fde4 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sun, 22 Jan 2017 00:03:01 +0800
Subject: [PATCH] Add C++14-style std::make_unique 'polyfill' fo
e overrides that are part of a
larger inheriance hierarchy.
Cheers,
John
From 4f726e83fb44f5057a28b05777bfef5613b3fbf9 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sun, 22 Jan 2017 04:19:46 +0800
Subject: [PATCH 1/2] Tidy consts for class D_PAD
Some accessors should be const:
* IsFlipped
FWD to list
-- Forwarded message --
From: John Beard
Date: Mon, Jan 23, 2017 at 8:36 AM
Subject: Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11
To: Wayne Stambaugh
The idea with std::make_unique is essentially that when making
std::unique_ptrs, you never
will avoid a
double-recompile for anyone pulling both at once!
Cheers,
John
From f8c76db985a90fbf5e209317e04011028b95e4de Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 17 Jan 2017 13:57:53 +0800
Subject: [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME
There is nothing PCB-frame
).
Fixes: LP 1591625
https://bugs.launchpad.net/kicad/+bug/1591625
From 317510c194c8e8c3829abb4cdabbeab773b087bc Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sun, 22 Jan 2017 01:32:45 +0800
Subject: [PATCH] Allow editing locked modules in modedit
Since you have to explicitly enter the module editor
Hi,
This patch initialises a class member in OPENGL_GAL. It uses the
SetTarget function to make sure the target and manager initialise in
a consistent way.
Cheers,
John
From f9a0fc626f78337165595f18f4dca73afa11a9af Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 23 Jan 2017 13:19:10
t Flip( const TOOL_EVENT& aEvent );
/**
+ * Function Mirror
+ *
+ * Mirrors the current selection. The mirror axis passes though the current point.
+ */
+int Mirror( const TOOL_EVENT& aEvent );
+
+/**
* Function Remove()
*
* Deletes currently
Sorry, attached the wrong version of the "import export" patch - this
is the correct sequence.
On Wed, Jan 25, 2017 at 12:41 AM, John Beard wrote:
> Hi,
>
> Here are two patches for outstanding GAL functionality: pad
> import/export/push and modedit mirroring.
>
>
member, "pcb", that gets conditionally initialised
in that function, so it's impossible without a mutable, which I'm not
sure would be correct or not.
Cheers,
John
From 5d745e925631107ec0bd462907955345cacae2fd Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 27 Jan 2017 23
#x27;s pre-existing and a different issue.
Due to the use of a const-reference BOARD&, this patch relies on
yesterday's "Consts in BOARD" patch.
Cheers,
John
From 97cdca03faefe694bc49297db40ba000ca0025f8 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 27 Jan 2017 23:44
ialog as needed.
The third patch is optional, but tidies up a copy-pasted selection
routine into a named function and adds a little commentary to a couple
of related existing functions.
Cheers,
John
From fd30b0465e0b627a4f69fa574f077396ea3f7861 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue,
Hi,
I support the general idea of being able to turn off bits of the
legacy canvas at will, in principle. However, I'm not sure how many
people will actually bother to check if stuff behind an #ifdef is
getting broken, and legacy stuff is quite vulnerable because of tight
binding to large classes
On Sat, Feb 4, 2017 at 8:10 PM, Nick Østergaard wrote:
> I have attached a patch that renames this. It contains three commits
> for easier review.
Sounds good to me.
At the (considerable) risk of bikeshedding, I might also suggest
something like "stash" or "store" instead of "copy", since the us
ional rotation to
everywhere there is unidirectional rotation in GAL now).
Cheers,
John
From 77bc4b3b42d64137d915aecdfef0139150c0844b Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sat, 4 Feb 2017 13:09:50 +0800
Subject: [PATCH] Add CCW rotation to GAL canvas
This makes "rotate" in
comment (one
more TODO down!)
Cheers,
John
From 42a706a236276f88a06a1202ab01326614c3e2e9 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sat, 4 Feb 2017 09:42:37 +0800
Subject: [PATCH] Do not include arc centre in bounding box
Arc centres don't land in the bounding box when the arc angle is
alt remove, which wasn't used
until now.
Cheers,
John
From 9fc80d8c5fc971cab9f756bc87a7383b732dfeba Mon Sep 17 00:00:00 2001
From: John Beard
Date: Sat, 4 Feb 2017 14:45:52 +0800
Subject: [PATCH 2/2] Allow delete whole track in GAL
This commit wires up the as-yet-unused "remove alternate" tool act
Apparently those patches don't apply because the diff context lines
have a line of a different non-mainline patch in them (from the rotate
CCW patch).
Hopefully, these will apply to the current master.
On Sun, Feb 5, 2017 at 9:23 PM, John Beard wrote:
> Hi,
>
> These patches impl
Hi,
This patch fixes a GAL usability quirk with the T hotkey (find and move).
Fixes: https://bugs.launchpad.net/kicad/+bug/1571214
Cheers,
John
From 191412b93ba263f69d69e75cabb7758b175607bd Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 6 Feb 2017 18:16:36 +0800
Subject: [PATCH] Warp to
Hi,
This patch adds a missing tool to GAL: duplicate zone onto layer.
It's accessed through the zones context menu and does the same as the
legacy mode version.
Cheers,
John
From 031b15406695e60b17af6bb9e8b984e662c728d8 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 6 Feb 2017 11:
s and bug surface, but because this tool
doesn't have a lot of backend of it's own, it's not a significant
factor.
Note: I am not submitting this patch in the expectation that it be
merged, it's an example (I wouldn't stop anyone though!).
Cheers,
John
On Sun, Feb 5,
The first of these patches has a mistake in the selection code, which
used to clear the selection and replace it, and should now augment,
not replace.
Please use the attached patches instead.
Thanks,
John
On Mon, Feb 6, 2017 at 12:37 AM, John Beard wrote:
> Apparently those patches do
Hi,
Here is a patch to show zero-thickness lines in GAL using the "outline width".
This addressess https://bugs.launchpad.net/kicad/+bug/1501749
Cheers,
John
From 60dfc34c70493bf05f77ecd4dca7594b46798c8e Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 7 Feb 2017 18:21:26 +08
iliar with the
PNS, so I'm not sure where to start to do that.
Cheers,
John
From 7e493417cf1f04912a0f47681a40f30f2a9e96e3 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Thu, 2 Feb 2017 00:14:18 +0800
Subject: [PATCH] Add drag tool to GAL edit tool
This adds segment endpoint dragging whe
/~john-j-beard/kicad/+git/kicad/+ref/drag_tracks
On Wed, Feb 8, 2017 at 9:47 AM, John Beard wrote:
> Hi,
>
> Here is a really basic concept patch for component dragging with
> tracks ('G') in pcbnew GAL.
>
> It uses the same dragging mechanism as legacy for modules and pad
On Thu, Feb 9, 2017 at 2:01 AM, Kristoffer Ödmark
wrote:
> I am seeing the "Pads" menu entry when right-clicking empty in linux, "push
> pads settings" is enabled in the submenus and if I press that one and get a
> small dialog, the button "Pad Editor" gives me a segfault. I am guessing
> that is
Here is a Launchpad bug for tracking the broken Windows submenus:
https://bugs.launchpad.net/kicad/+bug/1663101
On Wed, Feb 8, 2017 at 10:37 PM, jp charras wrote:
> Recently, some enhancements were added to the right click popup context menus.
>
> On windows, most are broken:
>
> For instance, Bo
On Wed, Feb 8, 2017 at 6:48 AM, Nick Østergaard wrote:
> Mm, it seems this also reverses it such that you have to use backspace
> to delete a footprint whereas in that case the delete key should be
> used.
Hi Nick,
The latest patch (Feb 7) should not do that - for me, both 'delete' and
'backspac
Hi,
I have a big set of patches on a branch that are mostly to do with
stripping seldom-used functions out of common.h into more targeted
headers:
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/tidy_ups
The idea here is to reduce the visibility of these functions from
almost ever
merged. I'll try to take a look at it over the weekend. Keep up the
> great work.
>
> Thanks,
>
> Wayne
>
> On 2/9/2017 8:44 AM, John Beard wrote:
>> Hi,
>>
>> I have a big set of patches on a branch that are mostly to do with
>> st
On Fri, Jan 27, 2017 at 12:44 AM, Wayne Stambaugh wrote:
> Simon,
>
> Thanks for testing this. It was on my list but it looks like it has to
> be fixed before we can commit it.
>
> Cheers,
>
> Wayne
Thanks for testing on OSX, Simon.
On Linux, I never see this, which must mean somehow that Pytho
The branch has been rebased to avoid conflicts with recent GAL commits:
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/deletetrack
On Thu, Feb 9, 2017 at 2:51 PM, Nick Østergaard wrote:
> Ahh ok, I see that is working alright.
>
> 2017-02-09 5:44 GMT+01:00 John Beard :
On Fri, Feb 10, 2017 at 3:44 PM, Maciej Suminski
wrote:
>
> On 02/08/2017 03:37 PM, jp charras wrote:
>>
>> For instance, Board editor:
>> context menu for zones: submenus are not working.
>> context menu with no tool: the pad export import menu is always shown.
>> context menu for tracks: the tit
Hi,
This branch has patches for the Add Similar Zone and Add Zone Cutout
tools in GAL:
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/zone_tools
They are preceded by a refactor which makes the tools themselves into
relatively straightforward modifications of the existing interact
Hi,
Here is a branch with a GAL action to invoke the block select dialog
and filter the current selection based on the results:
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/select_filter
The first commit refactors the dialog so it can be reached by the GAL
too, the second plumb
ntirely sure which OS you are using, but LightShot [1] is fantastic
>>> at being able take pictures of menus on Windows. (It works on Mac also)
>>>
>>> [1] https://app.prntscr.com/en/index.html
>>>
>>> On Fri, Feb 10, 2017 at 3:55 PM, John Beard
>>
On Sat, Feb 11, 2017 at 5:54 AM, Nick Østergaard wrote:
> While we are at it, what about making the line graphic icon such that
> it matches the style of the arc and circle? That is making it not
> dashed, and add anchor point indicators?
I think that the "Graphic Line" tool in pcbnew should act
tons of new
> icons because the documentation will then be heavily out of sync.
>
> thanks a lot
> Fabrizio
>
>
> On Fri, Feb 10, 2017 at 10:55 PM, John Beard wrote:
>>
>> And here are the same images with the changed icons highlighted, maybe
>> not everyone love
On Mon, Feb 13, 2017 at 6:39 AM, Jon Evans wrote:
>
> The core of the issue is how KiCad thinks about selection of objects
> compared to most other software that deals with graphical objects that the
> user interacts with.
>
> Most applications have the concept of a "selection set" that contains 0
>
>
>
> On Tue, Feb 14, 2017 at 3:39 PM, Wayne Stambaugh
> wrote:
>>
>> Where do we stand on this? I think these changes should be committed.
>> If there are no objections, please send a patch to the dev list so I can
>> merge it.
>>
>> On 2/10/201
Hi,
Here is a branch with a set of patches to add the ability to set the
grid line/dot size and the minimum grid spacing (to avoid very dense
grids when using thicker lines).
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/grid_dot_size
This also includes moving the grid display s
yway, I thought I'd share this finding! Please find attached the
benchmark program, such as it is.
Cheers,
John
From 9030890b9ad86ff2601a0488ef6e0003dfbb2e66 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 15 Feb 2017 16:47:41 +0800
Subject: [PATCH] IO benchmark program: RICHIO vs s
segfaults. I suspect
> that kill focus event handler is executed after the window is gone, but
> I am not fully sure.
>
> There are also a few minor patches, see the attachments.
>
> Cheers,
> Orson
>
> On 02/16/2017 07:01 AM, John Beard wrote:
>> Hi,
>>
>> Her
efore returning, otherwise things like Enter in a dialog can do an
end run and not sanitise/update the value before returning.
I have integrated your mods into the patch sequence in the appropriate
places and rebased the branch onto master.
Cheers,
John
On Fri, Feb 17, 2017 at 12:27 AM, John Beard
ts. It's fairly trivial to change LINE_READER types. It
> might be a bit more flexible if you just provided an ISTREAM_LINE_READER
> that take any istream derived object rather than write a separate
> LINE_READER for each istream derivative.
>
> Cheers,
>
> Wayne
>
>
On Sun, Feb 19, 2017 at 10:46 AM, Chris Pavlina wrote:
> I just pushed the revamped component selector.
>
> Please, test thoroughly.
Hi Chris,
I get a bunch of asserts and then a crash on trying to place a part on
an empty sheet. This on Linux on a few pull from LP.
I have opened a bug for it t
On Sat, Feb 18, 2017 at 1:08 AM, Nox wrote:
> What about wxFFileInputStream instead of wxFileInputStream?
>
wxFFileInputStream appears to be about 5-6 times faster than
wxFileInputStream, but that's still much much slower than RICHIO or
std::ifstream.
$ qa/io_benchmark/io_benchmark /tmp/all.lib
HI Orson,
I think that sounds like a sensible idea. Having a huge central list
of actions has a bit of a code smell for me, as it's a big header than
then needs including everywhere. Smaller lists that are included along
with their tool's headers (if needed), or even actions that are
totally hidde
.
An additional benefit is that the icon list is now in its own header,
which makes it easier to automate in future.
Cheers,
John
From b72cbf3523c31e6e8af42d514beaa54b6ef5dd2e Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 20 Feb 2017 20:20:39 +0800
Subject: [PATCH] Move bitmaps.h out of
istency in that file.
Cheers,
John
From 92185ffb58305a7975d96c8a80c641ccb6cf80a4 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 21 Feb 2017 20:43:02 +0800
Subject: [PATCH 3/3] Use Bind rather than Connect in LAYER_WIDGET
Bind is safer than Connect. Bind is more flexible and has a more co
alog.
>> > > >
>> > > > This isn't "the layer manager", it's a color well IN the layer
>> > manager.
>> > > >
>> > > > >
>> > > > > If the single left click opens the dialog, be sure
Hi,
I have rebased this branch over the new PCB_ACTION changes.
Cheers,
John
On Sat, Feb 11, 2017 at 5:14 PM, John Beard wrote:
> Hi,
>
> Here is a branch with a GAL action to invoke the block select dialog
> and filter the current selection based on the result
be moved somewhere else.
>
> Regards,
> Orson
>
> 1. http://www.ohwr.org/attachments/4646/selection_filter.pdf
>
> On 02/22/2017 03:41 PM, John Beard wrote:
>> Hi,
>>
>> I have rebased this branch over the new PCB_ACTION changes.
>>
>> Cheers,
>>
&
a little to tidying up, and at least makes it
usable and consistent across platforms for v5.
Cheers,
John
On Tue, Feb 21, 2017 at 11:05 PM, John Beard wrote:
> On Tue, Feb 21, 2017 at 10:41 PM, Wayne Stambaugh
> wrote:
>> I forgot to mention that this will likely clash with the COLO
Hi,
Please use this branch instead:
https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/swatches
The patches previously omitted the new colour picker in the rebase
(which is kind of important!).
Cheers,
John
On Thu, Feb 23, 2017 at 2:18 AM, John Beard wrote:
> Hi Wayne,
&g
From: John Beard
Date: Thu, 23 Feb 2017 10:47:19 +0800
Subject: [PATCH] Update GAL tool documentation
Update to reference new PCB_ACTIONs (used to be COMMON_ACTION)
Also expand on use of BOARD_COMMIT.
Add doxygen TOC markup
---
Documentation/development/tool-framework.md | 186
etty please use your words when
reporting bugs - in this case mentioning that it was GAL only would
have been a good pointer for a start!
Cheers,
John
From 8911c539669832d5b4e261acbbe48ca9ffa25b98 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Thu, 23 Feb 2017 22:02:18 +0800
Subject: [
2001
From: John Beard
Date: Tue, 7 Feb 2017 00:00:51 +0800
Subject: [PATCH] Add cancel interactive tool action to GAL
This is used to provide menu entries that allows cancellation of
interactive drawing and routing tools without needing the keyboard.
It is provided in the drawing tools and the
the
points, legacy can use them as normal.
Cheers,
John
From d9d18cd02e54ac3098e5b3ca7af667aeed3ef46b Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 24 Feb 2017 20:26:43 +0800
Subject: [PATCH 1/4] When filling/unfilling zones, create undo points in GAL
This is a feature which is apparently not
ep 17 00:00:00 2001
From: John Beard
Date: Fri, 24 Feb 2017 20:26:25 +0800
Subject: [PATCH] Draw zone hatching in GAL
This just uses the same hatch lines that are built into the zone as
legacy.
They are always drawn, even when there is a fill, as if the fill
doesn't reach the corners, the h
Hi,
Would it be possible to get the ubuntu builds tagged with a commit
hash? Version strings like 201702251416+7735~57~ubuntu16.10.1 are not
very useful if you want to know exactly which commit a build relates
to.
The exact commit is very useful when looking at a bug report from a
nightly. If a
Hi,
Sorry, that patch had a dependency on a previous commit in my patch stack.
Here's an updated one. PCB_EDITOR_CONTROL now inherits PCB_TOOL, not
TOOL_INTERACTIVE, so it can use the relevant BOARD_COMMIT constructor.
Cheers,
John
On Sat, Feb 25, 2017 at 2:50 PM, John Beard wrote:
Hi Julius,
The TOOL_EVENT_UTILS functions are for generic event decision logic.
That PCB_ACTIONS::routerInlineDrag acts as to cancel an in progress
routing is specific to the ROUTER_TOOL event loop, so it should
probably be OR'ed in in ROUTER_TOOL::performRouting(), like this:
else if( TO
On Tue, Feb 28, 2017 at 9:00 PM, Robbert Lagerweij
wrote:
> Hi Thomas,
>
> Thank you for your feedback. The duplication of code is indeed not how I
> would usually approach this but I thought it the lesser of two evils given
> the fact that the legacy stuff will most likely be deprecated immediate
:38 AM, John Beard wrote:
> Hi,
>
> Please use this branch instead:
>
> https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/swatches
>
> The patches previously omitted the new colour picker in the rebase
> (which is kind of important!).
>
> Cheers,
>
>
Hi Wayne,
On Wed, Mar 1, 2017 at 2:06 AM, Wayne Stambaugh wrote:
> Sorry John. I was going to recommend we apply your patch as is
> (assuming you didn't change the click behavior) to fix the gtk issue.
> We can discuss other changes to the behavior later.
I haven't changed any behaviour or posi
ated
> to bzr). I had changed it with the git-commit keywork. I should be useful.
>
> Le 26/02/2017 à 16:46, John Beard a écrit :
>> Hi,
>>
>> Would it be possible to get the ubuntu builds tagged with a commit
>> hash? Version strings like 201702251416+7735~57~ubuntu
On Wed, Mar 1, 2017 at 11:40 PM, Simon Richter wrote:
>
> color_swatch.cpp uses std::unique_ptr
Hi Simon,
This must be because the compiler (MSVC on Jenkins) has set
__cplusplus to something other than 201103L, so include/make_unique.h
isn't doing the polyfill and also isn't including . Perhaps
t not really
for things like sexp which don't have to have line breaks at all, or
if they do, don't have to put them in "friendly" places. But that's
the parser's problem!
Cheers,
John
On Thu, Mar 2, 2017 at 7:31 AM, Wayne Stambaugh wrote:
> On 2/19/2017 4:27 A
ers,
John
From 25566fab5dbd0ef185b995383eae1ca5b97f6c12 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 1 Mar 2017 09:59:25 +0800
Subject: [PATCH] Add WithAlpha method to COLOR4D
This is useful for taking a "base" color and making derived colours with
the given alpha, but the same RGB
Hi Wayne,
On Thu, Mar 2, 2017 at 9:02 PM, Wayne Stambaugh wrote:
>
> Does this patch get applied on top of the previous patch or does it
> replace the previous patch.
Sorry, that wasn't very clear! It's a new patch, all rebased into one
commit, since I messed with it quite a bit and the intermed
ext
> class basic_filebuf : public basic_streambuf<_CharT, _Traits>
>^
> tools/io_benchmark/CMakeFiles/io_benchmark.dir/build.make:77: recipe for
> target
> 'tools/io_benchmark/CMakeFiles/io_benchmark.dir/stdstream_line_reader.cpp.o'
> failed
>
Wrong (TM)!
Patch for adding buffered wx streams to the benchmark tool attached.
Cheers,
John
From d1d066d65a4e5525f3e47f731d7d132715aa6b88 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 3 Mar 2017 00:26:39 +0800
Subject: [PATCH] io_benchmark: Add wxBufferedInputStream benchmarks
Wh
needed.
Sorry for the long email: the change is not really that complex, but
the configuration process has several paths. As the first thing a new
user to Pcbnew sees, I think this is a fairly important thing to get
right.
Cheers,
John
From 8e1066a946a2a2fd5138790134ff1e3e7ce195da Mon Sep 17
Hi Wayne,
Thanks for taking a look!
On Mon, Mar 6, 2017 at 3:24 AM, Wayne Stambaugh wrote:
>
> It is perfectly acceptable to have an empty global library table and
> always use the project library table for defining footprint libraries so
> this check would be annoying to users who prefer this.
On 4 March 2017 21:37:56 GMT+00:00, Jon Evans wrote:
>A few more notes:
>
>- Grid settings hasn't been added in the GUI yet; I'll be taking that
>from
>pcbnew so user can pick dot/line/small
Hi Jon,
I haven't had a chance to recompile yet (full disclosure!) but this
sounds great.
For the GAL se
polyline and polygon,
it's not trivial, so I'm going to submit this first, separately.
Cheers,
John
From 4452895a9f014dfe4c4ad98070b5556ccfe81d68 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 7 Mar 2017 19:17:59 +0800
Subject: [PATCH] GAL: Respect SHAPE_LINE_CHAIN closed setting
Wh
le of places where it pre-emptively
strips spaces that should be removed when that bug is fixed.
(https://bugs.launchpad.net/kicad/+bug/1668455).
Cheers,
John
From 1e4baceaa73dd2d9dd189f71603a7916abd93850 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Thu, 9 Mar 2017 17:09:13 +0800
Subject: [PATCH 3/3] A
By the way, here's a screenshot of the ruler tool:
Cheers,
John
On Fri, Mar 10, 2017 at 1:11 AM, John Beard wrote:
> Hi,
>
> Here's a tool I'm had on my list for a while - a ruler tool.
>
> This patch set introduces a new directory, for "preview items"
1 - 100 of 464 matches
Mail list logo
