[Kicad-developers] [Patch] Clean up switch statement in pcbnew launcher

2019-08-13 Thread Ian McInerney
From 66f8772e179559c08f4d9ff2df72a8b3784b Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Wed, 14 Aug 2019 01:28:11 +0200 Subject: [PATCH] pcbnew: Clean up switch statement in launcher --- pcbnew/pcbnew.cpp | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a

[Kicad-developers] [Patch] Unify close menu item creation for non-main windows

2019-08-13 Thread Ian McInerney
. That window is a wxFormbuilder window so its menu is not a CONDITIONAL_MENU and can't use this. -Ian From 0fd6b672ce8b99f681497e1dba2746e2e84e5840 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Wed, 14 Aug 2019 01:34:05 +0200 Subject: [PATCH] Unify menu item creation for closing a w

Re: [Kicad-developers] macos 10.11

2019-08-19 Thread Ian McInerney
I'm going to revive the question Adam asked about keeping a list of the last stable version that was supported for each OS when it was dropped. I think it might be useful to do this for at least Mac and Windows, and just make sure to put a disclaimer that no support is given and no guarantees can b

Re: [Kicad-developers] [Patch] Add ability to reset Pcbnew layer colors to default

2019-08-22 Thread Ian McInerney
this, I was planning on doing it, but >> > there are several steps in between (first changing how settings in >> > general are stored, and then a general refresh of the layers/color >> > settings GUI) >> > >> > On Wed, Aug 21, 2019 at 5:06 PM Ian McInerney

Re: [Kicad-developers] Development version string announcement

2019-08-26 Thread Ian McInerney
Dino, I believe this change was only to the version number that will appear in front of the string. It should still show the commit hash if you are compiling from source after checking out from the git repository. Is this not what you see? -Ian On Mon, Aug 26, 2019 at 7:20 PM Dino Ghilardi wrot

[Kicad-developers] Linker Error (self made...)

2019-08-26 Thread Ian McInerney
I was trying to do a fresh build of master with the address sanitizer enabled in Clang, and I am receiving a strange linker error, and was curious if anyone else had any thoughts on it. When it tries to link the eeschema executable, it throws an error complaining about a missing Kiface symbol: Sc

Re: [Kicad-developers] Linker Error (self made...)

2019-08-28 Thread Ian McInerney
/utilities) without bringing in the entire EDA frame stack (since that seems to be the root cause of these reference issues). Thoughts? -Ian On Tue, Aug 27, 2019 at 1:43 PM Simon Richter wrote: > Hi, > > On Tue, Aug 27, 2019 at 02:56:37AM +0200, Ian McInerney wrote: > > > I wa

Re: [Kicad-developers] Linker Error (self made...)

2019-08-28 Thread Ian McInerney
ler chunks. -Ian On Wed, Aug 28, 2019 at 10:47 AM Ian McInerney wrote: > Thanks for the pointers. After digging into this some more, I think what > is happening is that including the sanitizers changes the behavior of the > linker. It seems that it really doesn't like undefi

Re: [Kicad-developers] Linker Error (self made...)

2019-08-28 Thread Ian McInerney
wrote: > Please go for it. The separate DLLs make it hard to design a python api > where eeschema and pcbnew can share resources. > > Regards, Thomas > > Am 28.08.19 um 16:03 schrieb Simon Richter: > > Hi, > > > > On Wed, Aug 28, 2019 at 10:47:52AM +0200, Ian M

Re: [Kicad-developers] Minimum Boost version

2019-08-28 Thread Ian McInerney
Going up to 1.67 won't be possible, since 18.04 is estimated to be supported by KiCad until 2023 ( http://kicad-pcb.org/help/system-requirements/). If anything, it might make sense to go to 1.59 now, and re-evaluate it farther in the v6 development (such as when the Python minimum version is also r

[Kicad-developers] [Patch] Update common preview items

2019-08-31 Thread Ian McInerney
. -Ian From 362f4bba2379c64bc8455d5b857face5f5d1d76f Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Sat, 31 Aug 2019 16:35:33 +0200 Subject: [PATCH] Switch preview items to use abstract render settings --- common/preview_items/arc_assistant.cpp | 1 - common/preview_items/polygon_item.cpp

[Kicad-developers] [Patch] Fix wxWidget compatibility issues

2019-08-31 Thread Ian McInerney
2001 From: Ian McInerney Date: Thu, 29 Aug 2019 12:04:18 +0200 Subject: [PATCH 01/10] wxWidgets compatibility fixes * Remove unneeded check * Fix WX_GRID since upstream renamed a variable in 3.1.3 --- common/widgets/wx_grid.cpp| 5 + include/gal/cairo/cairo_gal.h | 10 -- 2 files

Re: [Kicad-developers] Commit c8a6878 breaks compilation on msys2

2019-09-04 Thread Ian McInerney
wxASSERT shouldn't be used inside constexpr functions because some of their code paths for it implement trap functions that use inline assembly. This is not allowed by the C++14 standard, and is supposed to be part of C++2a. Other code paths just call into system functions, so this will be highly p

Re: [Kicad-developers] knowing last commit included in a nightly build?

2019-09-05 Thread Ian McInerney
I believe that OSX adds several patches to the build process still, so the last few commits are OSX specific and the one being picked for the version string is probably one of this. Adam should be able to confirm this. -Ian On Thu, Sep 5, 2019 at 10:12 AM Jonatan Liljedahl wrote: > Hmm, weird.

Re: [Kicad-developers] [Patch] Fix wxWidget compatibility issues

2019-09-05 Thread Ian McInerney
nt to build 5.1 against wxWidgets 3.1.3 or later. > > Cheers, > > Wayne > > On 8/31/19 10:49 AM, Ian McInerney wrote: > > wxWidgets have renamed a variable in the wxGrid implementation for their > > 3.1.3 release, so out implementation needs to have a compatibility chec

[Kicad-developers] [Patch] Remove unneeded wxWidgets tests

2019-09-05 Thread Ian McInerney
This patch removes two checks (and the unused code), since they tested for version 3.0.0 and the minimum version required by CMake is wxWidgets 3.0.0. From aa2c613dd13978c6befbcc1a48798ec1234eedd8 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Thu, 5 Sep 2019 20:48:31 +0200 Subject: [PATCH

Re: [Kicad-developers] [Patch] Another hotkey processing fix

2019-09-05 Thread Ian McInerney
of this patch? > > Cheers, > > Wayne > > On 8/8/19 7:16 PM, Ian McInerney wrote: > > In the current framework, if more than one global actions share the same > > hotkey (even if they are not all active in the current tool manager), > > the dispatcher will

[Kicad-developers] [Patch] Handle Cvpcb save actions immediately

2019-09-08 Thread Ian McInerney
generated by the OK button is non-vetoable though, so showing this dialog can lead to an assertion. -Ian From 648c8661024bdd4015bb5b686ac6f9ab14c7f326 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Mon, 9 Sep 2019 07:02:11 +0200 Subject: [PATCH] cvpcb: Run save action immediately on close

Re: [Kicad-developers] Ctrl-click to highlight in pcbnew missing?

2019-09-10 Thread Ian McInerney
There are two current reports that I can find requesting that the mouse combinations/modifier keys be user-configurable: https://bugs.launchpad.net/kicad/+bug/1842967 - Allow the snapping modifier key to be set https://bugs.launchpad.net/kicad/+bug/1842337 - Allow a mouse/button pair to pan around

Re: [Kicad-developers] CERN Open Days

2019-09-13 Thread Ian McInerney
I'm attending the open days on both Saturday and Sunday, so feel free to drop me an email off list if you want to meet up. -Ian On Tue, Sep 10, 2019 at 11:33 AM Tomasz Wlostowski < tomasz.wlostow...@cern.ch> wrote: > On 10/09/2019 08:30, Diego Herranz wrote: > > Hi, all > > > > The CERN Open Day

Re: [Kicad-developers] [RFC] Symbols and Pin mapping in v6 - Proposal

2019-09-17 Thread Ian McInerney
Unfortunately, no I don't agree that the grouping should be by peripheral. The purpose of a schematic is to capture the electrical connections of a circuit, and allow the designer to reason about it. On most chips, the electrical specifications of the same peripheral type can differ between instanc

Re: [Kicad-developers] [Patch] Remove unneeded wxWidgets tests

2019-09-18 Thread Ian McInerney
Ping. On Thu, Sep 5, 2019 at 8:54 PM Ian McInerney wrote: > This patch removes two checks (and the unused code), since they tested for > version 3.0.0 and the minimum version required by CMake is wxWidgets 3.0.0. > ___ Mailing li

Re: [Kicad-developers] [Patch] Handle Cvpcb save actions immediately

2019-09-18 Thread Ian McInerney
Ping. On Mon, Sep 9, 2019 at 7:05 AM Ian McInerney wrote: > This patch updates Cvpcb to run the save actions immediately when the > buttons are pressed. If they are not run immediately, then the user may see > the handle unsaved changes dialog (which if they clicked on OK is not what &

Re: [Kicad-developers] [Patch] Another hotkey processing fix

2019-09-18 Thread Ian McInerney
testing of whether a hotkey is handled takes place and we simply show a > warning that the 'P' hotkey is bound to two separate actions. I'm not > sure what the course of action here could be other than to separate > testing of the hotkey overlap between applications. > &g

[Kicad-developers] [Patch] Clean up file extension handling in Pcbnew graphics plugins

2019-09-26 Thread Ian McInerney
up the code there). The 5.1 branch also shows this issue, so it would be good to backport this fix to 5.1 as well. -Ian From d13c0996c0179c7aac22bd34e093edf99ca51973 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Thu, 26 Sep 2019 22:09:09 +0200 Subject: [PATCH] pcbnew: Clean up extension

Re: [Kicad-developers] Minimum Boost version

2019-09-26 Thread Ian McInerney
Ping. Is there any opposition to bumping the minimum Boost version to 1.59? -Ian On Sat, Aug 31, 2019 at 10:05 PM Blair Bonnett wrote: > > On Thu, 29 Aug 2019 at 14:10, Wayne Stambaugh > wrote: > > > > What's wrong with setting the minimum boost version to 1.59? > > Absolutely nothing; the sug

[Kicad-developers] Website known system issues page

2019-09-26 Thread Ian McInerney
I was just updating the website's known system issues page with some information about high DPI displays (since we seem to be getting a lot of reports now about this), and some other information on it seems to be outdated. Does anyone know wh

Re: [Kicad-developers] [PATCH] Implement auto annotation on component/symbol placement.

2019-09-28 Thread Ian McInerney
Thanks for putting together this changeset. I have a few comments from just looking through it (I haven't actually compiled and tested it yet). 1) Why did you change the variable type for the EE_SELECTION in patches 5 and 6? The requestSelection function returns a reference to the object, and noti

[Kicad-developers] Context menu & immediate actions

2019-10-02 Thread Ian McInerney
I was noticing some odd behavior with the zone tool in the master branch just now, specifically when you run an action of its through the context menu (such as add zone cutout). When you select the menu item, it will begin drawing immediately, which on my Linux box causes some weird behavior (it wi

[Kicad-developers] [Patch] Improve tool priming for immediate context menu actions

2019-10-03 Thread Ian McInerney
cbnew tools to use this new framework to fix the issue of starting the drawing at the wrong position. -Ian From efe7cfc85ec2db66be44fcd5cf0edab102ce0133 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Thu, 3 Oct 2019 17:55:05 +0200 Subject: [PATCH 1/2] Cleanup position handling for TOOL_EVENTs *

[Kicad-developers] [Patch] Make pl_editor runnable from build directory

2019-10-03 Thread Ian McInerney
From 54886ad20bc915ebe89bdf4dd86de3021b45aef4 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Thu, 3 Oct 2019 19:27:23 +0200 Subject: [PATCH] Update pleditor path for run from build directory --- common/kiway.cpp | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/common/kiway.

Re: [Kicad-developers] Context menu & immediate actions

2019-10-03 Thread Ian McInerney
gt; has changed, I would consider it a bug. Context menu and main frame > menu command events are not the same thing and should not be treated as > such. > > Wayne > > On 10/2/19 5:19 PM, Ian McInerney wrote: > > I was noticing some odd behavior with the zone tool in the mast

Re: [Kicad-developers] [Patch] Make pl_editor runnable from build directory

2019-10-03 Thread Ian McInerney
Thanks for merging it. Yea, it would probably be good to cherry-pick it. -Ian On Thu, Oct 3, 2019 at 9:05 PM Wayne Stambaugh wrote: > Ian, > > I merged your patch into master. Should this be cherry-picked into 5.1? > > Thanks, > > Wayne > > On 10/3/2019 1:29 PM,

Re: [Kicad-developers] [Patch] Make pl_editor runnable from build directory

2019-10-03 Thread Ian McInerney
7;t dived into why. -Ian On Thu, Oct 3, 2019 at 7:56 PM Nick Østergaard wrote: > It is quite some time since I tried to run anything of kicad in the > build dir. Does it even work for other pats of kicad? > > I switched my workflow to make install and run it from there. > >

[Kicad-developers] Unicode Hotkeys

2019-10-04 Thread Ian McInerney
I was doing some digging in the hotkey code to try to see what may be causing this issue: https://bugs.launchpad.net/kicad/+bug/1840528, and I think it may be due to not using the actual unicode character as the hotkey we process. According to wxWidgets, GetKeyCode()

Re: [Kicad-developers] Commit 0a829c328e90f550994a7660b310630a5aa02361 not compiling ("undefined reference to `PgmOrNull()'")

2019-10-05 Thread Ian McInerney
I am somewhat confused by the reason for needing to introduce the new function in that commit. Does this crash happen when running the Python from inside Pcbnew or when trying to run Pcbnew python bindings from the system Python prompt? This seems to be treating a symptom in the Python code, speci

[Kicad-developers] [Patch] Update build documentation with debugging options

2019-10-05 Thread Ian McInerney
2001 From: Ian McInerney Date: Sat, 5 Oct 2019 19:08:21 +0200 Subject: [PATCH] Update building documentation with new debugging options --- Documentation/development/compiling.md | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Documentation/development/compiling.md b

[Kicad-developers] [Patch] Fix some issues in cvpcb

2019-10-06 Thread Ian McInerney
after warning the user it was invalid This patch cleans up these issues. -Ian From 6caf68f4d222e6fad539a1d0b4275c8c33b11fa4 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Sun, 6 Oct 2019 12:19:41 +0200 Subject: [PATCH] cvpcb: Fix some issues * ESC no longer closed the window since it didn'

Re: [Kicad-developers] KICAD_USE_FONT_REDUCED_SET question

2019-10-07 Thread Ian McInerney
If this needs to stay configurable, it would probably be better as an option in the config panel rather than at build-time. Otherwise, we would have to maintain a version of the binaries with/without the added characters and it might start to confuse users. -Ian On Mon, Oct 7, 2019 at 9:01 PM jp

Re: [Kicad-developers] GitLab migration

2019-10-09 Thread Ian McInerney
On Wed, Oct 9, 2019 at 10:28 PM Nick Østergaard wrote: > On Wed, 9 Oct 2019 at 18:36, Wayne Stambaugh wrote: > > > > The lead development team has been discussing migrating the KiCad > > project to GitLab[1]. Given the issues with Launchpad, I think this is > > a good move. I've applied for an

Re: [Kicad-developers] GitLab migration

2019-10-10 Thread Ian McInerney
On a similar note, the issue workflow will need to be modified if the GitLab tracker is used. Unfortunately, GitLab doesn't seem to have the same functionality as the Launchpad tracker with respect to issue status and severity. This might be a good time to finalize the earlier work that Nick had st

Re: [Kicad-developers] [PATCH] Implement auto annotation on component/symbol placement.

2019-10-13 Thread Ian McInerney
Zifcani, Sorry for the delay in the response. Yes, you can just attach the new patches to an email and send it to the list. You can either squash them all into 1 patch, or create 2 patches (the first just the wxFormbuilder dialog class, so all the _base.fbp/cpp/h files, and the second the remainin

Re: [Kicad-developers] GitLab migration

2019-10-14 Thread Ian McInerney
Orson, Great work so far. I was noticing as you were testing migrating the issues that our @names in the text seem to not transfer well. In one of the issues just now (the pcbnew segfault issue #228 [2]) it pulls in a different user for Seth whenever @seth is mentioned, and also for my name. Do y

Re: [Kicad-developers] GitLab migration

2019-10-15 Thread Ian McInerney
Ian On Tue, Oct 15, 2019 at 12:28 AM Seth Hillbrand wrote: > On 2019-10-14 16:09, Ian McInerney wrote: > > > Orson, > > > > Great work so far. > > > > I was noticing as you were testing migrating the issues that our @names > > in the text seem to not tr

[Kicad-developers] [RFC] GitLab Issue Tracker Guidelines

2019-10-15 Thread Ian McInerney
After some research and experimentation with the GitLab issue tracker, I have made a revised version of Nick's initial guidelines. It is available at [1] for comment. The main difference is that in GitLab it looks like labels can only be applied to issues by someone with Reporter permissions [2], a

Re: [Kicad-developers] 5.1.5 release status

2019-10-20 Thread Ian McInerney
There is also this H/V/45 issue [1]. It is more of a gray area though, since it will probably involve touching the file format due to what is happening (the H/V/45 is being saved as a global board setting rather than a per-zone setting as the GUI would seem to make it). -Ian [1] https://bugs.laun

Re: [Kicad-developers] 5.1.5 release status

2019-10-21 Thread Ian McInerney
. -Ian On Sun, Oct 20, 2019 at 5:02 PM Seth Hillbrand wrote: > On 2019-10-20 08:40, Ian McInerney wrote: > > > There is also this H/V/45 issue [1]. It is more of a gray area though, > > since it will probably involve touching the file format due to what is > > happening (the H/

Re: [Kicad-developers] 5.1.5 release status

2019-10-21 Thread Ian McInerney
] https://bugs.launchpad.net/kicad/+bug/1842195 [3] https://bugs.launchpad.net/kicad/+bug/1847722 [4] https://bugs.launchpad.net/kicad/+bug/1846029 On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand wrote: > On 2019-10-21 10:52, Ian McInerney wrote: > > > Seth, > > > > Just to

Re: [Kicad-developers] Minimum Boost version

2019-10-21 Thread Ian McInerney
baugh wrote: >> > On 9/27/19 12:20 AM, Carsten Schoenert wrote: >> >> Hi, >> >> >> >> Am 26.09.19 um 22:26 schrieb Ian McInerney: >> >>> Ping. Is there any opposition to bumping the minimum Boost version to >> >>> 1.59? >&g

Re: [Kicad-developers] 5.1.5 release status

2019-10-21 Thread Ian McInerney
We also seem to have assertions enabled in the Debian build (there have been two reports from users [1], [2]). Is this something we control as well, or is the the distribution packaging forcing them on? -Ian [1] https://bugs.launchpad.net/kicad/+bug/1847554 [2] https://bugs.launchpad.net/kicad/+b

Re: [Kicad-developers] Minimum Boost version

2019-10-22 Thread Ian McInerney
ich case that date is wrong. > > > > Thanks, > > Diego > > > > On Mon, 21 Oct 2019 at 20:16, Ian McInerney > <mailto:ian.s.mciner...@ieee.org>> wrote: > > > > The listing I used when looking at whether our supported OS's had > >

Re: [Kicad-developers] Minimum Boost version

2019-10-22 Thread Ian McInerney
d. On Wed, Oct 23, 2019 at 1:05 AM Seth Hillbrand wrote: > On 2019-10-22 16:06, Ian McInerney wrote: > > I dug into the website history and apparently the original intent should > have been to support 16.04 LTS until its standard support ends in 2021 ( > https://gith

Re: [Kicad-developers] 5.1.5 release status

2019-10-23 Thread Ian McInerney
g list. > > Cheers, > > Wayne > > [1]: https://bugs.launchpad.net/kicad/+bug/1849289 > > On 10/21/2019 3:11 PM, Ian McInerney wrote: > > There were two bugs still on the 5.1.5 milestone [1], [2] that related > > to the editing of H/V/45 constrained polygons. I have bum

Re: [Kicad-developers] 5.1.5 release status

2019-10-23 Thread Ian McInerney
It looks like the build flags for KiCad are not getting NDEBUG defined to remove the assertions. We should add -DNDEBUG to the flags passed into CMake alongside the Debian flags. -Ian On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert wrote: > Hello Seth, > > Am 22.10.19 um 18:10 schrieb Seth Hi

Re: [Kicad-developers] 5.1.5 release status

2019-10-23 Thread Ian McInerney
n one of the none windows build code paths? Doing this will wipe out > any compiler flags set by CMake. > > On 10/23/2019 11:16 AM, Ian McInerney wrote: > > It looks like the build flags for KiCad are not getting NDEBUG defined > > to remove the assertions. We should add -DNDEBUG

Re: [Kicad-developers] Python files still depending on Python2 only due used shebang

2019-10-26 Thread Ian McInerney
We should also be thinking of when we want to officially drop the Python 2 support for KiCad. Since Python 2.7 will be end of life in just a few months, it might be worth starting the transition over to Python 3 (it looks like Windows and Mac builds ship with 2.7 currently). -Ian On Sat, Oct 26,

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Ian McInerney
I thought that was part of the connectivity stuff that Jon was working on (it certainly wasn't me, and I don't know if there is another Ian contributing code right now). I remember seeing some email threads on real-time updates to the information in Eeschema. The wishlist item that Wayne mentioned

Re: [Kicad-developers] SIM_PLOT_TYPE

2019-11-06 Thread Ian McInerney
I would guess that is a mistake. It seems that the intention is to eventually have both linear and log scaling, so they would need to be different. Right now though it looks like log scaling isn't handled differently (a search for SPT_LOG_FREQUENCY returns a TODO comment and an if check that is als

Re: [Kicad-developers] New lead developer announcement

2019-11-08 Thread Ian McInerney
at 12:27 PM Tomasz Wlostowski wrote: > On 07/11/2019 21:14, Wayne Stambaugh wrote: > > I am happy to announce that the KiCad project now has a new member of > > the lead development team. Ian McInerney has accepted an invitation to > > become a member of the lead development

Re: [Kicad-developers] GitLab migration

2019-11-10 Thread Ian McInerney
Simon, Continue to use Launchpad for the time being. I don't believe we have officially created the KiCad repository yet, so all that is being done currently is testing leading up to the migration. -Ian On Sun, Nov 10, 2019 at 7:10 PM Simon Richter wrote: > Hi, > > On Sun, Nov 10, 2019 at 06:4

Re: [Kicad-developers] [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options

2019-11-10 Thread Ian McInerney
JP, Are you running this on your 3.0 or 3.1 build of wxwidgets? That looks like there is an issue with their autosize calculation not factoring in the width of the sorting bitmap. -Ian On Thu, 7 Nov 2019, 14:37 jp charras, wrote: > Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit : > > Hello, >

Re: [Kicad-developers] [PATCH] Update python defaults

2019-11-10 Thread Ian McInerney
Simon, While Python 2 may be deprecated, I don't think we can change the defaults for master yet. The main issue is the packaging of Windows and Mac still requires Python 2 (based on the discussion in [1]) because the Python 3 packages are not validated/existing yet. Until we have Windows and OSX

Re: [Kicad-developers] [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options

2019-11-11 Thread Ian McInerney
Thanks for this. Note though that when passing the functions into the Connect method in wxWidgets, you should specify the fully qualified name (including the class) of the function. When this is not specified, a build error happens on my wxWidgets 3.0.4 Linux build. I have pushed a fix for this to

Re: [Kicad-developers] [PATCH] Eeschema: simulator: more trace colors, smarter color allocation

2019-11-11 Thread Ian McInerney
Jonatan, Thank you for putting this together. Overall I think it looks good, but the only issue I saw was that the SIM_PLOT_FRAME::generateColor() function seems to be becoming a graveyard for old colors with 4 old attempts at creating color profiles now commented out. I have merged it into master

Re: [Kicad-developers] Project save as

2019-11-11 Thread Ian McInerney
I agree, we should only be transferring and renaming the non-generated files rather than trying to account for every possible file under the sun. If the user wants the generated files, they can regenerate them from the new project. -Ian On Mon, 11 Nov 2019, 20:30 Jon Evans, wrote: > In my opini

Re: [Kicad-developers] GitLab migration

2019-11-12 Thread Ian McInerney
I think it makes sense to transfer the reports that are fix committed but not fix released. That way we can have the entire v6 history attached to the new milestone and more easily reference those reports in the future. Any that are fix released we can leave on Launchpad. -Ian On Tue, Nov 12, 201

Re: [Kicad-developers] [PATCH] Eeschema: simulator: more trace colors, smarter color allocation

2019-11-12 Thread Ian McInerney
ug fix, but keep the old > 8-color palette? > > /Jonatan > > 11 nov. 2019 kl. 18:35 skrev Ian McInerney : > >  > Jonatan, > > Thank you for putting this together. Overall I think it looks good, but > the only issue I saw was that the SIM_PLOT_FRAME::generateColor(

Re: [Kicad-developers] New border/title blocks?

2019-11-13 Thread Ian McInerney
I believe the US sizes are provided by the ASME Y14.1-2005 standard. Or at least that seems to be the generic standard for these that I can find (I didn't see anything for ANSI or IEEE). -Ian On Wed, Nov 13, 2019 at 6:37 PM Evan Shultz wrote: > Thanks Seth! > > I didn't find the default templat

Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

2019-11-15 Thread Ian McInerney
I'll give it a test on GTK once my build here finishes, but I don't think I have seen any issues with file watcher on GTK in the past. -Ian On Fri, Nov 15, 2019 at 10:03 PM Jeff Young wrote: > Hi Mikolaj, > > The Mac compiler doesn’t like Rename() returning values when the return > type is void

Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

2019-11-15 Thread Ian McInerney
I'm on Windows (the details are in the linked related bug report). > > Sorry for the return value problem -- I failed to notice the warnings in > console. > > Best regards, > Mikołaj Wielgus > > > On Fri, Nov 15, 2019 at 11:07 PM Ian McInerney > wrote: > >>

Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

2019-11-15 Thread Ian McInerney
s. > > Best regards, > Mikołaj Wielgus > > > On Sat, Nov 16, 2019 at 1:02 AM Jeff Young wrote: > >> I pushed a smarter version of my original fix. @Mikolaj & @Ian if you >> could test it on Windows and GTK that would be great. >> >> Cheers, >> Jeff.

Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

2019-11-16 Thread Ian McInerney
m selected). > > Cheers, > Jeff. > > > On 16 Nov 2019, at 01:57, Ian McInerney wrote: > > Ok, so I dug into this some more and first of all, the changes that Jeff > pushed still didn't work on GTK. > > The root cause of this doesn't appear to be our file sys

Re: [Kicad-developers] [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

2019-11-16 Thread Ian McInerney
rt should > collapse create/delete events into a rename event, which is not the case on > my build. > > Best regards, > Mikołaj Wielgus > > > On Sat, Nov 16, 2019 at 5:21 PM Ian McInerney > wrote: > >> Thanks for testing. I had noticed the selection issue on GTK

Re: [Kicad-developers] OCE vs OCC

2019-11-18 Thread Ian McInerney
It has been cherry picked into the 5.1 branch, so it will be included in 5.1.6. -Ian On Mon, Nov 18, 2019 at 9:07 PM Steven A. Falco wrote: > On 11/16/19 1:14 PM, Seth Hillbrand wrote: > > On 2019-11-16 08:42, Steven A. Falco wrote: > >> It looks like Fedora may be switching from OCE to OCC, so

Re: [Kicad-developers] Building current master fails

2019-11-20 Thread Ian McInerney
Jonatan, The pcb_lexer.h in include/ shouldn't exist anymore. There was a switchover a few months ago in how that file was generated, and that change moved it into the build directory. As a consequence of that switchover, you need to clean out the stray files that existed from old build. Try runn

Re: [Kicad-developers] eeschema selection appearance

2019-11-20 Thread Ian McInerney
I'm on the fence about the text highlighting, on the one hand not doing it does make it so the text is still easily legible when selected, but on the other it can be nice to show that it is part of the selected symbol. I think this would definitely be a case where making it a configurable option wo

Re: [Kicad-developers] Building current master fails

2019-11-20 Thread Ian McInerney
en include/ and > build/common/. > > This is a fresh clone, I'm not sure how these files ended up in > include/. I see that the files are not in the git file tree of either > 5.1 or master branch. Maybe it happened when I built using > kicad-mac-builder pointing it to my kicad

Re: [Kicad-developers] Building current master fails

2019-11-20 Thread Ian McInerney
, 2019 at 3:16 PM Jeff Young wrote: > I switch between 5.1 and master and back in the same tree. You have to > run the clean each time you go from 5.1 to master. > > On 20 Nov 2019, at 14:34, Ian McInerney wrote: > > Thats correct, all those lexer files should now be in t

[Kicad-developers] Fwd: eeschema selection appearance

2019-11-20 Thread Ian McInerney
rm an action on it, and then cancel the action (e.g. because a dialog appeared warning you of some condition), it is frustrating that the selection is cancelled. Regards Ruth On 20/11/2019 14:28, Ian McInerney wrote: I'm on the fence about the text highlighting, on the one hand not doing it

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Ian McInerney
This is probably introducing major feature creep, but it would be nice to develop a dialog that allows setting the per-trace characteristics (such as color, line type, line width, etc) that this could go in. Where we put the accessors to it, I am not sure (it would be great if we could link it with

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Ian McInerney
I think it would be good to define a new S-expression config file that can be used to store the plot configurations of the simulator. This file should just contain the plot information, such as lines displayed, their style/color, axis configurations, colors, etc. (and maybe analysis parameters, I h

[Kicad-developers] Using OPT types

2019-11-24 Thread Ian McInerney
What is the current consensus on using OPT types in the code? I know there are some instances where we are already using them from the Boost library (since our C++ version isn't high enough to include them), but is that considered a good type to use more of? I am curious, because I am thinking of

Re: [Kicad-developers] [PATCH] Fixes for Visual Studio / vcpkg build

2019-11-24 Thread Ian McInerney
I think it is still missing the OCC/OCE package as well: https://github.com/microsoft/vcpkg/issues/4968 -Ian On Sun, 24 Nov 2019, 22:17 Wayne Stambaugh, wrote: > Hey Jon, > > I was playing around with vcpkg a couple of weeks ago and it's works > surprisingly well. There is finally a sane way t

Re: [Kicad-developers] GitLab issues

2019-11-26 Thread Ian McInerney
We have not officially migrated to GitLab yet, until we announce otherwise the current platforms (Launchpad for bug reports/code, GitHub for libraries/docs/translations) should be used. An announcement about the transition will be made before it happens. -Ian On Tue, Nov 26, 2019 at 8:14 AM Franc

Re: [Kicad-developers] Plugin/3rd party content manager

2019-11-26 Thread Ian McInerney
We should not limit the end points available to users to be only the KiCad systems we decide, and also should not constrain plugins to be open source. Doing this would constrain independent companies from developing plugins to interface KiCad with their systems if they so choose (for instance, if a

[Kicad-developers] New Official Bug Tracker Tags

2019-11-26 Thread Ian McInerney
I would like to introduce two new official tags on the bug tracker to track issues relating to the symbol and footprint editors. Currently we are tracking these under the eeschema and pcbnew tags respectively, but those are growing quite large (pcbnew has over 500). I think tracking these two tools

Re: [Kicad-developers] New Official Bug Tracker Tags

2019-11-26 Thread Ian McInerney
editor). > > Mixing the two would be particularly obscure. > > Cheers, > Jeff. > > > On 26 Nov 2019, at 19:40, Wayne Stambaugh wrote: > > > > > > > > On 11/26/19 2:20 PM, Ian McInerney wrote: > >> I would like to introduce two new official tags on

Re: [Kicad-developers] Contributing Python to KiCad

2019-11-27 Thread Ian McInerney
Mitja, Thanks for expressing interest, and I would just like to say that you do not have to be a C++ developer to contribute to KiCad. There is a healthy Python presence in both the core codebase (the footprint generators and BoM scripts) as well as the library management systems (symbol/footprint

Re: [Kicad-developers] New Official Bug Tracker Tags

2019-11-27 Thread Ian McInerney
is often abbreviated as fp, but symbol is > rarely abbreviated. > > On 26 Nov 2019, at 20:45, Ian McInerney wrote: > > I do like fp-editor and sym-editor better. Note that for consistency with > the other multiword tags for GitLab, I will use a hyphen. > > -Ian > > On

Re: [Kicad-developers] windows 32-bit builds

2019-11-27 Thread Ian McInerney
Technically Windows 10 has a 32-bit edition, and we specify we support all of Windows 10. How long Microsoft keeps up a 32-bit release is anyone's guess though. So we can't really cut out 32-bit releases yet (and I think even JP still has a 32-bit machine he uses). -Ian On Wed, Nov 27, 2019 at 9:

Re: [Kicad-developers] New border/title blocks?

2019-11-27 Thread Ian McInerney
They appear to be packaged in the update to Fedora, but I don't have a Windows install handy to test on to verify what I see there: /usr/share/kicad/demos/interf_u/pagelayout_logo.kicad_wks /usr/share/kicad/template/A2_ISO5457-1999_ISO7200-2004-compact_ASMEY1435-2014_EN.kicad_wks /usr/share/kicad/

[Kicad-developers] Linux Packagers: Resource File Updates

2019-11-28 Thread Ian McInerney
Linux Packagers, I would like to change the way we generate the kicad.appdata.xml file to have it be generated by CMake and include the version string inside of it (that way the version will appear in the app stores and other places that reference this). I don't think this will cause any issues, b

Re: [Kicad-developers] Linux Packagers: Resource File Updates

2019-11-29 Thread Ian McInerney
nd I can't seem to find any information on the suggested size (other than that Fedora recommends they are 16:9). Thanks, -Ian On Fri, Nov 29, 2019 at 5:39 AM Carsten Schoenert wrote: > Hello Ian, > > On 28.11.19 17:53, Ian McInerney wrote: > > I would like to change the wa

Re: [Kicad-developers] Which GitLab issues tracker are we going to use?

2019-12-01 Thread Ian McInerney
Issues must live in a project, so the issues for the KiCad code must go in the Kicad/code/kicad list. The other lists (KiCad and KiCad/code) just show all issues for all the projects underneath that folder. -Ian On Sun, Dec 1, 2019 at 8:51 PM Jeff Young wrote: > Kicad, Kicad/code or Kicad/code/

Re: [Kicad-developers] [PATCH] Three new source types added to DIALOG_SPICE_MODEL

2019-12-02 Thread Ian McInerney
Sylwester, Please bear with us for a little, since the move to GitLab has been at the foreground for the last few weeks the lead developers haven't had time to sit down and review patches as often. Once we have completed the migration to GitLab for the code repository, you can submit this as a mer

Re: [Kicad-developers] Strokefont change from std::deque to std::vector

2019-12-02 Thread Ian McInerney
Jeff, I believe this change is related to the out of memory error in Eeschema that JP reported after the CJK fonts were added (see list messages: https://www.mail-archive.com/kicad-developers@lists.launchpad.net/msg36655.html ) -Ian On Tue, 3 Dec 2019, 00:29 Jeff Young, wrote: > Hi Seth, > > W

Re: [Kicad-developers] New border/title blocks?

2019-12-02 Thread Ian McInerney
gt; >> On Sun, 1 Dec 2019 at 23:42, Wayne Stambaugh >> wrote: >> >> > >> >> > I downloaded and installed 5.1.5 on my windows box and it looked like >> >> > these worksheets were in the template folder. I didn't check the >> entire >

Re: [Kicad-developers] New Official Bug Tracker Tags

2019-12-03 Thread Ian McInerney
ou wanted the hyphen, but I didn't really follow the > discussion to much in this thread. What are the other multiword tags in > gitlab? > > On Wed, 27 Nov 2019 at 12:13, Ian McInerney wrote: > >> I was trying to avoid creating long tags, and since our current tags seem >>

[Kicad-developers] Website and OSX 10.15

2019-12-03 Thread Ian McInerney
Adam/all, Is the 10.14 installer also to be used for 10.15? Right now there is no mention on the website about the 10.15 support (and actually says only 10.12-10.14 are supported). -Ian ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] GitLab bug workflow

2019-12-04 Thread Ian McInerney
The plan that has been proposed here: https://gitlab.com/kicad/code/kicad/wikis/Developers/Guidelines/Issue-Tracker is that bugs in fix-committed, fix-released, fixed and duplicate will be in the closed status. I had added the fix-committed/fix-released to our GitLab tags so we can still keep track

  1   2   3   4   >