Re: [Kicad-developers] Common settings changing in 3D viewer

2019-04-08 Thread John Beard
Hi Jeff, Thanks, makes sense. I have kept this behaviour, but I have pushed a little bit of logic inside EDA_3D_VIEWER to avoid duplicating logic between classes. Now, the 3D viewer does handle its own updates for the CommonSettingsChanged, but they are sent "manually" by the PCB frame. This allo

Re: [Kicad-developers] Common settings changing in 3D viewer

2019-04-08 Thread Jeff Young
While not directly related, see https://bugs.launchpad.net/kicad/+bug/1562672 for some more background. > On 8 Apr 2019, at 09:56, John Beard wrote: > > Hi, > > I'm trying to get the 3d viewer hooked up to the common settings, so I > can change the DPI scaling. > > The 3d viewer frame is a K

[Kicad-developers] Common settings changing in 3D viewer

2019-04-08 Thread John Beard
Hi, I'm trying to get the 3d viewer hooked up to the common settings, so I can change the DPI scaling. The 3d viewer frame is a KIWAY_PLAYER, but doesn't seem to participate in the Kiway ecosystem, as it's never created by a call to Player(). This means it's never included in common settings upda