Hi Jeff, Thanks, makes sense. I have kept this behaviour, but I have pushed a little bit of logic inside EDA_3D_VIEWER to avoid duplicating logic between classes.
Now, the 3D viewer does handle its own updates for the CommonSettingsChanged, but they are sent "manually" by the PCB frame. This allows the DPI and icon scales to be propagated "live" like they are in the KIWAY'd frames. Cheers, John On Mon, Apr 8, 2019 at 10:57 AM Jeff Young <j...@rokeby.ie> wrote: > > While not directly related, see https://bugs.launchpad.net/kicad/+bug/1562672 > for some more background. > > > > On 8 Apr 2019, at 09:56, John Beard <john.j.be...@gmail.com> wrote: > > > > Hi, > > > > I'm trying to get the 3d viewer hooked up to the common settings, so I > > can change the DPI scaling. > > > > The 3d viewer frame is a KIWAY_PLAYER, but doesn't seem to participate > > in the Kiway ecosystem, as it's never created by a call to Player(). > > This means it's never included in common settings updates. > > > > Instead, the PCB_BASE_FRAME::CommonSettingsChanged() does the update > > via the EDA_3D_VIEWER public interface. > > > > Is there a reason the 3D viewer is not included in the Kiway? > > > > Cheers, > > > > John > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
