Hi guys,
thanks for the explanation.
cheers
Fabrizio
On Fri, Jul 21, 2017 at 11:06 PM, Wayne Stambaugh
wrote:
> This is correct. I just remember if the string in a group box
> (wxStaticBoxSizer) than it doesn't get a colon. If the string is static
> text (wxStaticText) that describes a text c
This is correct. I just remember if the string in a group box
(wxStaticBoxSizer) than it doesn't get a colon. If the string is static
text (wxStaticText) that describes a text control, then it should end in
a colon.
On 7/21/2017 2:31 PM, Chris Pavlina wrote:
> Generally single entry controls wil
Generally single entry controls will contain a colon in the label but
entire sections will not - thus "Output directory" and "Default line
thickness (mm)" should have colons, but "Messages" and "Page Size"
should not. This is because the single entry controls read as a single
line of text, where it
Hi Wayne,
this is an exmaple of the current plot schematic window.
[image: Inline image 1]
I think it is expected that "Output directory:" and "Default line thickness
(mm):" and "Messages:" have a colon.
Am I correct?
cheers
Fabrizio
On Fri, Jul 21, 2017 at 4:23 PM, Wayne Stambaugh
wrote:
Fabrizio,
I pushed your patch to the master branch. Thank you for your
contribution to KiCad.
This is not aimed at your patch but one thing I notice is that there is
and inconsistency in some of our wxStaticBoxSizer() strings. There are
a few cases where the string ends with a colon (:) but it'
Fabrizio,
You are still using header instead of sentence capitalization of text
box labels. For example, in pcbnew/dialogs/dialog_plot_base.cpp you
changed:
"Plot format:"
to
"Plot Format:"
The original capitalization is correct. I see a lot of this in this patch.
Please correct the text bo
Le 19/07/2017 à 12:19, Fabrizio Tappero a écrit :
> Hi Wayne,
> apologies for that. I sometimes think that a unique patch is more friendly
> than several ones.
>
> Will fix and resubmit.
>
> cheers
> Fabrizio
>
Yes you are right, but files created by wxFormBuilder can differ seriously,
depend
Hi Wayne,
apologies for that. I sometimes think that a unique patch is more friendly
than several ones.
Will fix and resubmit.
cheers
Fabrizio
On Tue, Jul 18, 2017 at 3:35 PM, Wayne Stambaugh
wrote:
> Fabrizio,
>
> This patch has far more changes than the plot dialogs mentioned in your
> comm
Fabrizio,
This patch has far more changes than the plot dialogs mentioned in your
commit message. In the future, please either make your commit message
describe all of the changes related to the patch. I would prefer that
you only make one wxFormbuilder dialog change per patch. wxFormbuilder
ch
gentle reminder.
cheers
Fabrizio
On Mon, Jul 3, 2017 at 10:45 AM, Fabrizio Tappero <
fabrizio.tapp...@gmail.com> wrote:
> Hi JP,
> thanks for it. I updated my wxformbuilder to the latest (3.6v)
> version. And I fixed the (mm) issue you mentioned.
>
> In attachment the patch.
>
> thank you
> Fab
Hi JP,
thanks for it. I updated my wxformbuilder to the latest (3.6v)
version. And I fixed the (mm) issue you mentioned.
In attachment the patch.
thank you
Fabrizio
On Sat, Jul 1, 2017 at 8:40 PM, jp charras wrote:
> Le 30/06/2017 à 15:34, Fabrizio Tappero a écrit :
>> Hello,
>> in attachment
Le 30/06/2017 à 15:34, Fabrizio Tappero a écrit :
> Hello,
> in attachment the patch reviewed after Wayne comments.
>
> Best regards
> Fabrizio
>
Hi Fabrizio,
I had a look at your last patch, and found a few issues:
for instance the change:
- m_defaultLineWidthTitle = new wxStaticText(
ch for a detailed
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > > On Fri, Jun 9, 2017 at 12:31 AM, liyoubdu <mailto:liyou...@qq.com>
> > > <mailto:liyou...@qq.com <
you changed here
> > ---Original---
> > *From:* "Nick Østergaard" <mailto:oe.n...@gmail.com> <mailto:oe.n...@gmail.com
> <mailto:oe.n...@gmail.com>>>
> > *Date:
gt; Save Output
> > Capital letters, shorten sentences, etc
> >
> > Please refer to the patch for a detailed
> >
> > cheers
> > Fabrizio
> >
> >
> > On Fri, Jun 9, 2017 at 12:31 AM, liyoubdu > <mailto:liyou...@qq.com>> wrote:
> >
&
t; *Date:* 2017/6/9 00:39:01
> *To:* "Fabrizio Tappero" <mailto:fabrizio.tapp...@gmail.com>>;
> *Cc:* "KiCad Developers" <mailto:kicad-developers@lists.launchpad.net>>;
> *Subject:* Re: [Kicad-developers] [PATCH] correct tex
16 matches
Mail list logo
