Le 30/06/2017 à 15:34, Fabrizio Tappero a écrit :
> Hello,
> in attachment the patch reviewed after Wayne comments.
>
> Best regards
> Fabrizio
>
Hi Fabrizio,
I had a look at your last patch, and found a few issues:
for instance the change:
- m_defaultLineWidthTitle = new wxStaticText(
sbSizerPlotFormat->GetStaticBox(), wxID_ANY,
_("Default line thickness"), wxDefaultPosition, wxDefaultSize, 0 );
+ m_defaultLineWidthTitle = new wxStaticText(
sbSizerPlotFormat->GetStaticBox(), wxID_ANY, _("Line
Thickness (mm):"), wxDefaultPosition, wxDefaultSize, 0 );
is not good for 2 reasons:
- "Default line thickness" is the right title (see a previous Wayne's answer)
- "Line Thickness (mm):" is incorrect:
the units symbol " (mm):" is added a run time, because units can be mm or
inches.
so never change titles like "Value" to "Value (mm):".
It creates a wrong title.
Besides your wxFormBuilder version is rather old and creates incorrect C++
sources: please update it.
Thanks.
--
Jean-Pierre CHARRAS
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
