Re: [Kicad-developers] [PATCH] Further QA consolidation

2019-01-29 Thread Wayne Stambaugh
John, I merged your patch. Thanks, Wayne On 1/29/2019 12:43 PM, John Beard wrote: > Hi Wayne, > > On Tue, Jan 29, 2019 at 4:56 PM Wayne Stambaugh wrote: >> Fair enough but I cannot see how the polygon changes could have broken >> the common_eeschema tests. > > The common tests were recently

Re: [Kicad-developers] [PATCH] Further QA consolidation

2019-01-29 Thread John Beard
Hi Wayne, On Tue, Jan 29, 2019 at 4:56 PM Wayne Stambaugh wrote: > Fair enough but I cannot see how the polygon changes could have broken > the common_eeschema tests. The common tests were recently replicated three times, one for each of the units defines, with each replication containing *every

Re: [Kicad-developers] [PATCH] Further QA consolidation

2019-01-29 Thread Wayne Stambaugh
Hey John, Fair enough but I cannot see how the polygon changes could have broken the common_eeschema tests. I merged your patch set. Hopefully test failures will get resolved in the not too distant future. Cheers, Wayne On 1/29/2019 9:28 AM, John Beard wrote: > Hi Wayne, > > Yes, it's the sa

Re: [Kicad-developers] [PATCH] Further QA consolidation

2019-01-29 Thread John Beard
Hi Wayne, Yes, it's the same failure, just moved into qa_common. Just a sad quirk of timing that this thing was exposed at this particular moment after being untouched for ages! Selfishly, I'd rather these patches were merged first, then the polygon issue fixed, or I'll need to rebase the series

Re: [Kicad-developers] [PATCH] Further QA consolidation

2019-01-29 Thread Wayne Stambaugh
John, I'm getting test failures with common_gerbview, common_eeschema, and common_pcbnew. I'm guessing the common_pcbnew is due to the recent polygon changes which broke the previous polygon test. Does it make sense to merge this unit the test failures are resolved? Cheers, Wayne On 1/25/2019

[Kicad-developers] [PATCH] Further QA consolidation

2019-01-25 Thread John Beard
Hi, Here are a few more patches to finish up consolidating most of the rest of the QA tools. 1) Adds some very basic dev-docs about the utility programs 2) Housekeeping in qa_utils (hide some code in KI_TEST) 3) qa_shape_factor_refactor is now only SHAPE_POLY_SET tests (the CPolyline stuff is gon