John, I merged your patch.
Thanks, Wayne On 1/29/2019 12:43 PM, John Beard wrote: > Hi Wayne, > > On Tue, Jan 29, 2019 at 4:56 PM Wayne Stambaugh <stambau...@gmail.com> wrote: >> Fair enough but I cannot see how the polygon changes could have broken >> the common_eeschema tests. > > The common tests were recently replicated three times, one for each of > the units defines, with each replication containing *every* common > unit test. See commit 90ad2406607606187b2d2eb629ce764dbb46d965. > Despite being named _pcbnew, etc, there is no such linkage. > > SHAPE_POLY_SET is a libcommon class, so the tests are now in > qa_common_{pcbnew,eeschem,gerbview}, with the other generic geometry > stuff (the contents of qa/common/geometry). > >> I merged your patch set. Hopefully test >> failures will get resolved in the not too distant future. > > Here is a patch to fix the tests (the point on an outline edge is NOT > supposed to collide according the docs). > > There could still be a defect in the SHAPE_POLY_SET implementation WRT > the hole edges: currently these edges *do* count as collisions. For > now, code and tests are consistent. If the SHAPE_POLY_SET is changed, > whoever does it should ensure the tests are updated. > > This test is a bit fiddly, I think it could be improved, but I don't > want to mess with it right now if the class its testing is having work > done on it! > > Cheers, > > John > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp