[Kicad-developers] Build failed in Jenkins: kicad-qa #5150

See Changes: [hillbrand] pcbnew: Finalize previous snapping preferences [hillbrand] eeschema: Set grid editor to use qty as the drop-down -- Started by an SCM change Building remote

[Kicad-developers] Build failed in Jenkins: kicad-qa #5149

See Changes: [tomasz.wlostowski] geometry: rewrite SHAPE_LINE_CHAIN::PointInside() to use fixed point -- Started by an SCM change Building remotely on debian8 (clang gcc linux) in w

[Kicad-developers] Build failed in Jenkins: kicad-qa #5148

See Changes: [Wayne Stambaugh] QA: Add some tests on SHAPE_POLY_SET::Distance [Wayne Stambaugh] QA: Tidy qa_utils headers -- [...truncated 3.55 KB...] The MAKEJOBS variable is empty

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

Patches merged. Thanks, Wayne On 1/29/2019 5:40 PM, John Beard wrote: > Hi, > > Following the QA patch set just merged, here are a couple more. > > 1) Add tests on SHAPE_POLY_SET::Distance and a few geometry helpers > for concisely constructing test objects. Notably: this test would have > cau

[Kicad-developers] Build failed in Jenkins: kicad-qa #5147

See Changes: [Wayne Stambaugh] QA: Fix faulty test of SHAPE_POLY_SET Collision [Wayne Stambaugh] Eeschema: fix grammar for text for ERCE_PIN_NOT_DRIVEN -- Started by an SCM change B

Re: [Kicad-developers] A trivial bug in a displayed string

John, I merged your patch. Thanks, Wayne On 1/29/2019 4:51 PM, John Beard wrote: > Hi, > > Here's a little patch. New text: "Pin connected to other pins, but > not driven by any pin". > > Cheers, > > John > > On Tue, Jan 29, 2019 at 6:33 PM Kevin Cozens wrote: >> >> Greetings. >> >> For b

Re: [Kicad-developers] [PATCH] Further QA consolidation

John, I merged your patch. Thanks, Wayne On 1/29/2019 12:43 PM, John Beard wrote: > Hi Wayne, > > On Tue, Jan 29, 2019 at 4:56 PM Wayne Stambaugh wrote: >> Fair enough but I cannot see how the polygon changes could have broken >> the common_eeschema tests. > > The common tests were recently

[Kicad-developers] [PATCH] QA: Polyset Distance tests

Hi, Following the QA patch set just merged, here are a couple more. 1) Add tests on SHAPE_POLY_SET::Distance and a few geometry helpers for concisely constructing test objects. Notably: this test would have caught the bug just fixed in 90178eb68. 2) Some internal QA tidy up to make the qa-interna

[Kicad-developers] Build failed in Jenkins: kicad-qa #5146

See Changes: [hillbrand] pcbnew: Allow STEP export tolerancing [hillbrand] pcbnew: Re-attach snap options [hillbrand] Revert "geometry: revert SHAPE_LINE_CHAIN::PointInside/PointOnEdge() -

Re: [Kicad-developers] A trivial bug in a displayed string

Hi, Here's a little patch. New text: "Pin connected to other pins, but not driven by any pin". Cheers, John On Tue, Jan 29, 2019 at 6:33 PM Kevin Cozens wrote: > > Greetings. > > For both the v5 and git master versions of Kicad in the file > drc_erc_item.cpp on line 46 there is the string: >

[Kicad-developers] A trivial bug in a displayed string

Greetings. For both the v5 and git master versions of Kicad in the file drc_erc_item.cpp on line 46 there is the string: Pin connected to some others pins but no pin to drive it There should be no s on "others". The string might be better as: Pin connected to other pins but no pin to dri

Re: [Kicad-developers] [PATCH] Further QA consolidation

Hi Wayne, On Tue, Jan 29, 2019 at 4:56 PM Wayne Stambaugh wrote: > Fair enough but I cannot see how the polygon changes could have broken > the common_eeschema tests. The common tests were recently replicated three times, one for each of the units defines, with each replication containing *every

[Kicad-developers] Build failed in Jenkins: kicad-qa #5145

See Changes: [Wayne Stambaugh] Docs: Describe QA util programs in the testing docs [Wayne Stambaugh] QA: Put UTILITY_PROGRAM in KI_TEST [Wayne Stambaugh] QA: Move contents qa_shape_poly_set_refactor to qa_common [Wayne S

Re: [Kicad-developers] [PATCH] Further QA consolidation

Hey John, Fair enough but I cannot see how the polygon changes could have broken the common_eeschema tests. I merged your patch set. Hopefully test failures will get resolved in the not too distant future. Cheers, Wayne On 1/29/2019 9:28 AM, John Beard wrote: > Hi Wayne, > > Yes, it's the sa

Re: [Kicad-developers] [PATCH] Further QA consolidation

Hi Wayne, Yes, it's the same failure, just moved into qa_common. Just a sad quirk of timing that this thing was exposed at this particular moment after being untouched for ages! Selfishly, I'd rather these patches were merged first, then the polygon issue fixed, or I'll need to rebase the series

Re: [Kicad-developers] [PATCH] Further QA consolidation

John, I'm getting test failures with common_gerbview, common_eeschema, and common_pcbnew. I'm guessing the common_pcbnew is due to the recent polygon changes which broke the previous polygon test. Does it make sense to merge this unit the test failures are resolved? Cheers, Wayne On 1/25/2019

Re: [Kicad-developers] Why we chose to put libraries in directories?

My 2 cents. Having separate files is very convenient when dealing with Pull Requests on the git libraries repos. On the kicad-symbols repo (1 file contains many symbols) there are many more merging conflicts than on kicad-footprints (1 file per footprint). Having said that, I understand that zipp