[Kicad-developers] Modeless dialogs action buttons

There are several modeless dialogs in pcbnew (for instance, Exchange Footprint and Plot) which have action buttons and a “Cancel” button. These shouldn’t be called “Cancel” as they don’t cancel the action. They should be either “Done” or “Close”. ___

[Kicad-developers] SELECTION_TOOL::guessSelectionCandidates()

Hi Maciej, Could you have a look at bug https://bugs.launchpad.net/bugs/1739425 ? (I’m happy to build a patch for it if you can confirm my analysis of what’s going wrong.) Cheers, Jeff.___ Mailing list: https

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

Hi All- West Coast time here, so takes a bit longer to see these chains. This wasn't to add a new feature. This was to support the existing feature documented at http://docs.kicad-pcb.org/stable/en/eeschema.html#global-connections-between-buses -S On Wed, Dec 20, 2017 at 8:19 AM, Wayne Stamba

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

Thanks for the update. I will defer this until the version 6 development is opened. On 12/20/2017 11:03 AM, Jon Evans wrote: > For V5, the color issue would have to be resolved in a different way > than I was proposing, since the connectivity information won't be there. > > I think it might be b

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

On 2017-12-20 08:18 AM, Wayne Stambaugh wrote: I'm also thinking that the bus junction color should be the same color as the bus color rather than the wire color It would be better to use the same colour for a bus junction as is used for a bus. The schematic would look a little strange if the

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

For V5, the color issue would have to be resolved in a different way than I was proposing, since the connectivity information won't be there. I think it might be best to hold off on this patch until after V6 development is open since it is not a major bug fix and it would be prudent to do a fair a

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

I will have to think about this some more and look through the code to be sure of the impact (or lack of impact) The connectivity algorithm generates the names (with the dots) but doesn't necessarily need to parse the strings afterwards except for ERC checking. The syntax of defining bus labels is

Re: [Kicad-developers] Flip board view: horizontal scrollbar swapped ?

Thanks for the information. The demo video was interesting. On 12/20/2017 10:33 AM, Jon Evans wrote: > You can see a bit of how Zuken CR-8000 implements it in this demo video: > https://www.youtube.com/watch?v=Sz65OUE48sI > > I have played with their software a bit when we were considering it fo

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Sounds like a plan. Wayne On 12/20/2017 10:31 AM, Maciej Sumiński wrote: > Hi Wayne, > > The new algorithm is definitely better, as it generates simpler > polygons, but in my opinion is not worth the risk right now. 'I am sure > it is ok' are frequent last words. I think we can wait for v6, > es

Re: [Kicad-developers] Flip board view: horizontal scrollbar swapped ?

You can see a bit of how Zuken CR-8000 implements it in this demo video: https://www.youtube.com/watch?v=Sz65OUE48sI I have played with their software a bit when we were considering it for purchase... they have a unified graphics engine for 2D and 3D editing, so you can seamlessly switch between t

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Hi Wayne, The new algorithm is definitely better, as it generates simpler polygons, but in my opinion is not worth the risk right now. 'I am sure it is ok' are frequent last words. I think we can wait for v6, especially that the to-do list regarding the code is not so long. Cheers, Orson On 12/2

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

With out a separator, how does the connection algo know when a dot is part of a name or the separator between the name and the sub-connection or rre you suggesting that there be no separator so DATA[0..7] would break out into DATA0, DATA1, ...? If so, I'm not sure this would be feasible. @Jon, se

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

What is the probability that this breaks any existing schematics and how soon could the color issue be resolved? If the risk of breaking existing schematics is very low and the color issue can be resolved reasonably soon, then I would consider merging for the stable 5 version. Otherwise, we shoul

Re: [Kicad-developers] [PATCH] BuildConnectivity and re-DisplayBoard in python Refresh

Miles, Please resend the patch. It go lost in the chaos that is my inbox. Thanks, Wayne On 12/20/2017 1:52 AM, miles mccoo wrote: > Bumpity bump.   > > Sounds like folks like the patch. Will someone merge it, please? > > Miles > > On Dec 7, 2017 3:13 PM, "Wayne Stambaugh"

Re: [Kicad-developers] Flip board view: horizontal scrollbar swapped ?

On 12/19/2017 10:45 PM, Jon Evans wrote: > I would file a bug report for this. > > There is actually an underlying problem that is going to keep causing > little things like this to pop up... > The GAL / tool framework doesn't have a transform matrix applied between > the user inputs and the world

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Orson, How confident are you that it will not introduce new zone filling bugs? As long as I have a warm fuzzy that the risk is low and that Andreas will be available to address issues in a timely manner, then I'm fine with merging this. Otherwise, we should hold off until the version 6 developmen

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

I see no value in adding a forced separator, I am not talking about a configurable, maybe this has been unclear. I am talking about no separator. So that I can put a dot or whatever i feel like anyway. On 2017-12-20 14:47, Maciej Sumiński wrote: Hi Kristoffer, No offence, but is there any ad

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

Hi Kristoffer, No offence, but is there any added value in using a configurable separator character or is it just your preference? It seems to me that adding such feature will complicate the code a lot for a small benefit, but I may not see the full picture. Perhaps it is just a convention that we

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

This patch is essential for my connectivity work (but that's not a V5 thing...) It would be quite easy for me to implement the color thing as part of the connectivity changes (since the junction would be able to know if it was connected to buses or not) -Jon On Wed, Dec 20, 2017 at 8:18 AM, Wayne

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

Then dont use a underscore? If the dot is not inserted, nothing hinders you from not putting a underscore there? On 2017-12-20 13:32, Wayne Stambaugh wrote: Using an underscore as a replacement for the period will add another reserved character which will add complexity to the parser and/or re

Re: [Kicad-developers] [PATCH] Correct bus junction behavior

Seth, Technically this is a new feature since KiCad has never used junction indicators on buses in the past so I'm hesitant to merge this for version 5. I do like the dragging of buses that this patch provides. I'm also thinking that the bus junction color should be the same color as the bus colo

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

Using an underscore as a replacement for the period will add another reserved character which will add complexity to the parser and/or require quoting when saving to the file which makes the file format less readable. On 12/19/2017 4:52 PM, kristoffer Ödmark wrote: > Why would this be problematic

Re: [Kicad-developers] EESchema: regression in object moving?

Odd… After rolling back all the way past 4.0.7 and still getting buggy behaviour in my development build, I gave up. However, coming back forward produced odd build errors and the like. So I re-applied the wxWidgets OSX patches, rebuilt wxWidgets, re-ran kicad’s CMake, and did a full build

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Hi Orson, I see that this is a high risk change and I fully understand if you don't want to merge it now. best, Andreas On 12/20/2017 10:53 AM, Maciej Sumiński wrote: > Hi Andreas, > > I tested the patch with many boards and I confirm it reduces the polygon > complexity, without introducing an

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Hi Andreas, I tested the patch with many boards and I confirm it reduces the polygon complexity, without introducing any DRC violations. I would love to merge it, but it is difficult for me to assess the risk of adding new bugs, which are particularly not wanted during the feature freeze. If Wayne