On Thu, Apr 13, 2017 at 11:55 PM, Tiger12506 wrote:
> My opinion doesn't matter, but how about this for a comment...
>
> // ReadName has a side-effect of incrementing the parser, so it should
> indeed be called twice.
>
> I certainly agree with you that people shouldn't change something they don't
On 2017-04-13 06:06 PM, Cirilo Bernardo wrote:
On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller wrote:
These lines scream for some comments in the source...
I wouldn't get it, too.
What sort of comment: "this is really supposed to have two sequential
calls to the same function, so don't change
My opinion doesn't matter, but how about this for a comment...
// ReadName has a side-effect of incrementing the parser, so it should
indeed be called twice.
I certainly agree with you that people shouldn't change something they
don't understand, but I also don't think it's unreasonable for s
On Thu, Apr 13, 2017 at 1:34 PM, Clemens Koller wrote:
> Hi!
>
> These lines scream for some comments in the source...
> I wouldn't get it, too.
>
> Regards,
>
> Clemens
>
What sort of comment: "this is really supposed to have two sequential
calls to the same function, so don't change it"? For m
Just a friendly reminder about this, I haven't heard anything since
attaching the correct patches.
Cheers
On 7 Apr 2017 19:27, "Oliver Walters"
wrote:
> I am very sorry about this, three mistakes in a row!
>
> It has been pointed out that I have attached the patches in the incorrect
> order.
>
Hi Oksana,
This feature has been requested and discussed in the past. There may
even be a bug report for it in our bug tracker.
You could use the array tool in the GAL canvas but it's not very usable
for large boards due to speed issues.
I personally don't have the time to work on this. Maybe
Hello
I'm wondering if it's possible to add functions to the program as in this
script Replicating pcbnew new for arrayed sheets
https://kicad.mmccoo.com/2017/02/01/replicating-pcbnew-new-for-arrayed-sheets/
and how here Panelize Http://projects.borg.ch/electronics/kicad/panelize.html
I can pay
Where do we stand on a fix for this?
On 4/10/2017 3:18 AM, jp charras wrote:
> Le 10/04/2017 à 08:39, Nick Østergaard a écrit :
>> Hi JP,
>>
>> Yes I can confirm that it seems to work now, but since you mentioned
>> that it was not fixed properly yet, I thought it was worth
>> highlighting in this
Konrad,
I merged your patch into the master branch. Thank you for your
contribution to KiCad.
Cheers,
Wayne
On 4/12/2017 4:01 PM, Konrad Beckmann wrote:
> ---
> common/dsnlexer.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
>
>
> ___
> Mailing list
Simon,
I committed your patch since osx expects the icons to be disabled by
default.
Thanks,
Wayne
On 4/8/2017 6:42 AM, Simon Wells wrote:
> Please see attached patch to disable icons in the menus by default on osx
>
>
>
> ___
> Mailing list: https
I agree,
A patch to add explanatory comments would seem to be required
here.
Otherwise someone in the future is likely to make a similar change
in a larger patch and it will likely be missed during review.
Regards
David G
On 13/04/17 21:34,
Hi!
These lines scream for some comments in the source...
I wouldn't get it, too.
Regards,
Clemens
On 2017-04-13 14:03, Wayne Stambaugh wrote:
> Cirilo,
>
> Thanks for the info. The second call to ReadName() does look a bit odd
> so I can understand Konrad's confusion.
>
> Cheers,
>
> Wayne
Cirilo,
Thanks for the info. The second call to ReadName() does look a bit odd
so I can understand Konrad's confusion.
Cheers,
Wayne
On 4/12/2017 6:12 PM, Cirilo Bernardo wrote:
> Do not accept this patch, it will break the parser. The statement
> which was removed is not redundant.
>
> - Cir
Hello,
This is my second contribution. It's a simple one line addition to
netclass.i to expose the netclassptr constructor, enabling python scripts
to add new netclasses.
In my first contribution, I made a couple errors in the contribution
process which Wayne graciously fixed for me. I did look a
14 matches
Mail list logo
