Re: [Kicad-developers] [PATCH 2/2] Remove redundant statement in WRL2BASE::ReadNode

[David Godfrey]

I agree, A patch to add explanatory comments would seem to be required here. Otherwise someone in the future is likely to make a similar change in a larger patch and it will likely be missed during review. Regards David G On 13/04/17 21:34, Clemens Koller wrote: Hi! These lines scream for some comments in the source... I wouldn't get it, too. Regards, Clemens On 2017-04-13 14:03, Wayne Stambaugh wrote: Cirilo, Thanks for the info. The second call to ReadName() does look a bit odd so I can understand Konrad's confusion. Cheers, Wayne On 4/12/2017 6:12 PM, Cirilo Bernardo wrote: Do not accept this patch, it will break the parser. The statement which was removed is not redundant. - Cirilo On Wed, Apr 12, 2017 at 8:01 PM, Konrad Beckmann <konrad.beckm...@gmail.com> wrote: --- plugins/3d/vrml/v2/vrml2_base.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp -- Regards David Godfrey mb: chat: 0437 286 200 with dcg_mx at #sbts:matrix.org Chat is via matrix.org. There are clients available for All Operating Systems and Hardware devices. Including Linux, Android, Windows, Mac, iOS I'd recommend the multiplatform RIOT client as the best starting point. with RIOT web the easiest on any PC

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp