Wayne, what do you think? If it is acceptable, then I would like to
merge the patches. I should not judge my code, as I might be tempted to
consider it a good solution.
In case my proposal to cache the bounding box in autorouter code is not
approved, then I would say #2 would do the job.
Cheers,
Hi Jean-Samuel,
Thank you, a bug report on a nightly now is tagged
no-vcs-found-be10de8~57~ubuntu16.10.1, which is much clearer!
Cheers,
John
On Mon, Feb 27, 2017 at 8:22 PM, Jean-Samuel Reynaud
wrote:
> Hi all,
>
> In your example 7735 is the revno form the git repo (It is not related
> to bz
This got overlooked in common_tools refactor
-Jon
From 5eeb0dbf18477b9358335a0943c0aeb0767307ad Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Tue, 28 Feb 2017 21:58:15 -0500
Subject: [PATCH] Register common tools in footprint viewer to fix zoom
controls
---
pcbnew/modview_frame.cpp | 2 ++
1
On Wed, Mar 1, 2017 at 11:13 AM, Wayne Stambaugh wrote:
> On 2/28/2017 7:07 PM, Cirilo Bernardo wrote:
>> On Wed, Mar 1, 2017 at 10:33 AM, Wayne Stambaugh
>> wrote:
>>> On 2/28/2017 4:08 PM, Cirilo Bernardo wrote:
On Wed, Mar 1, 2017 at 12:18 AM, Wayne Stambaugh
wrote:
> On 2/27/
Update: after some more testing, I think Orson's patch on top of mine is
the way to go. It pulls the computation out of the loops for autorouter,
and that's the only place where the board's bounding box is used
repetitively. Since the other call sites are only going to get the
bounding box interm
On 2/28/2017 7:07 PM, Cirilo Bernardo wrote:
> On Wed, Mar 1, 2017 at 10:33 AM, Wayne Stambaugh wrote:
>> On 2/28/2017 4:08 PM, Cirilo Bernardo wrote:
>>> On Wed, Mar 1, 2017 at 12:18 AM, Wayne Stambaugh
>>> wrote:
On 2/27/2017 8:57 PM, Cirilo Bernardo wrote:
> On Tue, Feb 28, 2017 at 1
Hi Wayne,
On Wed, Mar 1, 2017 at 2:06 AM, Wayne Stambaugh wrote:
> Sorry John. I was going to recommend we apply your patch as is
> (assuming you didn't change the click behavior) to fix the gtk issue.
> We can discuss other changes to the behavior later.
I haven't changed any behaviour or posi
On Wed, Mar 1, 2017 at 10:33 AM, Wayne Stambaugh wrote:
> On 2/28/2017 4:08 PM, Cirilo Bernardo wrote:
>> On Wed, Mar 1, 2017 at 12:18 AM, Wayne Stambaugh
>> wrote:
>>> On 2/27/2017 8:57 PM, Cirilo Bernardo wrote:
On Tue, Feb 28, 2017 at 1:07 AM, Wayne Stambaugh
wrote:
> On 2/26/
I'm finally back to this problem now that I have some other WIP committed.
As far as I can tell, there two paths to go down for this problem:
1) Implement auto-caching of the bounding box. This requires some
mechanism to tell BOARD that it needs to update the cache, be it OBSERVABLE
or some othe
On 2/28/2017 4:08 PM, Cirilo Bernardo wrote:
> On Wed, Mar 1, 2017 at 12:18 AM, Wayne Stambaugh wrote:
>> On 2/27/2017 8:57 PM, Cirilo Bernardo wrote:
>>> On Tue, Feb 28, 2017 at 1:07 AM, Wayne Stambaugh
>>> wrote:
On 2/26/2017 4:04 PM, Cirilo Bernardo wrote:
> There is one other way wh
On 2/27/2017 8:26 AM, Jean-Samuel Reynaud wrote:
> Hi All,
>
> After many tests, I plan to activate action plugin submenu in PPA daily
> build in few days. (cmake option -DKICAD_SCRIPTING_ACTION_MENU=ON)
>
> Any comments ?
>
As long as you are willing to fix any bugs and help support users who
Thank you Oliver!
On 2/28/2017 5:36 PM, Oliver Walters wrote:
> jp,
>
> There were three library files with this issue:
>
> * power.lib
> * memory.lib
> * transistors.lib
>
> These have been addressed here
> - https://github.com/KiCad/kicad-library/pull/1076 (autofix with the KLC
> scripts!)
>
jp,
There were three library files with this issue:
* power.lib
* memory.lib
* transistors.lib
These have been addressed here -
https://github.com/KiCad/kicad-library/pull/1076 (autofix with the KLC
scripts!)
Oliver
On Wed, Mar 1, 2017 at 5:31 AM, jp charras wrote:
> Le 28/02/2017 à 16:18, J
On Wed, Mar 1, 2017 at 12:18 AM, Wayne Stambaugh wrote:
> On 2/27/2017 8:57 PM, Cirilo Bernardo wrote:
>> On Tue, Feb 28, 2017 at 1:07 AM, Wayne Stambaugh
>> wrote:
>>> On 2/26/2017 4:04 PM, Cirilo Bernardo wrote:
There is one other way which I found after much digging
and it involves
Le 28/02/2017 à 16:18, Julius Schmidt a écrit :
>> Is this lib built with Kicad?
>
>> From
> https://github.com/KiCad/kicad-library/blob/master/library/transistors.lib
>
> DEF BDW93 Q 0 0 Y N 1 F N
> F0 "Q" 200 75 50 H V L CNN
> F1 "BF240" 200 0 50 H V L CNN
>
> There may be other ones.
>
OK.
Sorry John. I was going to recommend we apply your patch as is
(assuming you didn't change the click behavior) to fix the gtk issue.
We can discuss other changes to the behavior later. I'll try to get to
it this evening.
On 2/28/2017 12:01 PM, John Beard wrote:
> Hi,
>
> Sorry to bump, but this
Hi,
Sorry to bump, but this patchset fixes a fairly annoying usability bug
on Linux/GTK+.
Are there any comments about it? It seems to work OK my my development
branch. There have been no conflicts in the last week, but I rebased
it up to master anyway.
Cheers,
John
On Thu, Feb 23, 2017 at 8:3
On 2/28/2017 9:29 AM, Maciej Sumiński wrote:
> On 02/28/2017 03:01 PM, Wayne Stambaugh wrote:
>> On 2/28/2017 4:37 AM, Maciej Sumiński wrote:
>>> Hi Wayne,
>>>
>>> Would you have a look at the attached patches? I do not want to
>>> introduce changes to the schematic plugins code without your approv
Congratulations Tom. Good work.
В Вторник, 28 фев. 2017 в 1:37 , Tomasz Wlostowski
написал:
On 27.02.2017 22:52, Wayne Stambaugh wrote:
I have just given product and stable branch commit privileges to
Tomasz
Wlostowski. Please join me in congratulating him for his promotion
to
the lead d
On 02/28/2017 03:01 PM, Wayne Stambaugh wrote:
> On 2/28/2017 4:37 AM, Maciej Sumiński wrote:
>> Hi Wayne,
>>
>> Would you have a look at the attached patches? I do not want to
>> introduce changes to the schematic plugins code without your approval.
>>
>> The first one removes multiple chunks of c
I seem to remember the z specifier causing issues on some platforms but
that may have been in the 2.8 branch of wx but it's been a while so my
memory is not so clear on the issue. If you choose use the z specifier
(which is the correct way to do this), it will need to be thoroughly
tested on all p
On 28.02.2017 04:06, Jon Evans wrote:
> Hi all,
>
> This patch is another in my series of refactoring for tools to enable
> them to be used across applications.
Merged, with some minor fixes.
Thanks again,
Tom
___
Mailing list: https://launchpad.net/
On 28.02.2017 03:42, Jon Evans wrote:
> One more fixup patch -- this should teach me to not try to work on two
> things at once
Hi Jon,
I've just merged your patches. Many thanks again for your contributions!
Best,
Tom
___
Mailing list: https://launch
On 2/28/2017 1:20 AM, Cirilo Bernardo wrote:
> As part of my work in progress on fixing UTF8 filename issues
> under MinGW, I need to add 2 new files to the source tree:
>
> streamwrapper.cpp
> streamwrapper.h
>
> I noticed that the copyright.h file has a GPL3+ template but the
> coding-style-pol
On 2/28/2017 4:37 AM, Maciej Sumiński wrote:
> Hi Wayne,
>
> Would you have a look at the attached patches? I do not want to
> introduce changes to the schematic plugins code without your approval.
>
> The first one removes multiple chunks of code that regenerate properties
> basing on the PART_L
On 2/27/2017 8:57 PM, Cirilo Bernardo wrote:
> On Tue, Feb 28, 2017 at 1:07 AM, Wayne Stambaugh wrote:
>> On 2/26/2017 4:04 PM, Cirilo Bernardo wrote:
>>> There is one other way which I found after much digging
>>> and it involves a GCC extension. Since we use GCC on
>>> Windows this might be acce
On Tue, Feb 28, 2017 at 9:00 PM, Robbert Lagerweij
wrote:
> Hi Thomas,
>
> Thank you for your feedback. The duplication of code is indeed not how I
> would usually approach this but I thought it the lesser of two evils given
> the fact that the legacy stuff will most likely be deprecated immediate
Hi Thomas,
Thank you for your feedback. The duplication of code is indeed not how I would
usually approach this but I thought it the lesser of two evils given the fact
that the legacy stuff will most likely be deprecated immediately after the 5.0
release. This means that long term maintainabili
Le 28/02/2017 à 01:09, Julius Schmidt a écrit :
> Currently eeschema crashes when a library has a component where
> the name under "DEF" does not agree with the name under "F1".
> I believe rev f35cb6cd6af3900b1967f8ef73396b9d9b8bc24c caused this
> issue -- previously we would add the "DEF" name to
On 27.02.2017 20:50, Robbert Lagerweij wrote:
> This is a corrected version of the patch.
>
>
> My apologies again for letting this slip through.
>
> To be doubly sure, I just performed a merge and build test on this patch
> and it should apply cleanly to master.
>
Hi Robert,
I had a look at y
On 27.02.2017 22:52, Wayne Stambaugh wrote:
> I have just given product and stable branch commit privileges to Tomasz
> Wlostowski. Please join me in congratulating him for his promotion to
> the lead development team. For those who don't know, Tom is responsible
> for the P&S router, tool framew
Le 28/02/2017 à 09:25, Maciej Sumiński a écrit :
> Great! KiCad demands high quality work force, congratulations Tom!
>
> Cheers,
> Orson
>
> On 02/27/2017 10:52 PM, Wayne Stambaugh wrote:
>> I have just given product and stable branch commit privileges to Tomasz
>> Wlostowski. Please join me in
On 28.02.2017 10:33, Julius Schmidt wrote:
I know about %zu, but this is wx Printf, not C99 printf. Does it also support
%zu?
Yes, it does:
http://docs.wxwidgets.org/3.1/classwx_string.html#a9588b7f2684b9a6a924dc3746a2b2f8d
--- quote:
Note
This function will use a safe version of vsprintf()
One more patch to make the change complete.
On 02/28/2017 10:37 AM, Maciej Sumiński wrote:
> Hi Wayne,
>
> Would you have a look at the attached patches? I do not want to
> introduce changes to the schematic plugins code without your approval.
>
> The first one removes multiple chunks of code th
Hi Wayne,
Would you have a look at the attached patches? I do not want to
introduce changes to the schematic plugins code without your approval.
The first one removes multiple chunks of code that regenerate properties
basing on the PART_LIB field values. Instead, a PROPERTIES object is
maintained
I got the privilege to watch Tomasz working live on KiCad @FOSDEM ... amazing
code skills.. and a very good presentation performance.
He uses a source-code editor... with a dark background scheme! ...His g33kness
level is very high .. very high.. I was impressed!
I think we should trust him.. ye
Ok, that's closer to what an earlier patch of mine did. I was wondering
about the right place to put it.
Amended version (admittedly untested).
---
pcbnew/router/router_tool.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/pcbnew/router/router_tool.cpp b/pcbnew/rout
I know about %zu, but this is wx Printf, not C99 printf. Does it also
support %zu? Do we use it anywhere else?
On Tue, 28 Feb 2017, Sergey A. Borshch wrote:
On 28.02.2017 01:54, Julius Schmidt wrote:
This patch fixes a format string assertion.
...
-txt.Printf( wxT( "%u" ), net
Great! KiCad demands high quality work force, congratulations Tom!
Cheers,
Orson
On 02/27/2017 10:52 PM, Wayne Stambaugh wrote:
> I have just given product and stable branch commit privileges to Tomasz
> Wlostowski. Please join me in congratulating him for his promotion to
> the lead development
39 matches
Mail list logo
