On 27.02.2017 20:50, Robbert Lagerweij wrote: > This is a corrected version of the patch. > > > My apologies again for letting this slip through. > > To be doubly sure, I just performed a merge and build test on this patch > and it should apply cleanly to master. > Hi Robert,
I had a look at your patch, there seems to be a lot of repetitive code (the functionality is duplicated between legacy/GAL canvas). Personally I wouldn't add new features to the legacy canvas. I also noticed you use a bitwise | operator instead of the logical one in few places in the code and some minor coding style issues (e.g. naming of new members in DIALOG_MOVE_EXACT class). Could you have a look at these issues? Thank you very much for your contribution! Tom _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
