Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-13 Thread Kirill A. Shutemov
On Tue, Mar 04, 2025 at 03:53:27PM -0800, Andrew Morton wrote: > Yan, please go back through the discussion and incorporate reviewer > feedback into the changelogs: describe the possible issues which people > have raised and your responses to those. Then resend and then let us > restart the review

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-12 Thread Dave Hansen
On 3/4/25 11:16, Dave Hansen wrote: > On 3/4/25 10:49, Eric W. Biederman wrote: >> How goes the work to fix this horrifically slow firmware interface? > The firmware interface isn't actually all that slow. Hey Eric, I've noticed a trend on this series. It seems like every time there's some forwar

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Andrew Morton
On Tue, 4 Mar 2025 15:53:27 -0800 Andrew Morton wrote: > Yan, please go back through the discussion and incorporate reviewer > feedback into the changelogs: describe the possible issues which people > have raised and your responses to those. Then resend and then let us > restart the review proc

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Andrew Morton
On Tue, 4 Mar 2025 15:43:53 -0800 Andrew Morton wrote: > On Mon, 13 Jan 2025 19:12:27 +0800 Baoquan He wrote: > > > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > > > On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > > > > Hi Eric, > > > > > > > > This is a repost of the patch

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Andrew Morton
On Mon, 13 Jan 2025 19:12:27 +0800 Baoquan He wrote: > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > > On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > > > Hi Eric, > > > > > > This is a repost of the patch "kexec_core: Accept unaccepted kexec > > > destination addresses" [1], r

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Dave Hansen
On 3/4/25 10:49, Eric W. Biederman wrote: > How goes the work to fix this horrifically slow firmware interface? The firmware interface isn't actually all that slow. The fundamental requirement is that confidential computing environments need to be handed memory in a known-benign state. For AMD SE

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Eric W. Biederman
"Kirill A. Shutemov" writes: > On Fri, Feb 14, 2025 at 08:20:07AM -0800, Dave Hansen wrote: >> On 2/14/25 05:46, Kirill A. Shutemov wrote: >> >> It sounds like you're advocating for the "slow guest boot" option. >> >> Kirill, can you remind us how fast a guest boots to the shell for >> >> modestl

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-03-04 Thread Kirill A. Shutemov
On Fri, Feb 14, 2025 at 08:20:07AM -0800, Dave Hansen wrote: > On 2/14/25 05:46, Kirill A. Shutemov wrote: > >> It sounds like you're advocating for the "slow guest boot" option. > >> Kirill, can you remind us how fast a guest boots to the shell for > >> modestly-sized (say 256GB) memory with "acce

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-02-19 Thread Ashish Kalra
> On Thu, Feb 13, 2025 at 07:55:15AM -0800, Dave Hansen wrote: >> On 1/13/25 06:59, Eric W. Biederman wrote: >> ... >> > I have a new objection. I believe ``unaccepted memory'' and especially >> > lazily initialized ``unaccepted memory'' is an information leak that >> > could defeat the purpose of

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-02-19 Thread Jianxiong Gao
> > It sounds like you're advocating for the "slow guest boot" option. > > Kirill, can you remind us how fast a guest boots to the shell for > > modestly-sized (say 256GB) memory with "accept_memory=eager" versus > > "accept_memory=lazy"? IIRC, it was a pretty remarkable difference. > > I only have

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-02-14 Thread Dave Hansen
On 2/14/25 05:46, Kirill A. Shutemov wrote: >> It sounds like you're advocating for the "slow guest boot" option. >> Kirill, can you remind us how fast a guest boots to the shell for >> modestly-sized (say 256GB) memory with "accept_memory=eager" versus >> "accept_memory=lazy"? IIRC, it was a prett

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-02-14 Thread Kirill A. Shutemov
On Thu, Feb 13, 2025 at 07:55:15AM -0800, Dave Hansen wrote: > On 1/13/25 06:59, Eric W. Biederman wrote: > ... > > I have a new objection. I believe ``unaccepted memory'' and especially > > lazily initialized ``unaccepted memory'' is an information leak that > > could defeat the purpose of encryp

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-02-13 Thread Dave Hansen
On 1/13/25 06:59, Eric W. Biederman wrote: ... > I have a new objection. I believe ``unaccepted memory'' and especially > lazily initialized ``unaccepted memory'' is an information leak that > could defeat the purpose of encrypted memory. For that reason I have > Cc'd the security list. I don't

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-14 Thread Kirill A. Shutemov
On Mon, Jan 13, 2025 at 08:59:29AM -0600, Eric W. Biederman wrote: > Baoquan He writes: > > > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > >> On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > >> > Hi Eric, > >> > > >> > This is a repost of the patch "kexec_core: Accept unaccepte

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-13 Thread Yan Zhao
On Mon, Jan 13, 2025 at 08:59:29AM -0600, Eric W. Biederman wrote: > Baoquan He writes: > > > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > >> On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > >> > Hi Eric, > >> > > >> > This is a repost of the patch "kexec_core: Accept unaccepte

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-13 Thread Baoquan He
Hi Eric, On 01/13/25 at 08:59am, Eric W. Biederman wrote: > Baoquan He writes: > > > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > >> On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > >> > Hi Eric, > >> > > >> > This is a repost of the patch "kexec_core: Accept unaccepted kexec

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-13 Thread Eric W. Biederman
Baoquan He writes: > On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: >> On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: >> > Hi Eric, >> > >> > This is a repost of the patch "kexec_core: Accept unaccepted kexec >> > destination addresses" [1], rebased to v6.13-rc2. >> >> Can we get

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-13 Thread Baoquan He
On 01/13/25 at 12:01pm, Kirill A. Shutemov wrote: > On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > > Hi Eric, > > > > This is a repost of the patch "kexec_core: Accept unaccepted kexec > > destination addresses" [1], rebased to v6.13-rc2. > > Can we get this patch applied? This look

Re: [PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2025-01-13 Thread Kirill A. Shutemov
On Fri, Dec 13, 2024 at 05:49:30PM +0800, Yan Zhao wrote: > Hi Eric, > > This is a repost of the patch "kexec_core: Accept unaccepted kexec > destination addresses" [1], rebased to v6.13-rc2. Can we get this patch applied? -- Kiryl Shutsemau / Kirill A. Shutemov

[PATCH v2 0/1] Accept unaccepted kexec segments' destination addresses

2024-12-13 Thread Yan Zhao
Hi Eric, This is a repost of the patch "kexec_core: Accept unaccepted kexec destination addresses" [1], rebased to v6.13-rc2. The code implementation remains unchanged, but the patch message now includes more background and explanations to address previous concerns from you and Baoquan. Addition