Re: Scope of framework integration plugin?

On Monday 30 of November 2015 12:48:26 Martin Graesslin wrote: > Hi all, > > there is currently a review request to add OSX specific changes to framework > integration plugin [1]. > > This seems wrong to me. I think our framework integration plugin is about > integration Qt applications into the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dic. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the appl

Re: about ki18n/locales: installing only a subset?

On Wednesday 16 of December 2015 14:44:54 René J.V. Bertin wrote: > On Wednesday December 16 2015 14:18:33 Jaroslaw Staniek wrote: > > How about bundling the files in qrc containers, one per language to > > address > > the issue of many tiny files? > > Agreed (and a priori already raised in a prev

Review Request 126648: Allow to disable KArchive for internal usage

: https://git.reviewboard.kde.org/r/126648/diff/ Testing --- Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 126648: Allow to disable KArchive for internal usage

it.reviewboard.kde.org/r/126648/#review90682 ------- On Gen. 6, 2016, 1:58 a.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126648: Allow to disable KArchive for internal usage

required. Diffs (updated) - CMakeLists.txt 2ec3027 src/CMakeLists.txt 136fbfb src/xslt_kde.cpp 7069a28 Diff: https://git.reviewboard.kde.org/r/126648/diff/ Testing --- Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON Thanks, Luigi Toscano

Re: Review Request 126681: Duplicate the file descriptor while opening

> On Gen. 9, 2016, 2:28 p.m., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? I think it was already done: https://mail.kde.org/pipermail/release-team/2016-January/009263.html - Luigi --- This is an automatically

Re: Review Request 126648: Allow to disable KArchive for internal usage

marked as submitted. Review request for Build System, KDE Frameworks, Alex Merry, and David Faure. Changes --- Submitted with commit cbd56540d0fd3a9a4b46b621c10a0b619e57ed46 by Luigi Toscano to branch master. Repository: kdoctools Description --- Most of the code was already

Re: Finding kdesu binary

On Friday 29 of January 2016 16:13:55 Aleix Pol wrote: > On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas wrote: > > Hi, > > > > I would like to ask how do I find kdesu binary from the code (of > > partitionmanager). > > > > PartitionManager tries to restart itself with root privileges and tri

Re: Review Request 126936: help: fix garbage sent when serving static files

ead to this issue. - Luigi Toscano On Gen. 31, 2016, 11:01 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Re: Review Request 126936: help: fix garbage sent when serving static files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126936/#review91819 --- Ship it! Inviala! - Luigi Toscano On Gen. 31, 2016, 11

Re: KActivities repository split

Ivan Čukić ha scritto: > Hi everyone, > > As previously announced, KActivities has been split into a few > separate repositories. This mail is mostly intended to notify our dear > packagers of the change, and the plan for the transition period. > > KActivities framework 5.19 (as released a few da

Re: Review Request 127110: Drop KF5DocTools dependency

conditionally disable also the final part of src/CMakeLists.txt, which installs the compatibility DTD (from "## DocBookXML 4.2 compatibility"). - Luigi Toscano On Feb. 18, 2016, 7:45 p.m., Aleix Pol Gonzalez wrote: > >

Re: Review Request 127046: Move popup menu image actions into a submenu

> On Feb. 12, 2016, 3:37 p.m., Thomas Pfeiffer wrote: > > I wouldn't say that all actions for images are rarely used. > > I don't see why viewing, copying or saving an image is less frequently done > > than the same things regarding the link. Can't we have those three still on > > the first lev

Re: gcode.xml got into KF5::KTextEditor without review

Alexander Potashev ha scritto: > Hi everyone, (Sven), > > As I understand, KF5 does not have feature freezes because all changes > are unit-tested and reviewed [1]. > > [2] is clearly a feature, but it was not submitted to reviewboard > before pushing to ktexteditor.git:master. This change also i

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

> On Mar. 12, 2016, 4:07 p.m., Christoph Feck wrote: > > Can someone confirm the issue is still present with Qt 5.6? > > > > Unless it is, I suggest to not work around the Qt bug, because the release > > of Qt 5.6 is imminent and this fix does not reach our users earlier. Don't we still suppor

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

marked as submitted. Review request for Kate, KDE Frameworks and Daniel Vrátil. Changes --- Submitted with commit e6b6e7c633882ef00c1bd0b301259286e5a123cd by Luigi Toscano to branch master. Repository: ktexteditor Description --- The file is really ASCII-only (7 bit), so both ISO

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

r/127406/#review93635 --- On March 17, 2016, 10:17 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 127406: Fix encoding for gap.xml (use UTF-8)

/009327.html Diffs - src/syntax/data/gap.xml 1af543d Diff: https://git.reviewboard.kde.org/r/127406/diff/ Testing --- Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 127557: Fix obsolete link in kdebugdialog5 docbook

n and will be used consistently in the future to find the repository browser. - Luigi Toscano On April 3, 2016, 11 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Delaying KF 5.21

Christoph Cullmann ha scritto: > Hi, > > Yeah, this must be fixed. > > I will take a look myself this afternoon if nobody feels guilty for the > changes.. > > :=/ I already ponged the list some days ago, given I didn't submit any > changes in the last time... Can you please revert this in the

Re: kdewebkit?

On Thursday 21 of April 2016 08:45:44 Scarlett Clark wrote: > https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compil > er=gcc/32/console > > And if I understand correctly, qt webkit is no more? So should this project > be removed from CI? IIRC as long as we support Qt <5.6,

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

On Monday 25 of April 2016 19:14:00 Ben Cooksley wrote: > On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin wrote: > > In summary: I don't want spend time to investigate false positives. If an > > option results in false positives, I think that we should disable it. > > Understandable. > > > Of

Re: Review Request 127906: Remove qt5options manpage docbook

example from kf5options). We have the question about kf5options which comes immediately after. It would be interesting to know if the (updated) content of qt5options could be contributed somehow directly to Qt. - Luigi Toscano On May 13, 2016, 4:12 p.m., Burkhard Lück wrote

Re: Review Request 127897: Update documentation of kdoctools_install macro

can go in. KF5DocToolsMacros.cmake (line 60) <https://git.reviewboard.kde.org/r/127897/#comment64728> The manpage could stay directly under docs, but let's go for this suggested solution. - Luigi Toscano On Mag. 12, 2016, 10:46 a.m., Elvis Angel

Review Request 127935: Call kdoctools_create_handbook only for index.docbook

Diff: https://git.reviewboard.kde.org/r/127935/diff/ Testing --- Tried kdoctools_install when the (translated) documentation is made of multiple docbooks (like krusader), see the bug for more details. Thanks, Luigi Toscano ___ Kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

----------- On Mag. 16, 2016, 12:51 a.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127935/ > --

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

index.docbook is installed > > using KDOCTOOLS_CREATE_HANDBOOK." > > Luigi Toscano wrote: > Makes sense. Ups, ate my comment: I wanted to write that it is partially correct, as kdoctools_create_handbook installs all the other docbook files in that directory, but it is called only if index

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

details. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

details. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

marked as submitted. Review request for Documentation, KDE Frameworks and Elvis Angelaccio. Changes --- Submitted with commit 0a90d5fc7d367d5937f3cb171f56f948f93f36ef by Luigi Toscano to branch master. Bugs: 357428 https://bugs.kde.org/show_bug.cgi?id=357428 Repository: kdoctools

Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

--- Documentation of higher level frameworks (kio) and applications (kate, konsole) compiles. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

/xslt.cpp 79578ed Diff: https://git.reviewboard.kde.org/r/115597/diff/ Testing --- Documentation of higher level frameworks (kio) and applications (kate, konsole) compiles. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115708: Build on Mac OS X

. I have no idea about Windows and I don't have the resources to test it, but I hope this will be checked. - Luigi Toscano On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote: > > --- > This is an automatically generated e-

Re: Review Request 115708: Build on Mac OS X

- On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115708/ > --- > > (Updated Feb. 12, 2014, 9:46 p.m.) > > > R

Re: Review Request 115209: Fix KDoctools build on Windows

! src/xslt.cpp <https://git.reviewboard.kde.org/r/115209/#comment34978> As you are here, can you please change this to const QString result = ... ? - Luigi Toscano On Feb. 13, 2014, 7:56 p.m., Alexander Richardson

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

is really needed. The origin of that code traces back to this commit (with a reference https://bugs.kde.org/show_bug.cgi?id=293610): http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=38b5e7f937b5d2c291c5b20a0c8648632084dde5 - Luigi Toscano On Feb. 14, 2014, 12:29 a.m., Alexander Richards

Review Request 115818: Support more catalogs and reduce code duplication

https://git.reviewboard.kde.org/r/115818/diff/ Testing --- Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115853: Remove unused definition

--- DOCBOOK_XML_CURRDTD is not used, so remove its definition (leftover of kdelibs splitting). Diffs - src/ioslaves/help/config-help.h.cmake f2fe22c Diff: https://git.reviewboard.kde.org/r/115853/diff/ Testing --- kio compiles and installs. Thanks, Luigi Toscano

Re: Review Request 115853: Remove unused definition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115853/#review50115 ----------- On Feb. 17, 2014, 10:03 p.m., Luigi Toscano wrote: > > --

Review Request 115876: More generic DocBookXML -> DocBookXML4

ules/FindDocBookXML.cmake b6d623e find-modules/FindDocBookXML4.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115876/diff/ Testing --- Compiles (some changes are needed in KDocTools, I will add them to another review). Thanks, Luigi Toscano _

Review Request 115879: DocBookXML has been renamed, use the new exported variables

-kdoctools.h.cmake f2fe22c src/CMakeLists.txt 241d56f src/customization/dtd/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115879/diff/ Testing --- Compiles, the relevant files (like customization/dtd/kdex.dtd) are generated Thanks, Luigi Toscano

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

pplications/libraries using it. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/#review50181 ------- On Feb.

Re: Review Request 115897: Remove FindDocBook*.cmake

would like to make sure that the needed files (4.2) are really there, so I would like to call FindDocBookXML4 for that. - Luigi Toscano On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: > > --- > This is an automatically generated e

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

CMakeLists.txt mean that they are going to exported? - Luigi Toscano On Feb. 19, 2014, 12:47 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote:

Re: Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

-- > > (Updated Feb. 14, 2014, 12:29 a.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > The WIN32 part of this if statement doesn't

Re: Review Request 115818: Support more catalogs and reduce code duplication

break it? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115818/#review50252 --- On Feb. 16, 2014, 8:16 p.m.,

Re: Review Request 115744: Fix projects using KDocTools on windows.

is not applied? - Luigi Toscano On Feb. 19, 2014, 7:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote:

Re: Review Request 115853: Remove unused definition

/115853/diff/ Testing --- kio compiles and installs. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115818: Support more catalogs and reduce code duplication

Diffs - src/meinproc.cpp 86e83ae src/xslt.h 6fd2dae src/xslt.cpp 70e0d6a Diff: https://git.reviewboard.kde.org/r/115818/diff/ Testing --- Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote:

Re: Review Request 115744: Fix projects using KDocTools on windows.

change looks fine and it's windows only. There is enough time to fix it before the final release. - Luigi Toscano On Feb. 19, 2014, 7:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

review against the kdoctools component or can I get a shipit here? :) - Luigi Toscano On Feb. 18, 2014, 10:52 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

DocBookXML 4.5, the plan

Hi all, these are the steps of plan for bumping the default DocBook XML version to 4.5 while keeping the compatibility on the old 4.2-based when kde4support is used: 1) commit rename/changes of FindDocBookXML (RR 115876 and 115879); 2) kde4support: copy files FindDocBookXML, catalog.xml, kdex.dtd

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against > > the kdoctools component or can I get a shipit here? :) > > Alex Merry wrote: > I thought I'd already made this reply, bu

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against > > the kdoctools component or can I get a shipit here? :) > > Alex Merry wrote: > I thought I'd already made this reply, bu

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

customization/dtd/kdex.dtd) are generated Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

d them to another review). Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115956: More generic (renamed) KDocBookXML4.cmake

generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

/r/115879/#review50436 --- On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 115897: Remove FindDocBook*.cmake

? - Luigi Toscano On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115956: More generic (renamed) KDocBookXML4.cmake

/customization/dtd/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115956/diff/ Testing --- Compiles, documentation is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 115897: Remove FindDocBook*.cmake

> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? > > Alex Merry wrote: > Actually, I never committed this one, since I never got a ship it. I > added the files to kdoctools, but never removed them from e-c-m

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

/kdex.dtd.cmake c643d9b Diff: https://git.reviewboard.kde.org/r/115956/diff/ Testing --- Compiles, documentation is generated. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: KDocTools history import

Alex Merry wrote: > I screwed up the history import of the FindDocBook*.cmake files from > e-c-m into KDocTools, so Luigi asked me to do it again. This involves > removing those files, then merging in a more sensible history (that > isn't curtailed like the other one was). > > This can be found a

Re: Review Request 116037: change entities to reflect new branding

efore the final release), but please do *not* commit this until the changes described in "KDocTools history import" thread (kde-frameworks-devel) are pushed. - Luigi Toscano On Feb. 25, 2014, 1:02 a.m., T.C. Hollingsworth wrote: > > -

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115956: More generic (renamed) DocBookXML4.cmake, few fixes

. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115897: Remove FindDocBook*.cmake

kdoctools, it's time to remove them from ecm. - Luigi Toscano On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: KDE 5 versioning in documentation

Martin Klapetek wrote: > Hey, > > On Tue, Feb 25, 2014 at 1:32 AM, T.C. Hollingsworth wrote: > Will the "KDE Software Compilation" still be a thing in the KF5 era, > complete with its own versioned releases? If that's the case, we'll > probably just want to change "KDE" to "KDE SC" in

Review Request 116069: Compatibility support for DocBookXML 4.2

cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 116068: Bump supported DocBookXML version to 4.5

.org/r/116068/diff/ Testing --- Compilation (including the other RR) Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Re: Review Request 116037: change entities to reflect new branding

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review51163 --- Ship it! This review can go in :) - Luigi Toscano On Feb

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

esting --- Compilation (including the other RR) Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

ation/catalog4.xml PRE-CREATION src/customization/dtd/kdex.dtd.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano __

Re: Review Request 116124: Always compile static lib with -fPIC

devel, my knowledge in this area is not so much but you convinced me, and we have some time for going back in case of issues. - Luigi Toscano On Feb. 27, 2014, 3:21 p.m., Kevin Funk wrote: > > --- > This is an automatically genera

Re: Review Request 116037: change entities to reflect new branding

ated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116037/ > --- > > (Updated Feb. 25, 2014, 1:02 a.m.) > > > Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard > Lück, and Yuri Chornoivan. > > > R

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

David Faure wrote: > On Saturday 01 March 2014 12:49:02 Aurélien Gâteau wrote: >> If I am not mistaken, KJSEmbed depends on KDocTools because it uses >> kdoctools_create_manpage. Would it be an option to generate the man page >> without KDocTools. It's a bit sad to bump it from tier 2 to tier 3 jus

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

on/dtd/kdex.dtd.cmake c2f7b2c src/man-template.docbook bdc88c7 src/template.docbook 08762e5 Diff: https://git.reviewboard.kde.org/r/116068/diff/ Testing --- Compilation (including the other RR) Thanks, Luigi Toscano ___ Kde-frameworks

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

Diff: https://git.reviewboard.kde.org/r/116069/diff/ Testing --- Compilation of kde4support (with RR116068), then compilation of konsole. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kd

DocBookXML version is 4.5 in KF5: check your documentation

Hi all, the version of DocBookXML used by our documentation has been changed in Frameworks; our custom DTD is now based on 4.5 instead of 4.2. The change should be *almost* painless, because the new version is backward compatibile. Only the DTD needs to be changed. Exception: if your application s

Review Request 116604: Allow directories with . as output for meinproc

.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano ___ K

Re: Review Request 116604: Allow directories with . as output for meinproc

gs.kde.org/show_bug.cgi?id=246755 (I set it in this RR). The problem was that the value was passed without quotes as parameter to the the function in libxslt. But on the other side it is not used, because the output of the stylesheet is stored in a string and then written in a file (s

Re: Review Request 116604: Allow directories with . as output for meinproc

imilar patch can be applied to kdelibs/kdoctools too (same codepath). Diffs - src/meinproc.cpp 95adcea Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the d

Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

oo. KF5DocToolsMacros.cmake <https://git.reviewboard.kde.org/r/116650/#comment37094> It is needed indeed... - Luigi Toscano On March 7, 2014, 3:05 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an autom

Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

piles, and a module whose documentation still uses the old DTD (oktate) compiles correctly. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116681: Fix kio-help by adding a separator

laves/help/kio_help.cpp 85b7975 Diff: https://git.reviewboard.kde.org/r/116681/diff/ Testing --- kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now works. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailin

Re: Review Request 116681: Fix kio-help by adding a separator

ark: maybe other parts of code which use QStandardPaths should be checked. Diffs - src/ioslaves/help/kio_help.cpp 85b7975 Diff: https://git.reviewboard.kde.org/r/116681/diff/ Testing --- kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now works. Than

Review Request 116685: Import documentationnotfound in kio, used by kio-help

/documentationnotfound/index.docbook PRE-CREATION src/ioslaves/help/kio_help.cpp d693442 Diff: https://git.reviewboard.kde.org/r/116685/diff/ Testing --- kioclient cat help:/foobar shows the content of documentationnotfound instead of "There is no documentation available for /foobar." Than

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

is no documentation available for /foobar." Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

g/r/116650/#comment37141> Does it work on Windows? - Luigi Toscano On March 10, 2014, 5:17 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/#review52690 --- Ship it! Perfect, thanks! - Luigi Toscano On March 11

Re: Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

eLists.txt d436846 Diff: https://git.reviewboard.kde.org/r/116670/diff/ Testing --- It compiles, and a module whose documentation still uses the old DTD (oktate) compiles correctly. Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

content of documentationnotfound instead of "There is no documentation available for /foobar." Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

content of documentationnotfound instead of "There is no documentation available for /foobar." Thanks, Luigi Toscano ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

as a suggestion, I would explicitly mention that this is for "environments where each module is installed using a different prefix" as I wrote in the related commit (for https://git.reviewboard.kde.org/r/116670/). - Luigi Toscano On March 13, 2014, 12:59 p.m., Auréli

Re: Review Request 116785: Unbreak bootstrapping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52892 --- Ship it! Discussed on IRC - Luigi Toscano On March 13

  1   2   3   4   5   6   7   8   >