----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115708/#review49682 -----------------------------------------------------------
Ship it! It seems to work correctly, so ship it from my side. I have no idea about Windows and I don't have the resources to test it, but I hope this will be checked. - Luigi Toscano On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115708/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 9:46 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake > substitute the actual binary instead of hard-coding it. Should also fix the > build on windows, where the executable has a .exe suffix > > > Diffs > ----- > > src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a > > Diff: https://git.reviewboard.kde.org/r/115708/diff/ > > > Testing > ------- > > Building on Mac OS X > > > Thanks, > > Harald Fernengel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
