Re: Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-04 Thread Christoph Feck
appearance of frames and positioning text inside those frames. I guess what you are after is a modified OS X plugin for QPlatformTheme. - Christoph Feck On Dec. 4, 2015, 12:27 p.m., René J.V. Bertin wrote: > > --- > This is an automat

Re: Review Request 126231: Fix a small artifact of kratingwidget on hidpi

2015-12-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126231/#review89145 --- Ship it! Ship It! - Christoph Feck On Dec. 3, 2015, 8:37

Re: Reporting bugs to frameworks

2016-01-15 Thread Christoph Feck
On Friday 15 January 2016 12:55:47 Aleix Pol wrote: > Hi, > I've recently found a bug in kded. I've been trying to report it > but didn't manage to find it on the list [1]. > > What did I miss? frameworks-kdaemon ___ Kde-frameworks-devel mailing list Kd

Re: Review Request 127232: Make breeze the default icon theme name for KIconThemes

2016-02-29 Thread Christoph Feck
- Christoph Feck On March 1, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

2016-03-10 Thread Christoph Feck
> On Jan. 15, 2016, 7:20 a.m., Martin Gräßlin wrote: > > > The KIconDialog itself works fine, but the "Browse..." sub dialog, which > > > is a grand child of the modal dialog, is opened in the background and > > > cannot be used > > > > this sounds like a Qt bug or a KFileDialog bug. The sub d

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Christoph Feck
? Unless it is, I suggest to not work around the Qt bug, because the release of Qt 5.6 is imminent and this fix does not reach our users earlier. - Christoph Feck On March 12, 2016, 2:53 p.m., Anthony Fieroni wrote: > > --- > T

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Christoph Feck
. - Christoph Feck On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

2016-05-07 Thread Christoph Feck
:130:9: error: 'translation_found' was not declared in this scope ki18n/src/gettext.h:180:9: error: 'translation_found' was not declared in this scope - Christoph Feck On May 7, 2016, 4:12 a.m., Michael Pyne wrote: > > --

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Christoph Feck
worth it. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: HAVE_X11 usage in KIO/core

2014-02-08 Thread Christoph Feck
ke Gecko) > > to > > Mozilla/5.0 (compatible; Konqueror/4.0; Linux; i686; en_US) > KHTML/4.0.1 (like Gecko) > > will anyone ever care? Had to check if there is a standard that mandates the order or presence of fields, but there is not. +1 for omitting the window system

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Christoph Feck
iding a student requires someone with more in depth > knowledge then i have. (looking at David Faure ^_-) Please only add projects where a mentor is willing to take part of GSoC. Looking at persons that are swamped with other work is nice, but that won't help the potential student who

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Christoph Feck
> On Feb. 10, 2014, 7:37 p.m., Dawit Alemayehu wrote: > > Well the platform name was added for compatibility with what Firefox at the > > time. And Chromium seems to have adapted that as well. > > > > The latest stable version of Firefox (version 27) for example sends the > > following user ag

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
stores the items directly in the pointer array." - Christoph Feck On Feb. 13, 2014, 8:23 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
> On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: > > Making the type movable does not make QList store it directly, how did you > > check this? > > > > http://qt-project.org/doc/qt-5/qlist.html says: > > > > "Internally, QList is represented as

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49758 --- Ship it! Ship It! - Christoph Feck On Feb. 13, 2014, 11

Re: Review Request 115686: Fix mimetype declarations in json files

2014-02-15 Thread Christoph Feck
> On Feb. 15, 2014, 5:20 p.m., David Faure wrote: > > XV is the grand-father of image viewers, I didn't know it had an image > > format though. It's completely missing from shared-mime-info. > > I have the very strong feeling that this should be removed, it's completely > > obsolete :) > > > >

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Christoph Feck
27;t really notification specific. > > Shouldn't it rather be in kwidgets? KWidgetsAddons? I quickly looked at KPassivePopup. Unfortunately, it has some X11 specific code, which needs to be ported and/or fixed. Otherwise, I agree that it could be moved. > /Sune > - hopin

Re: Review Request 115826: Add KMessageBox::setDontShowAskAgainConfig as deprecated method

2014-02-19 Thread Christoph Feck
sense to use an inline method? - Christoph Feck On Feb. 17, 2014, 10:02 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Christoph Feck
> On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote: > > I tried to run a standalone non-GUI program using ki18n: > > > > #include > > #include > > > > int main (int argc, char *argv[]) > > { > > setlocale (LC_ALL, ""); > > KLocalizedString::setApplicationDomain("test-ki

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-24 Thread Christoph Feck
. To reply, visit: > https://git.reviewboard.kde.org/r/115982/ > --- > > (Updated Feb. 23, 2014, 9:16 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > --- > > This is a small tool that

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-03-02 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review51721 --- Ship it! Ship It! - Christoph Feck On March 2, 2014, 7:13

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-03 Thread Christoph Feck
load-time. For those operations, an exception could be made, because blending could even be hardware-accelerated. - Christoph Feck On March 3, 2014, 1:04 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-04 Thread Christoph Feck
mark it as such. If not, please add some documentation. - Christoph Feck On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52048 --- Ship it! Thanks, this supersedes 116603. - Christoph Feck

Re: KSpeech

2014-03-06 Thread Christoph Feck
nice if we had API supporting web speech. Regarding voice selection, it would be very useful to allow the application to specify female/male/child voice via API (in addition to the ability to let the user reconfigure actual voices). Similar to letting the application request Sans, Sans Serif,

Re: Review Request 116729: Add a comment explaining the "kde4" in the mime type

2014-03-11 Thread Christoph Feck
and "kde4" names (if that's even possible)? - Christoph Feck On March 11, 2014, 5 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53884 --- Ship it! Ship It! - Christoph Feck On March 23, 2014, 5

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54288 --- Could the stubs be made inline? - Christoph Feck On March

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
functions are used to access a property. src/widgets/ktextedit.cpp <https://git.reviewboard.kde.org/r/117108/#comment37983> This variable can be removed. - Christoph Feck On March 27, 2014, 10:08 a.m., Benjamin Port wrote: > > --

Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

2014-03-27 Thread Christoph Feck
g/r/117108/#comment37999> This variable can be removed. - Christoph Feck On March 27, 2014, 1:02 p.m., Benjamin Port wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-04-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54745 --- Ship it! Thanks. - Christoph Feck On April 1, 2014, 12:25

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
going to be enabled? - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()

2014-04-01 Thread Christoph Feck
e the focus from a previous widget, if activating a disabled widget fails. - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: git repo name in review request e-mail subject

2014-04-30 Thread Christoph Feck
itory via TARGET_PEOPLE in its .reviewboardrc file, then you are mailed directly, while the other review request simply go to the list. Unfortunately, this doesn't always seem to work. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-fr

Review Request 117987: Always return true for alphaBlending()

2014-05-04 Thread Christoph Feck
currently have no KF setup to test. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117987: Always return true for alphaBlending()

2014-05-08 Thread Christoph Feck
ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117987/#review57256 --- On May 4, 2014, 2:01 p.m., Christoph Feck wrote: > > --- > This is an automatically

Re: Review Request 117987: Always return true for alphaBlending()

2014-05-12 Thread Christoph Feck
/kiconloader.cpp 501367a Diff: https://git.reviewboard.kde.org/r/117987/diff/ Testing --- None, I currently have no KF setup to test. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: KConfigXT for QGroupBox?

2014-05-20 Thread Christoph Feck
between the actual buttons, and "export" the selected item ID as the user property from the containing widget (which can be a QGroupBox, but does not need to be). Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-fr

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
the specified font size is not respected, so you either need to clarify in the API docs, or create a method "setFontSizeFactor()", which defaults to 1.2, but can be changed back to 1.0. - Christoph Feck On May 26, 2014, 10 a.m., Sebastian Kü

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
> On May 26, 2014, 10:18 a.m., Christoph Feck wrote: > > The original screen shot looks bad, because the bold font looks smaller > > than the normal font. This might be because of wrong hinting settings, or > > because of a bad font design. > > > > Regarding t

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Christoph Feck
o the VDG. - Christoph Feck On May 27, 2014, midnight, Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Christoph Feck
? - Christoph Feck On May 30, 2014, 8:23 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Christoph Feck
you add is actually a GroupBox containing a supported layout, then it would internally call addWidgetsFromLayout(). Remains the issue with layouts whose children could change... - Christoph Feck On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote: > > ---

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Christoph Feck
it.reviewboard.kde.org/r/118514/ > --- > > (Updated June 4, 2014, 9:52 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > --- > > I have been asked to add ColumnResizer to

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

2014-06-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/#review59357 --- Ship it! Ship It! - Christoph Feck On June 5, 2014, 1:54

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-05 Thread Christoph Feck
still allowed to break binary compatibility? If not, please create a separate call. src/kicontheme.h <https://git.reviewboard.kde.org/r/118561/#comment41310> The comment does not clarify where the additional hint is included in the search chain (first or last). - Christoph

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-05 Thread Christoph Feck
> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? > > Christoph Feck wrote: > First, I was thinking the same. The efforts with KF5 work was to get as > much features as possible into Qt, and only keep the stuff that

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Christoph Feck
all the time. - Christoph Feck On June 6, 2014, 12:02 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 118740: Use standard message box icon size in password dialogs

2014-06-14 Thread Christoph Feck
, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Christoph Feck
://git.reviewboard.kde.org/r/118740/diff/ Testing --- None, I still do not have a KF5 setup... Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112519: trim KStyle

2013-09-04 Thread Christoph Feck
click-buddy for other widgets should not depend on the used style, so if the feature is really needed, it should be proposed upstream. Then you can also kill drawKStylePrimitive(). - Christoph Feck On Sept. 4, 2013, 7:45 p.m., Wojc

Re: Review Request 112519: trim KStyle

2013-09-04 Thread Christoph Feck
> On Sept. 4, 2013, 10:20 p.m., Christoph Feck wrote: > > staging/frameworkintegration/src/kstyle/kstyle.h, line 98 > > <http://git.reviewboard.kde.org/r/112519/diff/2/?file=187028#file187028line98> > > > > The "runtime element extension" should

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread Christoph Feck
> On Sept. 10, 2013, 9:06 p.m., David Faure wrote: > > Ship It! So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? Do we plan to have a proper/final "let's look at what we did" API review after everything has settled? - Christoph

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Christoph Feck
/src/kstyle/kstyle.cpp <http://git.reviewboard.kde.org/r/112519/#comment29713> See above. - Christoph Feck On Sept. 6, 2013, 7:48 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically gene

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Christoph Feck
f on reviewboard site? Here, I see many red "whitespace" issues now. - Christoph Feck On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: kde-workspace master becomes Qt5-based

2013-10-01 Thread Christoph Feck
On Tuesday 01 October 2013 15:25:27 Sebastian Kügler wrote: > On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote: > > > We're planning to merge the frameworks-scratch branch of > > > kde-workspace into master next Monday. > > > > I tried building the branch. It requires qimageblitz, which I

workspace fails in dateandtime kcm

2013-10-20 Thread Christoph Feck
Hi, I am getting this weird error during "make" (not "make install"): /bin/sh: /local/git/KDE/base/kde-workspace- frameworks/kcontrol/dateandtime/kcmclock_actions.actions: Permission denied make[2]: *** [kcontrol/dateandtime/org.kde.kcontrol.kcmclock.policy] Error 126 __

Re: workspace fails in dateandtime kcm

2013-10-20 Thread Christoph Feck
On Sunday 20 October 2013 12:30:05 Martin Graesslin wrote: > On Sunday 20 October 2013 11:44:48 Christoph Feck wrote: > > Hi, > > > > I am getting this weird error during "make" (not "make install"): > > > > /bin/sh: /local/git/KDE/ba

Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
e in the wrong place. Diffs - src/plasma/runnermanager.cpp ee4851f Diff: http://git.reviewboard.kde.org/r/113535/diff/ Testing --- Compiles, no further testing. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, no further testing. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, no further testing. Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
--- The standard says for C++ this is a function, I hope this is not a macro on some compilers... Diffs - khtml/src/xpath/predicate.cpp 3180fe5 Diff: http://git.reviewboard.kde.org/r/113583/diff/ Testing --- Thanks, Christoph Feck

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
for C++11, so it would break on older compilers. Is there a standard way to check if we have a C++11 compiler? - Christoph Feck On Nov. 2, 2013, 3:55 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
/diff/ Testing --- Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113583: Fix build after enabling C++11 standard

2013-11-02 Thread Christoph Feck
/diff/ Testing --- Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

2013-11-05 Thread Christoph Feck
> On Nov. 4, 2013, 4:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch > > frameworks. For whatever reason, it still installs "libKPty.so.SOVERSION", instead of "libKPty.so.5.0.0". - Christoph

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-13 Thread Christoph Feck
> On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote: > > About the .colors translations, we have this > > > > ./kdeui/colors/kcolordialog.cpp:104:{ "40.colors", > > I18N_NOOP2("palette name", "Forty Colors") }, > > ./kdeui/colors/kcolordialog.cpp:105:{ "Oxygen.colors", > > I18N

Re: [kdelibs/frameworks] /: Move cmake legacy to KDE4Support

2013-11-13 Thread Christoph Feck
R/CMakeLists.txt - 100% > similarity] R +0-0 OpenEXR is needed by tier1/kguiaddons/src/plugins/imageformats, it now omits building EXR support. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-framewo

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: >

Re: imageformat plugins

2013-11-25 Thread Christoph Feck
about this? Separate. Btw, on Qt development list, there are currently discussions about including JP2 and DDS format plugins to Qt repositories, so I am not sure how much of KImgIO will need to survive in the future. What remains could even be upstreamed to QtImageFormats rep

Re: Dialogs, QPT and Qt5

2013-11-29 Thread Christoph Feck
but I just tried Qt 5.3 Designer, and those features did not appear. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Tracking bugs in Frameworks

2013-12-16 Thread Christoph Feck
t any old place in bugzilla. * If new products/components are created for frameworks, the bug triaging team will help moving the old reports. Christoph Feck (kdepepo) KDE Quality Team openSUSE Review Team ___ Kde-frameworks-devel mailing list Kde-f

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-06 Thread Christoph Feck
ame listed, but nobody else steps up), I am willing to maintain these frameworks: - kiconthemes - kimageformats (including webp plugin from kde-runtime) - kplotting - kwidgetsaddons I may also be interested in kconfigwidgets, kcmutils, kcompletion, and kguiaddons in the future (I

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Christoph Feck
; the next message without waiting for the animation to finish? I somehow feel that the queuing should be done inside KMessageWidget. - Christoph Feck On Jan. 18, 2014, 6:13 p.m., Dominik Haumann wrote: > > --- > This is an automa

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Christoph Feck
tps://git.reviewboard.kde.org/r/115345/#comment34247> Missing ? (Question mark, because I am unsure, I did not look at either of the functions) - Christoph Feck On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote: > > ---

Re: From kdelibs4 to KDE frameworks... how to make KDE more cross platform...

2012-02-18 Thread Christoph Feck
ted in KDE when I told him that there is work in progress to replace the Windows Explorer shell. But I already feared it would be a job needing many more years of development, if it materializes at all. Christoph Feck (kdepepo) ___ Kde-frameworks-d

Re: KIcon API replacement (Re: patches on kcolors)

2012-03-15 Thread Christoph Feck
of our customs, > but as I pointed I like the "almost prototype object" idea that > Icon() would convey. > > > But I'm not necessarily against crazy ideas ;-) > > Well, I'll let you pick between icon() and Icon() then. ;-) I wou

Re: Porting the NETWM classes to xcb

2012-03-25 Thread Christoph Feck
b > [...] > kdeui/windowmanagement/netwm.h |4 + Is it really required to expose xcb headers to applications, that wish to use the netwm header file? If not, please move to netwm_p.h file. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-f

Re: API review: KDBusApplicationStarter

2012-05-22 Thread Christoph Feck
konqueror), to then talk dbus to it -- so the > above is missing an enum ServiceMode { Unique, Multiple }, where > Multiple watches for the first new process to register with > expectedService + "-$PID". > > I think what's also missing is to add a method to KService w

Re: Porting KWidgets to Qt5

2012-06-28 Thread Christoph Feck
), WindowsMenu (menu with list of > top-level windows and actions for minimizing/maximizing.closing of > current window). > > Does anyone have any thoughts about what widgets can be added? > > Ivan Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: More work available

2012-08-02 Thread Christoph Feck
On Thursday 02 August 2012 17:26:27 David Faure wrote: > For the last two weeks, I've been the only committer to kdelibs > frameworks (one week working, one week on "holidays", i.e. on my > free time). It is actually more than two weeks ago that I coined the term "DF5

Re: Sonnet status?

2012-11-08 Thread Christoph Feck
got hijacked by aliens. Natural Language Processing is a patent-loaded minefield anyway. Okey, seriously, what exactly do you have in mind for future direction of Sonnet? I am very interested in machine linguistics, but failed so far to have a concrete vision for useful/usable API. Christo

Re: Sonnet status?

2012-11-08 Thread Christoph Feck
The moment I clicked on "Send", I realized this is frameworks list... so you probably were only interested in porting status... On Thursday 08 November 2012 23:16:44 Christoph Feck wrote: > On Thursday 08 November 2012 20:24:50 Martin Sandsmark wrote: > > Anyone know the curre

Re: Review Request 108495: Make kimgio compile on Qt5

2013-01-19 Thread Christoph Feck
plugins work with Qt 5. - Christoph Feck On Jan. 19, 2013, 10:57 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108495: Port kimgio to Qt5

2013-01-21 Thread Christoph Feck
> On Jan. 21, 2013, 12:38 p.m., David Faure wrote: > > Excellent work. Two questions: > > 1) did you get a chance to test at least one of these plugins, e.g. with a > > test program that uses QImage to load a file (I don't know if we have one > > already)? > > 2) did you check whether Qt alread

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #370

2013-02-09 Thread Christoph Feck
d using the builds? This would cause higher stacks to fail when changes at a lower place are not compatible (which is good, because we want to fix them). At least that's what my local buildbot does for KDE 4, haven't yet the space to also compile Qt 5 + KF5. Ch

Re: lib or lib64?

2013-02-15 Thread Christoph Feck
; libattica.so.0.4 libsearchclient > libstreams.so.0 > libattica.so.0.4.1 libsearchclient.so > libstreams.so.0.7.8 Not answering your question, but shouldn't Qt 5 versions use a different .so number? They aren't binary compatible

Re: CamelCasing our libraries ?

2013-02-26 Thread Christoph Feck
On Tuesday 26 February 2013 21:11:43 Alexander Neundorf wrote: > How is "kjs" CamelCased ? > kjs, Kjs, KJs, KJS ? If kjs will be moved to kde4support, we should not bother renaming it. Christoph Feck (kdepepo) ___ Kde-frameworks-devel

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-13 Thread Christoph Feck
moved files, but it is impossible to see if there are any changes to them. Is there a way to view those changes, if any? - Christoph Feck On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically ge

Re: Main Toolbar/Toolbar in QToolBar

2013-08-13 Thread Christoph Feck
r". For example in Konqueror, the "Extra Toolbar" or "Bookmark Toolbar". So they are also children of QMainWindow. Christoph Feck (kdepepo) KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: oxygen vs kstyle

2013-08-20 Thread Christoph Feck
On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote: > Hi All, > > There is some traffic on the frameworks list concerning > implementing new features in kstyle. > It might be useful to mention that the current oxygen code (KDE's > default widget style) derives from QCommonStyle and not

kdelibs fails

2013-08-26 Thread Christoph Feck
Hi, I started to test KF5 builds, but it fails with this error. Interestingly, it builds on Jenkins. Any idea? In file included from /local/qt5/include/QtCore/qvariant.h:50:0, from /local/qt5/include/QtCore/qabstractitemmodel.h:45, from /local/qt5/include/QtCo

Re: kdelibs fails

2013-08-27 Thread Christoph Feck
On Tuesday 27 August 2013 17:12:08 Stephen Kelly wrote: > Christoph Feck wrote: > > /local/qt5/include/QtCore/qhash.h:857:31: error: within this > > context while (bucketIterator != it) { > > ^ > > A recent commit in qtbase was buggy and introduced this error. Oh dea

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-21 Thread Christoph Feck
in Qt, and how do we utilize that in our frameworks? If we are still simply using uncategorized qDebug(), please commit it. - Christoph Feck On June 21, 2014, 2:53 a.m., Elias Probst wrote: > > --- > This is an automatically ge

Re: Review Request 119076: KIconLoader: start by clearing the output variable

2014-07-01 Thread Christoph Feck
path of the icon is stored here, *if the icon was found. If the icon was not found @p path_store *is unaltered even if the "unknown" pixmap was returned. - Christoph Feck On July 1, 2014, 6:57 p.m., David F

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread Christoph Feck
cess to the QDialogButtonBox instead (for KPasswordDialog). This way, you have even more freedom to customize the dialog. Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-05 Thread Christoph Feck
explains why. - Christoph Feck On July 5, 2014, 10:30 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119126/#review61686 --- Ship it! Ship It! - Christoph Feck On July 5, 2014, 10:30

Translations in frameworks released tarballs

2014-07-07 Thread Christoph Feck
fforts :) Is there a way to detect and strip unused strings in the release tarballs? -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/k

  1   2   3   4   5   6   7   >