D14253: avoid memory leak over sftp

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. You can remove the "hopefully" from the commit log. setConnection is not used anywhere in KIO, and couldn't be used from outside KIO, since Connection isn't an exported class. I j

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 175 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/175/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 21 Jul 2018 08:30:32 + Build duration: 5 min 31 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/85/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 21 Jul 2018 08:30:32 + Build duration: 6 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 328 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/328/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 21 Jul 2018 08:30:32 + Build duration: 15 min and counting JUnit Tests Name: (root) Fai

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

dfaure added a comment. This change broke KFilePlacesViewTest, please update that test as well. $ bin/kfileplacesviewtest - Start testing of KFilePlacesViewTest * Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64 shared (dynamic) debug build; by G

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14158 To: jtamate, #frameworks, elvisangelaccio Cc: broulik

D14253: avoid memory leak in slave jobs

jtamate updated this revision to Diff 38163. jtamate retitled this revision from "avoid memory leak over sftp" to "avoid memory leak in slave jobs". jtamate edited the summary of this revision. jtamate added a comment. I still don't know how to avoid this leak, but I guess this will be fixed

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

This revision was automatically updated to reflect the committed changes. Closed by commit R320:0cc17f0c1b91: Avoid a kio-mtp crash when trying to add a blocked device to the device cache (authored by jtamate). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D14253: avoid memory leak in slave jobs

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The old connect syntax did not leak in itself. If you see a connection leaked, it means one of the two objects (sender or receiver) isn't deleted. REPOSITORY R241 KIO REVISION DETAIL h

D14253: avoid memory leak in slave jobs

jtamate updated this revision to Diff 38166. jtamate edited the summary of this revision. jtamate added a comment. Using --num-callers=50, the leak shows as: ==3437== 54,952 (32 direct, 54,920 indirect) bytes in 1 blocks are definitely lost in loss record 2,284 of 2,284 ==3437==

D14253: avoid memory leak in slave jobs

jtamate updated this revision to Diff 38172. jtamate edited the summary of this revision. jtamate added a comment. As I do not know how to discard new incorrect updates... The previous incorrect one creates a crash. Return to the good one and land. REPOSITORY R241 KIO CHANGES SINCE LAST

D14253: avoid memory leak in slave jobs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:021daba60faf: avoid memory leak in slave jobs (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14253?vs=38172&id=38174 REVISION DETAIL https://p

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 176 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/176/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 21 Jul 2018 11:45:03 + Build duration: 10 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/86/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 21 Jul 2018 11:45:03 + Build duration: 11 min and counting JUnit Tests Name: (root

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 329 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/329/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 21 Jul 2018 11:45:03 + Build duration: 11 min and counting JUnit Tests Name: (root) Fai

D14154: Add

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R175:8c49f9b3dfe2: more Japanese holiday updates from phanect (authored by winterz). REPOSITORY R175 PIM: KHolidays CH

D14154: re-add updates by Firas Kraiem

phanect retitled this revision from "Add " to "re-add updates by Firas Kraiem". REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D14154 To: phanect, winterz, mlaurent, #kde_pim, #frameworks Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D14154: re-add updates by Firas Kraiem

phanect added a comment. Sorry, my response is too late... I just fixed the title. Thanks for merge my commits via R175 REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D14154 To: pha

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/62/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Jul 2018 03:25:24 + Build duration: 1 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/85/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Jul 2018 03:25:24 + Build duration: 2 min 9 sec and counting JUnit Tests Name