dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
You can remove the "hopefully" from the commit log. setConnection is not used anywhere in KIO, and couldn't be used from outside KIO, since Connection isn't an exported class. I just marked setConnection/connection as deprecated and to be removed in KF6. "~SlaveInterfacePrivate should be virtual" sounds like the actual fix for this bug indeed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14253 To: jtamate, dfaure, #frameworks, ngraham Cc: anthonyfieroni, apol, kde-frameworks-devel, michaelh, ngraham, bruns
