GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/217/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 06:54:10 +
Build duration: 5 min 41 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (ro
mart updated this revision to Diff 10274.
mart added a comment.
- use QCollator
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4156?vs=10222&id=10274
BRANCH
phab/sort
REVISION DETAIL
https://phabricator.kde.org/D4156
AFFECTED FILES
src/attica/att
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/214/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 07:04:23 +
Build duration: 6 min 31 sec
CHANGE SET
No changes
JUNIT RESULTS
Na
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/218/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 08:46:14 +
Build duration: 7 min 8 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/218/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 08:46:14 +
Build duration: 7 min 8 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/215/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 10:44:04 +
Build duration: 8 min 59 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/215/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 10:44:04 +
Build duration: 8 min 59 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KF5PlasmaMacros.cmake:17
> # wallpaper, shell, lookandfeel, etc.
> -# @see Types column in plasmapkg --list-types
> +# @see Types column in kpackagetool5 --list-types
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c07851470aa1: Remove unavailable ServiceTypes (authored
by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4169?vs=10277&id=10280
REVISION
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4154
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #fram
kossebau retitled this revision from "Let KConfigDialogManager get a property's
change signal from the metaObject" to "KConfigDialogManager: get change signal
from metaObject or special property".
kossebau updated the summary for this revision.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9888ddd2e1b9: Fix some -Wdocumentation warnings (authored
by kfunk).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4154?vs=10270&id=10284
REVISION DETAIL
https://ph
kossebau updated this revision to Diff 10285.
kossebau added a comment.
small fix in unit test
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4130?vs=10263&id=10285
BRANCH
readChangeSignalFromMetaObject
REVISION DETAIL
https://phabricator.kde.o
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/
---
(Updated Jan. 17, 2017, 4:04 p.m.)
Status
--
This change has been ma
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
unfortunately hiddenvisibility is the "biggest" status
that makes computing the proper stat
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/visibilityforward
REVISION DETAIL
https://phabricator.kde.org/D4174
EMAIL PREFERENCES
https://p
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/395/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 15:05:22 +
Build duration: 32 min
CHANGE SET
Revision 9888ddd2e1b9a56686624a16043f24e5f663fa62
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/395/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 Jan 2017 15:05:22 +
Build duration: 32 min
CHANGE SET
Revision 9888ddd2e1b9a56686624a16043f24e5f663fa62
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:47ec9b84db5c: correctly forward status from applets to
containment (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4174?vs=102
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It's useful to be able to check the version and so.
TEST PLAN
Running `kglobalaccel5 --help` doesn't execute the service.
REPOSITORY
R268 KGlobalAccel
BRANCH
> On Jan. 15, 2017, 2:32 a.m., Christoph Feck wrote:
> > From what I see, the content widget is not owned by the tool tip widget.
> > What happens if I delete the tool tip widget first, then delete the content
> > widget? Does deleting automatically break the connections to the now
> > non-exi
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote:
> > enums instead of bools in APIs are good.
> >
> > It's funny to read "I want to change the default value [] but the new
> > method can't have a default value", but it actually makes sense because the
> > old method is deprecated, so anyo
> On Jan. 15, 2017, 3:32 a.m., Christoph Feck wrote:
> > From what I see, the content widget is not owned by the tool tip widget.
> > What happens if I delete the tool tip widget first, then delete the content
> > widget? Does deleting automatically break the connections to the now
> > non-exi
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4175
EMAIL PREFERENCES
https://phabricator.kde.org/settings/pa
apol created this revision.
apol added reviewers: Frameworks, cgilles.
REVISION SUMMARY
libkexiv2/src/kexiv2_p.cpp:726:9: error: token is not a valid binary operator
in a preprocessor subexpression
TEST PLAN
Builds
REPOSITORY
R378 KExiv2 Library
BRANCH
master
REVISION DETAIL
https:/
graesslin added inline comments.
INLINE COMMENTS
> main.cpp:63
>
> +{
> +QCommandLineParser parser;
Why did you scope the parser?
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4175
EMAIL PREFERENCES
https://phabricator.kde.org/s
kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.
Note: That's due to my patch in https://phabricator.kde.org/D3850
REPOSITORY
R378 KExiv2 Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote:
> > enums instead of bools in APIs are good.
> >
> > It's funny to read "I want to change the default value [] but the new
> > method can't have a default value", but it actually makes sense because the
> > old method is deprecated, so anyo
> On Jan. 17, 2017, 7:51 a.m., David Faure wrote:
> > enums instead of bools in APIs are good.
> >
> > It's funny to read "I want to change the default value [] but the new
> > method can't have a default value", but it actually makes sense because the
> > old method is deprecated, so anyo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129844/
---
(Updated Jan. 17, 2017, 10:31 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129849/
---
Review request for KDE Frameworks and Christoph Feck.
Repository: kwidget
apol added inline comments.
INLINE COMMENTS
> graesslin wrote in main.cpp:63
> Why did you scope the parser?
So that it frees the QCLP resources as we're not going to be using them
anymore. I agree it's not much, but also there's little reason to keep it alive
for the whole run of the process.
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:8e6f7b79c863: Introduce a QCommandLineParser for
kglobalaccel5 (authored by apol).
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4175?vs=10293&id=10304
REVIS
kossebau reopened this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
Seems the porting script had a few wrong matches, where 0 values for enums
were misinterpreted as pointer:
E.g.
@@ -1015 +1015 @@ void KWindowSystemPrivateX11::setShowingDesk
kossebau requested changes to this revision.
kossebau added a reviewer: kossebau.
kossebau added a comment.
This revision now requires changes to proceed.
To have this somehow flagged as broken I set it now to "Request Changes".
Please close again once there is a new separate diff opened.
REP
This revision was automatically updated to reflect the committed changes.
Closed by commit R378:bcf6308bd11a: Fix compilation with clang (authored by
apol).
REPOSITORY
R378 KExiv2 Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4179?vs=10297&id=10307
REVISION DETAIL
https:/
jsalatas created this revision.
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to R246 Sonnet.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This patch fixes a Segm
38 matches
Mail list logo
