kossebau reopened this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
Seems the porting script had a few wrong matches, where 0 values for enums
were misinterpreted as pointer:
E.g.
@@ -1015 +1015 @@ void KWindowSystemPrivateX11::setShowingDesktop(bool
showing)
- NETRootInfo info(QX11Info::connection(), 0, NET::WM2ShowingDesktop);
+ NETRootInfo info(QX11Info::connection(), nullptr,
NET::WM2ShowingDesktop);
@@ -1021 +1021 @@ void KWindowSystemPrivateX11::setUserTime(WId win, long
time)
- NETWinInfo info(QX11Info::connection(), win,
QX11Info::appRootWindow(), 0, 0);
+ NETWinInfo info(QX11Info::connection(), win,
QX11Info::appRootWindow(), nullptr, nullptr);
or
--- a/src/kdeui/kprogressdialog.h
+++ b/src/kdeui/kprogressdialog.h
@@ -63,2 +63,2 @@ public:
- explicit KProgressDialog(QWidget *parent = 0, const QString &caption =
QString(),
- const QString &text = QString(),
Qt::WindowFlags flags = 0);
+ explicit KProgressDialog(QWidget *parent = nullptr, const QString
&caption = QString(),
+ const QString &text = QString(),
Qt::WindowFlags flags = nullptr);
or
@@ -2048 +2048 @@ void KUrlTest::testQueryItem()
- QCOMPARE(QStringList(queryUrl.queryItems(0).keys()).join(", "),
+ QCOMPARE(QStringList(queryUrl.queryItems(nullptr).keys()).join(", "),
or
--- a/src/kdecore/kdatetimeformatter_p.h
+++ b/src/kdecore/kdatetimeformatter_p.h
@@ -49 +49 @@ public:
- KLocale::TimeFormatOptions timeOptions = 0,
+ KLocale::TimeFormatOptions timeOptions =
nullptr,
Just a few random hits I saw in the "9000 lines in total" file, no time to
scan everything.
Sorry for the late notification, only stumbled now about similar issues in
KDevelop code and assumed a similar script to be used here ;)
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, dfaure
Cc: kossebau, dfaure, graesslin
