Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

2014-11-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/#review69709 --- Ship it! This is the approach we agreed upon in another revie

Jenkins build became unstable: kio_master_qt5 #430

2014-11-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #868

2014-11-03 Thread KDE CI System
See Changes: [notmart] don't forward events if there is no mainItem -- [...truncated 425 lines...] [ 26%] Built target platformcomponentsplugin [ 27%] Buil

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #868

2014-11-03 Thread KDE CI System
See Changes: [notmart] don't forward events if there is no mainItem -- [...truncated 437 lines...] [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasm

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #869

2014-11-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #869

2014-11-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Ksshaskpass ?

2014-11-03 Thread Jeremy Whiting
Laurent, Thanks for fixing those. On Sun, Nov 2, 2014 at 11:20 PM, laurent Montel wrote: > Hi, > I fixed some problem: > - translate program > - fix command line parser > - Fix version > - Use astyle-kdelibs to reform code > - etc. > > I think it will ok now :) > > Regards. > > > Le Sunday 02 No

Re: OSX/CI: kio-extras builds to fail on branch master

2014-11-03 Thread Mathias Tillman
Hi, could you try the attached patch? I added some edge-cases to test for the existence of 64-bit, unsigned long long, XDR functions (for some reason there are multiple). Hopefully this should allow compilation on OSX. Regards Mathias On Sun, Nov 2, 2014 at 9:13 PM, Mark Gaiser wrote: > On Sun,

DLL version info on WIndows

2014-11-03 Thread Nicolás Alvarez
Windows has a way for executables and shared libraries (DLLs) to contain version information in a machine-readable format. This information can be seen in Explorer in the file properties (http://goo.gl/UbJGte) and also in the tooltip when hovering the file. It's also used by Windows Installer to av

Re: Ksshaskpass ?

2014-11-03 Thread Marko Käning
Hi Laurent, I’ve added a Jenkins job for ksshaskpass. I haven’t started the 1st build yet, as I intend to wait for an hour until the dependencies have migrated onto Jenkins master [2]. Greets, Marko [1] http://build.kde.org/view/FAILED/job/ksshaskpass_master_qt5/ [2] http://commits.kde.org/k

Re: Ksshaskpass ?

2014-11-03 Thread Jeremy Whiting
ksshaskpass has no more krazy issues and has been moved to kdereview. I think it's final resting place should be kde/workspace but I'm open to other ideas. It is usable on other platforms besides plasma, but it saves passwords in kwallet, so may make the most sense there. thanks, Jeremy P.S. We m

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120959/ --- (Updated Nov. 3, 2014, 10:21 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120959/ --- (Updated nov. 3, 2014, 11:06 après-midi) Status -- This change has b

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA