> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote:
> > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the
> > facebook resource builds fine without this patch).
> >
> > KF5PimUtilsTargets.cmake sets this:
> > set_target_properties(KF5::PimUtils PROPERTIES
> > INTERFACE_INCLUDE_DIRECTORIES
> > "${_IMPORT_PREFIX}/include/KF5/KPIMUtils;${_IMPORT_PREFIX}/include/KF5"
> > )
> >
> > so, example:
> > #include <KPIMUtils/Email> (ie (install
> > prefix)/include/KF5/KPIMUtils/KPIMUtils/Email) won't have troubles finding
> > kpimutils/email.h (ie (install
> > prefix)/include/KF5/KPIMUtils/kpimutils/email.h)
>
> Martin Klapetek wrote:
> Well nothing in current Frameworks5 collection installs headers like
> this, so I'm not sure why kdepimlibs is/should be different. I'll add the
> frameworks group to weigh in.
>
> > and the facebook resource builds fine without this patch
>
> Fwiw, the facebook resource is disabled in master and it in no way builds
> fine, there are many other build errors, this is just one of them :)
ls /kde/inst/5/attica/include/KF5/Attica
attica Attica
ls /kde/inst/5/baloo/include/KF5/Baloo
baloo Baloo
ls /kde/inst/5/kdeclarative/include/KF5/KDeclarative
kdeclarative KDeclarative quickaddons QuickAddons
ls /kde/inst/5/kdesu/include/KF5/KDESu
kdesu KDESu
and so on...
The first KPIMUtils is the module name, that's consistent with all the current
frameworks
The second one is there to give a hint that the include should be
KPIMUtils/PrettyHeader and not just PrettyHeader.
That's why you can't see this for all frameworks.
- Christophe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120959/#review69749
-----------------------------------------------------------
On nov. 3, 2014, 9:21 après-midi, Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120959/
> -----------------------------------------------------------
>
> (Updated nov. 3, 2014, 9:21 après-midi)
>
>
> Review request for KDE Frameworks, KDEPIM-Libraries and Laurent Montel.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> The generated headers have "#include "kpimutils/linklocator.h" but since they
> are being installed in KPIMUtils/KPIMUtils/, the inclusion fails because
> those real headers are installed in KPIMUtils/kpimutils (rather than
> KPIMUtils/KPIMUtils/kpimutils). I also don't see a reason why to install into
> KPIMUtils/KPIMUtils/...?
>
>
> Diffs
> -----
>
> kpimutils/src/CMakeLists.txt 1acc88e
>
> Diff: https://git.reviewboard.kde.org/r/120959/diff/
>
>
> Testing
> -------
>
> Akonadi-facebook fails to build with "kpimutils/linklocator.h - No such file
> or directory", with this it no longer gives the error.
>
>
> Thanks,
>
> Martin Klapetek
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
