Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated March 4, 2016, 5:42 p.m.) Status -- This change has been ma

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93157 --- Ship it! Ship It! - Andreas Hartmetz On March 3, 2016,

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated March 3, 2016, 10:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On March 3, 2016, 7:43 p.m., Andreas Hartmetz wrote: > > > > Andreas Hartmetz wrote: > OK, this looks good now overall. The comment about the indexOf() is of > course about the whole truncating at space thing, not the particular line. > > Krzysztof Nowicki wrote: > The idea of this l

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On March 3, 2016, 8:43 p.m., Andreas Hartmetz wrote: > > > > Andreas Hartmetz wrote: > OK, this looks good now overall. The comment about the indexOf() is of > course about the whole truncating at space thing, not the particular line. The idea of this line and the conditional behind it i

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93120 --- src/ioslaves/http/http.cpp (line 5442)

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated March 3, 2016, 12:40 p.m.) Review request for KDE Frameworks and

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93084 --- Fix it, then Ship it! src/ioslaves/http/http.cpp (line 53

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated Feb. 29, 2016, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On Feb. 21, 2016, 7:07 p.m., Andreas Hartmetz wrote: > > m_triedPasswords doesn't really tell the truth if the application didn't > > supply a password, right? It is not really a number of tried passwords, it > > is the state of a little state machine. In such cases, it is better to make > >

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92617 --- m_triedPasswords doesn't really tell the truth if the applica

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92576 --- Ship it! Ship It! - David Faure On Feb. 9, 2016, 9:53 p

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated Feb. 9, 2016, 10:53 p.m.) Review request for KDE Frameworks and

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92112 --- src/ioslaves/http/http.cpp (line 5413)

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated Feb. 5, 2016, 12:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On Feb. 5, 2016, 9:38 a.m., David Faure wrote: > > What if this kio_http instance is then reused to connect to another host? > > Shouldn't these lists ("blacklisted auth methods" etc.) be cleared? Fair point. I guess the blacklist needs to be cleared upon disconnecting from the server. I'll

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92075 --- What if this kio_http instance is then reused to connect to a

Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- Review request for KDE Frameworks and Dawit Alemayehu. Repository: kio