Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On gen. 20, 2016, 12:02 p.m., Lorenzo Porta wrote: > > src/kmainwindow.cpp, lines 213-214 > > > > > > These don't work because a null domain return nothing. You must replace > > Q_NULLPTR with KLocalizedString

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review91379 --- src/kmainwindow.cpp (lines 213 - 214)

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 22, 2015, 12:31 a.m.) Status -- This change has been m

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87175 --- Ship it! Ship It! - Albert Astals Cid On oct. 21, 2015, 12

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 21, 2015, 12:50 a.m.) Review request for KDE Frameworks, Lo

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Oct. 20, 2015, 2:40 a.m., Michael Pyne wrote: > > Though I made the suggested changes I'm now worried we might need API > > changes in KAboutData to do this properly... it seems to me that > > KAboutData::applicationData() is improperly specified to return a copy of > > KAboutData instead

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On oct. 20, 2015, 2:40 a.m., Michael Pyne wrote: > > Though I made the suggested changes I'm now worried we might need API > > changes in KAboutData to do this properly... it seems to me that > > KAboutData::applicationData() is improperly specified to return a copy of > > KAboutData instead

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87108 --- Though I made the suggested changes I'm now worried we might n

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 20, 2015, 2:36 a.m.) Review request for KDE Frameworks, Loc

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Окт. 18, 2015, 10:44 пре п., Albert Astals Cid wrote: > > src/kmainwindow.cpp, line 209 > > > > > > This is not going to work, you need to undefine TRANSLATION_DOMAIN > > include klocalizedstring again and

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Oct. 18, 2015, 8:49 a.m., Albert Astals Cid wrote: > > Two more things: > > * I think this should only be done if translators() is empty > > * You should document this is going to fill in KAboutData::translators if > > empty with those values > > Thomas Eschenbacher wrote: > So what

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Okt. 18, 2015, 8:49 vorm., Albert Astals Cid wrote: > > Two more things: > > * I think this should only be done if translators() is empty > > * You should document this is going to fill in KAboutData::translators if > > empty with those values So what about this approach: We just remove

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Okt. 18, 2015, 6:50 vorm., Thomas Eschenbacher wrote: > > This should work, but IMHO it does not go far enough. I can see many more > > calls to QCoreApplication::translate(...) with user defined content in this > > file (kaboutdata.cpp), which is also affected, as for example credits, >

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87000 --- Two more things: * I think this should only be done if transl

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On oct. 18, 2015, 6:50 a.m., Thomas Eschenbacher wrote: > > This should work, but IMHO it does not go far enough. I can see many more > > calls to QCoreApplication::translate(...) with user defined content in this > > file (kaboutdata.cpp), which is also affected, as for example credits, > >

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review86998 --- src/kmainwindow.cpp (line 209)

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review86995 --- This should work, but IMHO it does not go far enough. I can se

Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and