Re: Review Request 121315: Allow using kded modules with JSON metadata

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- (Updated Feb. 3, 2015, 10:11 a.m.) Status -- This change has been ma

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread David Faure
> On Dec. 20, 2014, 11:58 a.m., David Faure wrote: > > Looks good to me overall (for the details, you're the expert ;) > > > > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is > > that documented somewhere else BTW? > > > > (Right now I would even need a solution for

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread Alex Richardson
> On Dez. 20, 2014, 11:58 vorm., David Faure wrote: > > Looks good to me overall (for the details, you're the expert ;) > > > > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is > > that documented somewhere else BTW? > > > > (Right now I would even need a solution for

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- (Updated Dez. 29, 2014, 5:55 nachm.) Review request for KDE Frameworks an

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/#review72335 --- Ship it! Looks good to me overall (for the details, you're th

Review Request 121315: Allow using kded modules with JSON metadata

2014-12-01 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- Review request for KDE Frameworks and David Faure. Repository: kded Des