> On Dec. 20, 2014, 11:58 a.m., David Faure wrote: > > Looks good to me overall (for the details, you're the expert ;) > > > > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is > > that documented somewhere else BTW? > > > > (Right now I would even need a solution for KMimeTypeTrader -> > > KPluginMetaData, but filtering by mimetype doesn't seem to be available?) > > Alex Richardson wrote: > Not quite sure how KMimeTypeTrader works, I will have to look into that. > > I don't think it is documented anywhere. If you tell me what page I > should add it to I can write a little bit on the wiki.
KMimeTypeTrader adds "filtering on a mimetype" (including derived mimetypes), compared to what KServiceTypeTrader/KPluginMetaData do. About where to document, I see two options: 1) https://community.kde.org/Frameworks/Porting_Notes 2) in the api docs for KPluginMetaData. I guess both are needed. The first one written more like "how to port", while the second one should have sample code for "how to use" - even when not coming from KServiceTypeTrader. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/#review72335 ----------------------------------------------------------- On Dec. 29, 2014, 5:55 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121315/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 5:55 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kded > > > Description > ------- > > The old .desktop based ones will still be loaded (with a debug message). > > > Diffs > ----- > > src/kded.cpp 40e549f6443d5cd2b26c5f9bad9695462a3467aa > src/kded.h a91a94ce1e68032156eb070bdb1e722410d44b64 > > Diff: https://git.reviewboard.kde.org/r/121315/diff/ > > > Testing > ------- > > everything seems to work correctly. > > No plugins are converted yet so they are all still loaded from .desktop files > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
