Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-12-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Dec. 2, 2014, 1:16 p.m.) Status -- This change has been mar

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-12-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71188 --- Ship it! Ship It! - David Faure On Dec. 1, 2014, 2:02 p.m.

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-12-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Dec. 1, 2014, 3:02 p.m.) Review request for KDE Frameworks and D

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-12-01 Thread Martin Gräßlin
> On Dec. 1, 2014, 1:45 p.m., David Faure wrote: > > This isn't a Qt5/KF5 porting issue, right? IIUC the same issue happens in > > kdelibs4? This isn't an argument against fixing it, of course, I'm just > > curious. I haven't checked the kdelibs4 version, but I assume it's the same there. -

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-12-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71168 --- This isn't a Qt5/KF5 porting issue, right? IIUC the same issue

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-27 Thread Martin Gräßlin
> On Nov. 27, 2014, 2:49 p.m., Eike Hein wrote: > > src/widgets/kdesktopfileactions.h, line 97 > > > > > > Isn't this BIC? You can't extend a signature even when the parameter > > has a default arg, no? > > http

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71016 --- src/widgets/kdesktopfileactions.h

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Nov. 24, 2014, 7:53 p.m.) Review request for KDE Frameworks and

Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- Review request for KDE Frameworks. Repository: kio Description ---