----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71016 -----------------------------------------------------------
src/widgets/kdesktopfileactions.h <https://git.reviewboard.kde.org/r/121233/#comment49601> Isn't this BIC? You can't extend a signature even when the parameter has a default arg, no? https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B suggests to add a new function with the extended sig. - Eike Hein On Nov. 24, 2014, 6:53 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121233/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 6:53 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > KDesktopFileActions::run did not accept the optional argument > QByteArray asn which meant that any application startup id passed > to KRun got dropped at this point when launching a desktop file. > > This change ensures that an ASN is passed along. This way we can > properly pass around the application which launched the process > and the timestamp which triggered the launch (otherwise klauncher > needs a roundtrip to the X-Server to fetch the latest timestamp). > > > Diffs > ----- > > src/widgets/kdesktopfileactions.cpp > 0cbeb00f0c0344b5b204f0d18b7c269da6c99e7f > src/widgets/kdesktopfileactions.h 7b96ff079c752436aebd0b134b930171ea088f48 > src/widgets/krun.cpp c623b583716e492622e0d1d1c9cec485c6bcf163 > > Diff: https://git.reviewboard.kde.org/r/121233/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
