Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 2, 2014, 2:29 p.m.) Status -- This change has been mar

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread Martin Klapetek
> On Oct. 2, 2014, 9:10 a.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 820 > > > > > > I would merge it with the if (enabled... above, there's no point going > > forward from there if we're g

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread David Edmundson
> On Oct. 2, 2014, 7:10 a.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 820 > > > > > > I would merge it with the if (enabled... above, there's no point going > > forward from there if we're g

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/#review67795 --- Ship it! Looks good src/kstatusnotifieritem.cpp

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 1, 2014, 4:43 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 1, 2014, 4:43 p.m.) Review request for KDE Frameworks. Re

Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- Review request for KDE Frameworks. Repository: knotifications Descripti