> On Oct. 2, 2014, 9:10 a.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 820 > > <https://git.reviewboard.kde.org/r/120449/diff/2/?file=315991#file315991line820> > > > > I would merge it with the if (enabled... above, there's no point going > > forward from there if we're going to return two lines down > > David Edmundson wrote: > I thought I wanted setLegacySystemTrayEnabled(false); to still delete and > cleanup things.
(btw. I meant the very first "if (enabled.." at the top, line 813) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/#review67795 ----------------------------------------------------------- On Oct. 1, 2014, 6:43 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120449/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 6:43 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > KStatusNotifierItem falls back to making a QSystemTray. With the KDE Qt > plugin our QSystemTrays create a StatusNotifierItem at which point we > are in infinite recursion. > > This happens on bootup if we try to create a SNI before plasma is loaded but > the KDE platform theme is being loaded. (for example the keyboard layout SNI > which is in a KDED and loaded first) > > Alternate approach to my preferred https://git.reviewboard.kde.org/r/120243/ > which simply removes the legacy support. > > > **NOTE WE NEED A FIX IN THIS RELEASE OTHERWISE ALL PLASMA SESSIONS WILL > COMPLETELY BREAK AS SOON AS Qt 5.4 COMES OUT.** > > > Diffs > ----- > > src/kstatusnotifieritem.cpp 767537d > > Diff: https://git.reviewboard.kde.org/r/120449/diff/ > > > Testing > ------- > > Logged in successfully. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
