Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-06 Thread John Layt
> On April 30, 2014, 1:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-04 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117888/ --- (Updated May 4, 2014, 8:29 p.m.) Status -- This change has been mark

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread Alex Merry
> On April 30, 2014, 12:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread Alex Merry
> On April 30, 2014, 12:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread John Layt
> On April 30, 2014, 1:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-04-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117888/#review56981 --- Well, it looks like nothing that has been ported is using it (

Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-04-29 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117888/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript