Re: Review Request 129663: Don't break accelerators in KToolBar

2017-02-26 Thread David Faure
> On Feb. 12, 2017, 8:13 a.m., David Faure wrote: > > "Qt doesn't do this" = Qt doesn't strip '&' from action texts in toolbars? > > I can't confirm that. > > > > With this patch and my kxmlgui patch reverted, I get "Open File (F)" and > > "Print (P)" in the konqueror toolbar, and Alt+F opens

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-02-26 Thread Martin Tobias Holmedahl Sandsmark
> On Feb. 12, 2017, 8:13 a.m., David Faure wrote: > > "Qt doesn't do this" = Qt doesn't strip '&' from action texts in toolbars? > > I can't confirm that. > > > > With this patch and my kxmlgui patch reverted, I get "Open File (F)" and > > "Print (P)" in the konqueror toolbar, and Alt+F opens

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129663/#review102508 --- "Qt doesn't do this" = Qt doesn't strip '&' from action text

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-02-11 Thread Martin Tobias Holmedahl Sandsmark
> On Jan. 29, 2017, 7:32 p.m., David Faure wrote: > > Actually, Alt+letter for actions in toolbars doesn't work anymore. I > > *think* it worked long ago, when e.g. konqueror's toolbars had > > &Location: [URL LineEdit] > > > > But re-reading the comment, that is exactly the point: no accel f

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129663/#review102317 --- Actually, Alt+letter for actions in toolbars doesn't work an

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-29 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Albert Astals Cid
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-14 Thread Albert Astals Cid
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-14 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-08 Thread David Faure
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2016-12-18 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129663: Don't break accelerators in KToolBar

2016-12-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129663/#review101488 --- I agree that doing this in Show is far too late - and that K