----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129663/#review102508 -----------------------------------------------------------
"Qt doesn't do this" = Qt doesn't strip '&' from action texts in toolbars? I can't confirm that. With this patch and my kxmlgui patch reverted, I get "Open File (F)" and "Print (P)" in the konqueror toolbar, and Alt+F opens the file menu and Alt+P does nothing. Accelerators do not work. I see what you mean with the Control button in dolphin, but that is a bit different, it's a QToolButton created by code directly, not a QAction. So I stand by what I said: Qt strips '&' from *action* texts in toolbars (and it happens in QAction::iconText). - David Faure On Dec. 17, 2016, 12:23 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129663/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2016, 12:23 p.m.) > > > Review request for KDE Frameworks, David Faure and Chusslove Illich. > > > Repository: kxmlgui > > > Description > ------- > > Don't try to strip out accelerators in the KToolBar event handler. It makes > no sense to me, potentially creates an endless repaint loop and fights with > KAcceleratorManager which will constantly re-add accelerators. > > > Diffs > ----- > > src/ktoolbar.cpp 31be9b0 > > Diff: https://git.reviewboard.kde.org/r/129663/diff/ > > > Testing > ------- > > With this patch not only the control button in Dolphin has an accelerator. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
