Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 24, 2015, 12:06 p.m.) Status -- This change has been

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 11:33 p.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > > > > > Why this manual loop instead of strlen()? Does that mean that null > > characters in the middle are vali

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 24, 2015, 12:33 a.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > > > > > Why this manual loop instead of strlen()? Does that mean that null > > characters in the middle are vali

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79415 --- src/lib/io/kdirwatch.cpp (line 303)

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79411 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 23, 2015,

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79404 --- +1 from me, but I don't want to hit ship it without hearing fr

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 5:19 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 6:55 p.m., Milian Wolff wrote: > > How are kf5 releases handled btw? Do I need to push this into some branch? > > There are none in kcoreaddons. This patch here should probably be put into > > a patch release (if we do this for kf5). The current schedule is one release eve

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 12:55 p.m., Milian Wolff wrote: > > How are kf5 releases handled btw? Do I need to push this into some branch? > > There are none in kcoreaddons. This patch here should probably be put into > > a patch release (if we do this for kf5). > > Luigi Toscano wrote: > The cur

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79400 --- LGTM, but I think having/modifying a unit test for this change

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 4:50 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79399 --- How are kf5 releases handled btw? Do I need to push this into