Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On May 15, 2015, 8:08 p.m., Hrvoje Senjan wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 300 > > > > > > This somehow breaks dialogs from QFileDialog. e.g. standarddialogs' > > QFileDialo

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On May 15, 2015, 6:08 p.m., Hrvoje Senjan wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 300 > > > > > > This somehow breaks dialogs from QFileDialog. e.g. standarddialogs' > > QFileDialo

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review80415 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 300)

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- (Updated April 17, 2015, 8 a.m.) Status -- This change has been mark

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review79085 --- Ship it! Ship It! - Jeremy Whiting On April 12, 2015, 3:20

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On April 12, 2015, 10:43 a.m., Jeremy Whiting wrote: > > Looks good to me. The explanation makes sense also. I did see most dialogs > > working after Lukas' fix, but the one launched from chromium via kdialog > > still hung after that. This should fix that (I'll test it later today) Yep, chr

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78864 --- Looks good to me. The explanation makes sense also. I did see

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- (Updated April 12, 2015, 9:20 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78840 --- Do you reckon you would be able to work on a unit test for tha

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On April 11, 2015, 8:15 p.m., Lukáš Tinkl wrote: > > This is weird, I've explicitely tested both cases here on Qt 5.4 and they > > worked fine QFileDialog *d = new QFileDialog(parent); d->open(); This one just cannot work, because it will fall to the (parent && !parent->inherits("QWidgetWin

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78835 --- This is weird, I've explicitely tested both cases here on Qt 5