----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ -----------------------------------------------------------
(Updated April 17, 2015, 8 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Lukáš Tinkl. Changes ------- Submitted with commit 26406a9aa01d6f4f01a3f084b51451de8385c8fc by David Rosca to branch master. Repository: frameworkintegration Description ------- 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae fixed QML file dialogs but broke QtWidgets dialogs. QFileDialog static functions - dialog would open, but any user interaction is blocked (cannot select files or click on anything). QFileDialog *d = new QFileDialog(parent); d->open(); - dialog would not open at all The first issue occurs because exec() is called on already shown dialog. This is fixed by explicit hide() before calling exec() - kind of hacky :/ The second issue is fixed by always calling show(). Diffs ----- autotests/CMakeLists.txt 00e4a41 autotests/kfiledialog_unittest.cpp 45a139a autotests/kfiledialogqml_unittest.cpp PRE-CREATION autotests/qml/filedialog_parentless.qml PRE-CREATION autotests/qml/filedialog_withparent.qml PRE-CREATION src/platformtheme/kdeplatformfiledialoghelper.cpp 92ab107 Diff: https://git.reviewboard.kde.org/r/123335/diff/ Testing ------- QML dialogs: example from bug 334963 works fine file dialog from plasma desktop settings -> wallpapers works fine QtWidgets dialogs: static dialogs from qtbase/examples/widgets/dialogs/standarddialogs works fine QFileDialog *d = new QFileDialog(parent); d->open(); works fine test app: https://paste.kde.org/psddcng5n I'm running Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
