Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-26 Thread Alexander Richardson
> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alex Merry
> On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alex Merry
> On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alexander Richardson
> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? Would be better, but

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 --- cmake/FindLibIntl.cmake

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 24, 2014, 5:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alexander Richardson
> On Jan. 24, 2014, 2:04 p.m., Alex Merry wrote: > > CMakeLists.txt, line 47 > > > > > > Oh, also, should this be something like (WIN32) or (WIN32 AND NOT > > CYGWIN)? > > > > (Is WIN32 defined under CYG

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48204 --- CMakeLists.txt

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48203 --- CMakeLists.txt