Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/ --- (Updated Feb. 1, 2014, 7:41 a.m.) Status -- This change has been mar

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48733 --- This review has been submitted with commit 77f8148cea518bc580

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Alex Merry
> On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Martin Gräßlin
> On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Alex Merry
> On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Martin Gräßlin
> On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48700 --- Ship it! Looks like it should be functionally equivalent to t

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/ --- (Updated Jan. 27, 2014, 9:54 a.m.) Review request for KDE Frameworks. C

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48352 --- src/kselectionowner.h