----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48352 -----------------------------------------------------------
src/kselectionowner.h <https://git.reviewboard.kde.org/r/115230/#comment34192> No chance to issue a warning at runtime when hitting that case? - Kevin Ottens On Jan. 22, 2014, 3:18 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115230/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 3:18 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > Add platform check to KSelectionOwner and KSelectionWatcher > > These are highly X11 specific classes and don't make any sense on a > platform other than xcb and were potentially crashy by using QX11Info > without verifying that the platform is used. > > The implementation will now only create the d-ptr in case that the > code is running on the xcb platform and ensures that no call to xcb > is done unconditionally. All methods perform an early return in case > the d-ptr is null. Non-void methods return a sensible default value > in this case. > > > Diffs > ----- > > src/kselectionowner.h 512bd5ebc6336c3a07d78dd964599d3f48d8eb33 > src/kselectionowner.cpp 3715267e280822ba541196d9c63fd28f58cdc7ee > src/kselectionwatcher.h 798fe70bfc8175764f3fc3d09de97d971d5e57ad > src/kselectionwatcher.cpp 87e0a9612f2bc6ced3de7c31797411b1eb183d41 > > Diff: https://git.reviewboard.kde.org/r/115230/diff/ > > > Testing > ------- > > unit test is not failing. No test on non-X11, though. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
