Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43389 --- Ship it! tier1/kguiaddons/src/plugins/imageformats/eps.cpp

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43387 --- This review has been submitted with commit 72c38260b34bf03f0f3

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43388 --- This review has been submitted with commit 858b2416420e5c5e1da

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/ --- (Updated Nov. 10, 2013, 7:05 p.m.) Status -- This change has been mar

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43385 --- This review has been submitted with commit b6873bb4c752e518b5d

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43386 --- This review has been submitted with commit eecc95e4a8939924492

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
> On Nov. 10, 2013, 6:39 p.m., David Faure wrote: > > tier1/kguiaddons/src/plugins/imageformats/eps.cpp, line 246 > > > > > > My suggestion was simply QImageReader ppmReader(io, "ppm"), to let it > > read directl

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43380 --- Ship it! One more thing, but if this isn't possible, then ship

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
> On Nov. 10, 2013, 11:20 a.m., David Faure wrote: > > tier1/kguiaddons/src/plugins/imageformats/eps.cpp, line 300 > > > > > > isn't there a better method to call than pid()? You're right; I missed the state() me

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/ --- (Updated Nov. 10, 2013, 6:16 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43334 --- tier1/kguiaddons/src/plugins/imageformats/eps.cpp