----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43388 -----------------------------------------------------------
This review has been submitted with commit 858b2416420e5c5e1dabb581e7b10a858923135d by Alex Merry to branch frameworks. - Commit Hook On Nov. 10, 2013, 6:16 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113704/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2013, 6:16 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > 4 commits. Previously, writing support was completely broken (it would write > a PDF file instead of an EPS file). The rest of the changes mostly make it > more maintainable. > > > Disable EPS plugin on non-UNIX systems > > It depends on the gs command-line utility being in PATH, which is > unlikely on Windows, for example. > > > Use QProcess to run gs when reading EPS images > > > Fix writing EPS files > > QPrinter is no longer capable of producing PostScript files, so we > output to PDF then used GhostScript (or pdftops from Poppler) to convert > the result to EPS. Note that GhostScript is already used by the reading > code. > > > Use qCDebug for the EPS plugin > > > Diffs > ----- > > tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt > 005859ac6fd792f2589339bc68437dd2d965cc8f > tier1/kguiaddons/src/plugins/imageformats/eps.cpp > cb25052a9d7a01ea7a8ed8014726b762e8a5da16 > > Diff: http://git.reviewboard.kde.org/r/113704/diff/ > > > Testing > ------- > > Successfully converted a JPG file to EPS and back again; both the final JPG > and the intermediate EPS file display properly with Gwenview/Okular from KDE > SC 4. This works both with pdftops present in PATH and without it (providing > gs is in PATH). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
