Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-11-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/#review42936 --- This review has been submitted with commit c4a1d70dc4e8501fbbf

Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-11-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/ --- (Updated Nov. 4, 2013, 11:13 a.m.) Status -- This change has been mar

Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-11-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/#review42834 --- Ship it! Looks good, modulo the comments below. modules/ECMI